automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: [dpdk-test-report] |WARNING| pw18629 [PATCH v3 04/33] drivers/common/dpaa2: adding qbman driver
Date: Thu, 29 Dec 2016 06:14:56 +0100 (CET)	[thread overview]
Message-ID: <20161229051457.064BBF929@dpdk.org> (raw)
In-Reply-To: <1482988612-6638-5-git-send-email-shreyansh.jain@nxp.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/18629

_coding style issues_


WARNING:TYPECAST_INT_CONSTANT: Unnecessary typecast of c90 int constant
#688: FILE: drivers/common/dpaa2/qbman/include/compat.h:313:
+#define BITS_MASK(idx)	((unsigned long)1 << ((idx) & (BITS_PER_ULONG - 1)))

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 24)
#2860: FILE: drivers/common/dpaa2/qbman/qbman_portal.c:815:
+	if ((response_verb == QBMAN_RESULT_DQ) &&
[...]
+			atomic_inc(&s->vdq.busy);

WARNING:TYPECAST_INT_CONSTANT: Unnecessary typecast of c90 int constant
#3983: FILE: drivers/common/dpaa2/qbman/qbman_private.h:160:
+	unsigned long start = p & ~(unsigned long)15;

WARNING:TYPECAST_INT_CONSTANT: Unnecessary typecast of c90 int constant
#3984: FILE: drivers/common/dpaa2/qbman/qbman_private.h:161:
+	unsigned long end = (p + sz + 15) & ~(unsigned long)15;

total: 0 errors, 4 warnings, 4219 lines checked

           reply	other threads:[~2016-12-29  5:14 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1482988612-6638-5-git-send-email-shreyansh.jain@nxp.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161229051457.064BBF929@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=shreyansh.jain@nxp.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).