From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 064BBF929; Thu, 29 Dec 2016 06:14:56 +0100 (CET)
In-Reply-To: <1482988612-6638-5-git-send-email-shreyansh.jain@nxp.com>
References: <1482988612-6638-5-git-send-email-shreyansh.jain@nxp.com>
To: test-report@dpdk.org
Cc: Shreyansh Jain <shreyansh.jain@nxp.com>
Message-Id: <20161229051457.064BBF929@dpdk.org>
Date: Thu, 29 Dec 2016 06:14:56 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw18629 [PATCH v3 04/33]
	drivers/common/dpaa2: adding qbman driver
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Dec 2016 05:14:57 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/18629

_coding style issues_


WARNING:TYPECAST_INT_CONSTANT: Unnecessary typecast of c90 int constant
#688: FILE: drivers/common/dpaa2/qbman/include/compat.h:313:
+#define BITS_MASK(idx)	((unsigned long)1 << ((idx) & (BITS_PER_ULONG - 1)))

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 24)
#2860: FILE: drivers/common/dpaa2/qbman/qbman_portal.c:815:
+	if ((response_verb == QBMAN_RESULT_DQ) &&
[...]
+			atomic_inc(&s->vdq.busy);

WARNING:TYPECAST_INT_CONSTANT: Unnecessary typecast of c90 int constant
#3983: FILE: drivers/common/dpaa2/qbman/qbman_private.h:160:
+	unsigned long start = p & ~(unsigned long)15;

WARNING:TYPECAST_INT_CONSTANT: Unnecessary typecast of c90 int constant
#3984: FILE: drivers/common/dpaa2/qbman/qbman_private.h:161:
+	unsigned long end = (p + sz + 15) & ~(unsigned long)15;

total: 0 errors, 4 warnings, 4219 lines checked