* [dpdk-test-report] |WARNING| pw18723 [PATCH v2 11/18] net/ixgbe: parse n-tuple filter
[not found] <1483084390-53159-12-git-send-email-wei.zhao1@intel.com>
@ 2016-12-30 7:59 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2016-12-30 7:59 UTC (permalink / raw)
To: test-report; +Cc: Wei Zhao
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/18723
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'item' - possible side-effects?
#106: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:8103:
+#define NEXT_ITEM_OF_PATTERN(item, pattern, index)\
+ do { \
+ item = pattern + index;\
+ while (item->type == RTE_FLOW_ITEM_TYPE_VOID) {\
+ index++; \
+ item = pattern + index; \
+ } \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pattern' - possible side-effects?
#106: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:8103:
+#define NEXT_ITEM_OF_PATTERN(item, pattern, index)\
+ do { \
+ item = pattern + index;\
+ while (item->type == RTE_FLOW_ITEM_TYPE_VOID) {\
+ index++; \
+ item = pattern + index; \
+ } \
+ } while (0)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'pattern' may be better as '(pattern)' to avoid precedence issues
#106: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:8103:
+#define NEXT_ITEM_OF_PATTERN(item, pattern, index)\
+ do { \
+ item = pattern + index;\
+ while (item->type == RTE_FLOW_ITEM_TYPE_VOID) {\
+ index++; \
+ item = pattern + index; \
+ } \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects?
#106: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:8103:
+#define NEXT_ITEM_OF_PATTERN(item, pattern, index)\
+ do { \
+ item = pattern + index;\
+ while (item->type == RTE_FLOW_ITEM_TYPE_VOID) {\
+ index++; \
+ item = pattern + index; \
+ } \
+ } while (0)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'index' may be better as '(index)' to avoid precedence issues
#106: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:8103:
+#define NEXT_ITEM_OF_PATTERN(item, pattern, index)\
+ do { \
+ item = pattern + index;\
+ while (item->type == RTE_FLOW_ITEM_TYPE_VOID) {\
+ index++; \
+ item = pattern + index; \
+ } \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'act' - possible side-effects?
#115: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:8112:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)\
+ do { \
+ act = actions + index; \
+ while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {\
+ index++; \
+ act = actions + index; \
+ } \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'actions' - possible side-effects?
#115: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:8112:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)\
+ do { \
+ act = actions + index; \
+ while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {\
+ index++; \
+ act = actions + index; \
+ } \
+ } while (0)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'actions' may be better as '(actions)' to avoid precedence issues
#115: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:8112:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)\
+ do { \
+ act = actions + index; \
+ while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {\
+ index++; \
+ act = actions + index; \
+ } \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects?
#115: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:8112:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)\
+ do { \
+ act = actions + index; \
+ while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {\
+ index++; \
+ act = actions + index; \
+ } \
+ } while (0)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'index' may be better as '(index)' to avoid precedence issues
#115: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:8112:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)\
+ do { \
+ act = actions + index; \
+ while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {\
+ index++; \
+ act = actions + index; \
+ } \
+ } while (0)
CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#181: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:8178:
+
+ }
CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#214: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:8211:
+
+ }
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 24)
#221: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:8218:
+ if (ipv4_mask->hdr.version_ihl ||
[...]
+ rte_flow_error_set(error,
CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#270: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:8267:
+
+ }
total: 0 errors, 1 warnings, 13 checks, 443 lines checked
^ permalink raw reply [flat|nested] only message in thread