From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id A1F5CF91C; Thu,  5 Jan 2017 16:50:38 +0100 (CET)
In-Reply-To: <1483631170-16681-8-git-send-email-beilei.xing@intel.com>
References: <1483631170-16681-8-git-send-email-beilei.xing@intel.com>
To: test-report@dpdk.org
Cc: Beilei Xing <beilei.xing@intel.com>
Message-Id: <20170105155038.A1F5CF91C@dpdk.org>
Date: Thu,  5 Jan 2017 16:50:38 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw18931 [PATCH v6 07/17] net/i40e: add
	flow validate function
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Jan 2017 15:50:38 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/18931

_coding style issues_


WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#89: FILE: drivers/net/i40e/i40e_ethdev.c:8439:
+extern const struct rte_flow_ops i40e_flow_ops;

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'act' - possible side-effects?
#254: FILE: drivers/net/i40e/i40e_flow.c:95:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)                        \
+	do {                                                            \
+		act = actions + index;                                  \
+		while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {        \
+			index++;                                        \
+			act = actions + index;                          \
+		}                                                       \
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'actions' - possible side-effects?
#254: FILE: drivers/net/i40e/i40e_flow.c:95:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)                        \
+	do {                                                            \
+		act = actions + index;                                  \
+		while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {        \
+			index++;                                        \
+			act = actions + index;                          \
+		}                                                       \
+	} while (0)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'actions' may be better as '(actions)' to avoid precedence issues
#254: FILE: drivers/net/i40e/i40e_flow.c:95:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)                        \
+	do {                                                            \
+		act = actions + index;                                  \
+		while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {        \
+			index++;                                        \
+			act = actions + index;                          \
+		}                                                       \
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects?
#254: FILE: drivers/net/i40e/i40e_flow.c:95:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)                        \
+	do {                                                            \
+		act = actions + index;                                  \
+		while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {        \
+			index++;                                        \
+			act = actions + index;                          \
+		}                                                       \
+	} while (0)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'index' may be better as '(index)' to avoid precedence issues
#254: FILE: drivers/net/i40e/i40e_flow.c:95:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)                        \
+	do {                                                            \
+		act = actions + index;                                  \
+		while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {        \
+			index++;                                        \
+			act = actions + index;                          \
+		}                                                       \
+	} while (0)

CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv4>
#489: FILE: drivers/net/i40e/i40e_flow.c:330:
+			if (filter->ether_type == ETHER_TYPE_IPv4 ||

CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv6>
#490: FILE: drivers/net/i40e/i40e_flow.c:331:
+			    filter->ether_type == ETHER_TYPE_IPv6 ||

total: 0 errors, 1 warnings, 7 checks, 570 lines checked