From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Beilei Xing <beilei.xing@intel.com>
Subject: [dpdk-test-report] |WARNING| pw18958 [PATCH v7 07/17] net/i40e: add flow validate function
Date: Fri, 6 Jan 2017 06:28:54 +0100 (CET) [thread overview]
Message-ID: <20170106052854.1EE1BF942@dpdk.org> (raw)
In-Reply-To: <1483680439-82227-8-git-send-email-beilei.xing@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/18958
_coding style issues_
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#89: FILE: drivers/net/i40e/i40e_ethdev.c:8502:
+extern const struct rte_flow_ops i40e_flow_ops;
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'act' - possible side-effects?
#254: FILE: drivers/net/i40e/i40e_flow.c:95:
+#define NEXT_ITEM_OF_ACTION(act, actions, index) \
+ do { \
+ act = actions + index; \
+ while (act->type == RTE_FLOW_ACTION_TYPE_VOID) { \
+ index++; \
+ act = actions + index; \
+ } \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'actions' - possible side-effects?
#254: FILE: drivers/net/i40e/i40e_flow.c:95:
+#define NEXT_ITEM_OF_ACTION(act, actions, index) \
+ do { \
+ act = actions + index; \
+ while (act->type == RTE_FLOW_ACTION_TYPE_VOID) { \
+ index++; \
+ act = actions + index; \
+ } \
+ } while (0)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'actions' may be better as '(actions)' to avoid precedence issues
#254: FILE: drivers/net/i40e/i40e_flow.c:95:
+#define NEXT_ITEM_OF_ACTION(act, actions, index) \
+ do { \
+ act = actions + index; \
+ while (act->type == RTE_FLOW_ACTION_TYPE_VOID) { \
+ index++; \
+ act = actions + index; \
+ } \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects?
#254: FILE: drivers/net/i40e/i40e_flow.c:95:
+#define NEXT_ITEM_OF_ACTION(act, actions, index) \
+ do { \
+ act = actions + index; \
+ while (act->type == RTE_FLOW_ACTION_TYPE_VOID) { \
+ index++; \
+ act = actions + index; \
+ } \
+ } while (0)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'index' may be better as '(index)' to avoid precedence issues
#254: FILE: drivers/net/i40e/i40e_flow.c:95:
+#define NEXT_ITEM_OF_ACTION(act, actions, index) \
+ do { \
+ act = actions + index; \
+ while (act->type == RTE_FLOW_ACTION_TYPE_VOID) { \
+ index++; \
+ act = actions + index; \
+ } \
+ } while (0)
CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv4>
#489: FILE: drivers/net/i40e/i40e_flow.c:330:
+ if (filter->ether_type == ETHER_TYPE_IPv4 ||
CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv6>
#490: FILE: drivers/net/i40e/i40e_flow.c:331:
+ filter->ether_type == ETHER_TYPE_IPv6 ||
total: 0 errors, 1 warnings, 7 checks, 570 lines checked
parent reply other threads:[~2017-01-06 5:28 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1483680439-82227-8-git-send-email-beilei.xing@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170106052854.1EE1BF942@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=beilei.xing@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).