* [dpdk-test-report] |WARNING| pw18958 [PATCH v7 07/17] net/i40e: add flow validate function
[not found] <1483680439-82227-8-git-send-email-beilei.xing@intel.com>
@ 2017-01-06 5:28 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2017-01-06 5:28 UTC (permalink / raw)
To: test-report; +Cc: Beilei Xing
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/18958
_coding style issues_
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#89: FILE: drivers/net/i40e/i40e_ethdev.c:8502:
+extern const struct rte_flow_ops i40e_flow_ops;
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'act' - possible side-effects?
#254: FILE: drivers/net/i40e/i40e_flow.c:95:
+#define NEXT_ITEM_OF_ACTION(act, actions, index) \
+ do { \
+ act = actions + index; \
+ while (act->type == RTE_FLOW_ACTION_TYPE_VOID) { \
+ index++; \
+ act = actions + index; \
+ } \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'actions' - possible side-effects?
#254: FILE: drivers/net/i40e/i40e_flow.c:95:
+#define NEXT_ITEM_OF_ACTION(act, actions, index) \
+ do { \
+ act = actions + index; \
+ while (act->type == RTE_FLOW_ACTION_TYPE_VOID) { \
+ index++; \
+ act = actions + index; \
+ } \
+ } while (0)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'actions' may be better as '(actions)' to avoid precedence issues
#254: FILE: drivers/net/i40e/i40e_flow.c:95:
+#define NEXT_ITEM_OF_ACTION(act, actions, index) \
+ do { \
+ act = actions + index; \
+ while (act->type == RTE_FLOW_ACTION_TYPE_VOID) { \
+ index++; \
+ act = actions + index; \
+ } \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects?
#254: FILE: drivers/net/i40e/i40e_flow.c:95:
+#define NEXT_ITEM_OF_ACTION(act, actions, index) \
+ do { \
+ act = actions + index; \
+ while (act->type == RTE_FLOW_ACTION_TYPE_VOID) { \
+ index++; \
+ act = actions + index; \
+ } \
+ } while (0)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'index' may be better as '(index)' to avoid precedence issues
#254: FILE: drivers/net/i40e/i40e_flow.c:95:
+#define NEXT_ITEM_OF_ACTION(act, actions, index) \
+ do { \
+ act = actions + index; \
+ while (act->type == RTE_FLOW_ACTION_TYPE_VOID) { \
+ index++; \
+ act = actions + index; \
+ } \
+ } while (0)
CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv4>
#489: FILE: drivers/net/i40e/i40e_flow.c:330:
+ if (filter->ether_type == ETHER_TYPE_IPv4 ||
CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv6>
#490: FILE: drivers/net/i40e/i40e_flow.c:331:
+ filter->ether_type == ETHER_TYPE_IPv6 ||
total: 0 errors, 1 warnings, 7 checks, 570 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-01-06 5:28 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1483680439-82227-8-git-send-email-beilei.xing@intel.com>
2017-01-06 5:28 ` [dpdk-test-report] |WARNING| pw18958 [PATCH v7 07/17] net/i40e: add flow validate function checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).