From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id 06454F94F; Thu, 12 Jan 2017 09:46:09 +0100 (CET) In-Reply-To: <1484210439-61746-12-git-send-email-wei.zhao1@intel.com> References: <1484210439-61746-12-git-send-email-wei.zhao1@intel.com> To: test-report@dpdk.org Cc: Wei Zhao Message-Id: <20170112084609.06454F94F@dpdk.org> Date: Thu, 12 Jan 2017 09:46:09 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw19200 [PATCH v4 11/18] net/ixgbe: parse n-tuple filter X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jan 2017 08:46:09 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/19200 _coding style issues_ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'item' - possible side-effects? #89: FILE: drivers/net/ixgbe/ixgbe_flow.c:109: +#define NEXT_ITEM_OF_PATTERN(item, pattern, index)\ + do { \ + item = pattern + index;\ + while (item->type == RTE_FLOW_ITEM_TYPE_VOID) {\ + index++; \ + item = pattern + index; \ + } \ + } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pattern' - possible side-effects? #89: FILE: drivers/net/ixgbe/ixgbe_flow.c:109: +#define NEXT_ITEM_OF_PATTERN(item, pattern, index)\ + do { \ + item = pattern + index;\ + while (item->type == RTE_FLOW_ITEM_TYPE_VOID) {\ + index++; \ + item = pattern + index; \ + } \ + } while (0) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'pattern' may be better as '(pattern)' to avoid precedence issues #89: FILE: drivers/net/ixgbe/ixgbe_flow.c:109: +#define NEXT_ITEM_OF_PATTERN(item, pattern, index)\ + do { \ + item = pattern + index;\ + while (item->type == RTE_FLOW_ITEM_TYPE_VOID) {\ + index++; \ + item = pattern + index; \ + } \ + } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects? #89: FILE: drivers/net/ixgbe/ixgbe_flow.c:109: +#define NEXT_ITEM_OF_PATTERN(item, pattern, index)\ + do { \ + item = pattern + index;\ + while (item->type == RTE_FLOW_ITEM_TYPE_VOID) {\ + index++; \ + item = pattern + index; \ + } \ + } while (0) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'index' may be better as '(index)' to avoid precedence issues #89: FILE: drivers/net/ixgbe/ixgbe_flow.c:109: +#define NEXT_ITEM_OF_PATTERN(item, pattern, index)\ + do { \ + item = pattern + index;\ + while (item->type == RTE_FLOW_ITEM_TYPE_VOID) {\ + index++; \ + item = pattern + index; \ + } \ + } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'act' - possible side-effects? #98: FILE: drivers/net/ixgbe/ixgbe_flow.c:118: +#define NEXT_ITEM_OF_ACTION(act, actions, index)\ + do { \ + act = actions + index; \ + while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {\ + index++; \ + act = actions + index; \ + } \ + } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'actions' - possible side-effects? #98: FILE: drivers/net/ixgbe/ixgbe_flow.c:118: +#define NEXT_ITEM_OF_ACTION(act, actions, index)\ + do { \ + act = actions + index; \ + while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {\ + index++; \ + act = actions + index; \ + } \ + } while (0) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'actions' may be better as '(actions)' to avoid precedence issues #98: FILE: drivers/net/ixgbe/ixgbe_flow.c:118: +#define NEXT_ITEM_OF_ACTION(act, actions, index)\ + do { \ + act = actions + index; \ + while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {\ + index++; \ + act = actions + index; \ + } \ + } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects? #98: FILE: drivers/net/ixgbe/ixgbe_flow.c:118: +#define NEXT_ITEM_OF_ACTION(act, actions, index)\ + do { \ + act = actions + index; \ + while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {\ + index++; \ + act = actions + index; \ + } \ + } while (0) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'index' may be better as '(index)' to avoid precedence issues #98: FILE: drivers/net/ixgbe/ixgbe_flow.c:118: +#define NEXT_ITEM_OF_ACTION(act, actions, index)\ + do { \ + act = actions + index; \ + while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {\ + index++; \ + act = actions + index; \ + } \ + } while (0) CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #187: FILE: drivers/net/ixgbe/ixgbe_flow.c:207: + + } WARNING:TABSTOP: Statements should start on a tabstop #202: FILE: drivers/net/ixgbe/ixgbe_flow.c:222: + return -rte_errno; CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #220: FILE: drivers/net/ixgbe/ixgbe_flow.c:240: + + } WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 24) #227: FILE: drivers/net/ixgbe/ixgbe_flow.c:247: + if (ipv4_mask->hdr.version_ihl || [...] + rte_flow_error_set(error, CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #278: FILE: drivers/net/ixgbe/ixgbe_flow.c:298: + + } WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #411: FILE: drivers/net/ixgbe/ixgbe_flow.c:431: + if (attr->priority < IXGBE_MIN_N_TUPLE_PRIO || [...] + filter->priority = 1; total: 0 errors, 3 warnings, 13 checks, 454 lines checked