From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id BFEA2F960; Fri, 13 Jan 2017 09:18:22 +0100 (CET)
In-Reply-To: <1484295192-34009-12-git-send-email-wei.zhao1@intel.com>
References: <1484295192-34009-12-git-send-email-wei.zhao1@intel.com>
To: test-report@dpdk.org
Cc: Wei Zhao <wei.zhao1@intel.com>
Message-Id: <20170113081822.BFEA2F960@dpdk.org>
Date: Fri, 13 Jan 2017 09:18:22 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw19317 [PATCH v6 11/18] net/ixgbe:
	parse n-tuple filter
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Jan 2017 08:18:22 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/19317

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'item' - possible side-effects?
#89: FILE: drivers/net/ixgbe/ixgbe_flow.c:109:
+#define NEXT_ITEM_OF_PATTERN(item, pattern, index)\
+	do {		\
+		item = pattern + index;\
+		while (item->type == RTE_FLOW_ITEM_TYPE_VOID) {\
+		index++;				\
+		item = pattern + index;		\
+		}						\
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pattern' - possible side-effects?
#89: FILE: drivers/net/ixgbe/ixgbe_flow.c:109:
+#define NEXT_ITEM_OF_PATTERN(item, pattern, index)\
+	do {		\
+		item = pattern + index;\
+		while (item->type == RTE_FLOW_ITEM_TYPE_VOID) {\
+		index++;				\
+		item = pattern + index;		\
+		}						\
+	} while (0)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'pattern' may be better as '(pattern)' to avoid precedence issues
#89: FILE: drivers/net/ixgbe/ixgbe_flow.c:109:
+#define NEXT_ITEM_OF_PATTERN(item, pattern, index)\
+	do {		\
+		item = pattern + index;\
+		while (item->type == RTE_FLOW_ITEM_TYPE_VOID) {\
+		index++;				\
+		item = pattern + index;		\
+		}						\
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects?
#89: FILE: drivers/net/ixgbe/ixgbe_flow.c:109:
+#define NEXT_ITEM_OF_PATTERN(item, pattern, index)\
+	do {		\
+		item = pattern + index;\
+		while (item->type == RTE_FLOW_ITEM_TYPE_VOID) {\
+		index++;				\
+		item = pattern + index;		\
+		}						\
+	} while (0)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'index' may be better as '(index)' to avoid precedence issues
#89: FILE: drivers/net/ixgbe/ixgbe_flow.c:109:
+#define NEXT_ITEM_OF_PATTERN(item, pattern, index)\
+	do {		\
+		item = pattern + index;\
+		while (item->type == RTE_FLOW_ITEM_TYPE_VOID) {\
+		index++;				\
+		item = pattern + index;		\
+		}						\
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'act' - possible side-effects?
#98: FILE: drivers/net/ixgbe/ixgbe_flow.c:118:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)\
+	do {								\
+		act = actions + index;					\
+		while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {\
+		index++;					\
+		act = actions + index;				\
+		}							\
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'actions' - possible side-effects?
#98: FILE: drivers/net/ixgbe/ixgbe_flow.c:118:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)\
+	do {								\
+		act = actions + index;					\
+		while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {\
+		index++;					\
+		act = actions + index;				\
+		}							\
+	} while (0)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'actions' may be better as '(actions)' to avoid precedence issues
#98: FILE: drivers/net/ixgbe/ixgbe_flow.c:118:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)\
+	do {								\
+		act = actions + index;					\
+		while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {\
+		index++;					\
+		act = actions + index;				\
+		}							\
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects?
#98: FILE: drivers/net/ixgbe/ixgbe_flow.c:118:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)\
+	do {								\
+		act = actions + index;					\
+		while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {\
+		index++;					\
+		act = actions + index;				\
+		}							\
+	} while (0)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'index' may be better as '(index)' to avoid precedence issues
#98: FILE: drivers/net/ixgbe/ixgbe_flow.c:118:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)\
+	do {								\
+		act = actions + index;					\
+		while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {\
+		index++;					\
+		act = actions + index;				\
+		}							\
+	} while (0)

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#198: FILE: drivers/net/ixgbe/ixgbe_flow.c:218:
+
+		}

WARNING:TABSTOP: Statements should start on a tabstop
#213: FILE: drivers/net/ixgbe/ixgbe_flow.c:233:
+			  return -rte_errno;

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#231: FILE: drivers/net/ixgbe/ixgbe_flow.c:251:
+
+	}

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 24)
#238: FILE: drivers/net/ixgbe/ixgbe_flow.c:258:
+	if (ipv4_mask->hdr.version_ihl ||
[...]
+			rte_flow_error_set(error,

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#289: FILE: drivers/net/ixgbe/ixgbe_flow.c:309:
+
+	}

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#422: FILE: drivers/net/ixgbe/ixgbe_flow.c:442:
+	if (attr->priority < IXGBE_MIN_N_TUPLE_PRIO ||
[...]
+	    filter->priority = 1;

total: 0 errors, 3 warnings, 13 checks, 444 lines checked