From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id 53A0937B1; Fri, 20 Jan 2017 11:25:01 +0100 (CET) In-Reply-To: <1484882498-18653-3-git-send-email-jing.d.chen@intel.com> References: <1484882498-18653-3-git-send-email-jing.d.chen@intel.com> To: test-report@dpdk.org Cc: "Chen Jing D(Mark)" Message-Id: <20170120102501.53A0937B1@dpdk.org> Date: Fri, 20 Jan 2017 11:25:01 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw19835 [RFC 2/2] prgdev: introduce generic prgdev API X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jan 2017 10:25:01 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/19835 _coding style issues_ WARNING:TYPO_SPELLING: 'unkown' may be misspelled - perhaps 'unknown'? #101: FILE: lib/librte_prgdev/rte_prgdev.h:45: + RTE_PRGDEV_STAT_UNKNOWN = 0, /** Device in a unkown state */ ERROR:TRAILING_WHITESPACE: trailing whitespace #129: FILE: lib/librte_prgdev/rte_prgdev.h:73: +^I/* Programable device HW version number. it's possible that app $ ERROR:TRAILING_WHITESPACE: trailing whitespace #136: FILE: lib/librte_prgdev/rte_prgdev.h:80: + ^I * can define and interpret the info. For example, a device can define $ ERROR:CODE_INDENT: code indent should use tabs where possible #136: FILE: lib/librte_prgdev/rte_prgdev.h:80: + ^I * can define and interpret the info. For example, a device can define $ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #136: FILE: lib/librte_prgdev/rte_prgdev.h:80: + ^I * can define and interpret the info. For example, a device can define $ ERROR:CODE_INDENT: code indent should use tabs where possible #137: FILE: lib/librte_prgdev/rte_prgdev.h:81: + ^I * byte[3:0] as signature for on-die personality, byte[5:4] is the major$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #137: FILE: lib/librte_prgdev/rte_prgdev.h:81: + ^I * byte[3:0] as signature for on-die personality, byte[5:4] is the major$ ERROR:CODE_INDENT: code indent should use tabs where possible #138: FILE: lib/librte_prgdev/rte_prgdev.h:82: + ^I * version, byte[7:6] is minor version. if 0xFFEA1000 is a signature for$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #138: FILE: lib/librte_prgdev/rte_prgdev.h:82: + ^I * version, byte[7:6] is minor version. if 0xFFEA1000 is a signature for$ ERROR:CODE_INDENT: code indent should use tabs where possible #139: FILE: lib/librte_prgdev/rte_prgdev.h:83: + ^I * virtio personality, major version is 0x0001, minor version is 0x0004.$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #139: FILE: lib/librte_prgdev/rte_prgdev.h:83: + ^I * virtio personality, major version is 0x0001, minor version is 0x0004.$ ERROR:CODE_INDENT: code indent should use tabs where possible #140: FILE: lib/librte_prgdev/rte_prgdev.h:84: + ^I * then signature can be defined :$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #140: FILE: lib/librte_prgdev/rte_prgdev.h:84: + ^I * then signature can be defined :$ ERROR:CODE_INDENT: code indent should use tabs where possible #155: FILE: lib/librte_prgdev/rte_prgdev.h:99: + struct rte_prg_dev_info prg_dev_info;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #155: FILE: lib/librte_prgdev/rte_prgdev.h:99: + struct rte_prg_dev_info prg_dev_info;$ WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #159: FILE: lib/librte_prgdev/rte_prgdev.h:103: +/* +* prg_dev_init routine WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #167: FILE: lib/librte_prgdev/rte_prgdev.h:111: +/* +* prg_dev_uninit routine WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #200: FILE: lib/librte_prgdev/rte_prgdev.h:144: +/* +* Query what personality is in the device. ERROR:TRAILING_WHITESPACE: trailing whitespace #212: FILE: lib/librte_prgdev/rte_prgdev.h:156: +/* $ ERROR:TRAILING_WHITESPACE: trailing whitespace #213: FILE: lib/librte_prgdev/rte_prgdev.h:157: +* Open device for programming, acquiring on-die image, etc. $ WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #213: FILE: lib/librte_prgdev/rte_prgdev.h:157: +/* +* Open device for programming, acquiring on-die image, etc. ERROR:TRAILING_WHITESPACE: trailing whitespace #214: FILE: lib/librte_prgdev/rte_prgdev.h:158: +* Need to call this function first $ ERROR:TRAILING_WHITESPACE: trailing whitespace #216: FILE: lib/librte_prgdev/rte_prgdev.h:160: +* In case the device is performing some tasks, it's device's decision on $ WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #224: FILE: lib/librte_prgdev/rte_prgdev.h:168: +/* +* Download image from host to programmable device. WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #238: FILE: lib/librte_prgdev/rte_prgdev.h:182: +/* +* Upload image from programmable device to host. ERROR:SPACING: space required after that ',' (ctx:VxV) #251: FILE: lib/librte_prgdev/rte_prgdev.h:195: + uint32_t buf_len,uint32_t *act_len); ^ ERROR:TRAILING_WHITESPACE: trailing whitespace #266: FILE: lib/librte_prgdev/rte_prgdev.h:210: +* Check if the downloaded image running on die works in expected way, optional $ WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #266: FILE: lib/librte_prgdev/rte_prgdev.h:210: +/* +* Check if the downloaded image running on die works in expected way, optional WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #274: FILE: lib/librte_prgdev/rte_prgdev.h:218: +/* +* Called to free up resources or whatever to do to hardware WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #282: FILE: lib/librte_prgdev/rte_prgdev.h:226: +/* +* Called to bind a programmable device to drivers after close function is called. WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #288: FILE: lib/librte_prgdev/rte_prgdev.h:232: +/* +* Called to unbind all functions except prgdev from drivers. total: 14 errors, 17 warnings, 242 lines checked