From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 37BC2BD28; Mon, 23 Jan 2017 13:00:54 +0100 (CET)
In-Reply-To: <1485172803-17288-3-git-send-email-hemant.agrawal@nxp.com>
References: <1485172803-17288-3-git-send-email-hemant.agrawal@nxp.com>
To: test-report@dpdk.org
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>
Message-Id: <20170123120054.37BC2BD28@dpdk.org>
Date: Mon, 23 Jan 2017 13:00:54 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw19874 [PATCHv6 02/33]
	drivers/common/dpaa2: adding qbman driver
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Jan 2017 12:00:54 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/19874

_coding style issues_


WARNING:TYPECAST_INT_CONSTANT: Unnecessary typecast of c90 int constant
#692: FILE: drivers/common/dpaa2/qbman/include/compat.h:313:
+#define BITS_MASK(idx)	((unsigned long)1 << ((idx) & (BITS_PER_ULONG - 1)))

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 24)
#2874: FILE: drivers/common/dpaa2/qbman/qbman_portal.c:818:
+	if ((response_verb == QBMAN_RESULT_DQ) &&
[...]
+			atomic_inc(&s->vdq.busy);

WARNING:TYPECAST_INT_CONSTANT: Unnecessary typecast of c90 int constant
#4003: FILE: drivers/common/dpaa2/qbman/qbman_private.h:163:
+	unsigned long start = p & ~(unsigned long)15;

WARNING:TYPECAST_INT_CONSTANT: Unnecessary typecast of c90 int constant
#4004: FILE: drivers/common/dpaa2/qbman/qbman_private.h:164:
+	unsigned long end = (p + sz + 15) & ~(unsigned long)15;

total: 0 errors, 4 warnings, 4243 lines checked