* [dpdk-test-report] |WARNING| pw20067 [RFC 17.05 v1 2/3] LPM config file read option
[not found] <1485550795-10771-3-git-send-email-rkerur@gmail.com>
@ 2017-01-27 21:00 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2017-01-27 21:00 UTC (permalink / raw)
To: test-report; +Cc: Ravi Kerur
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/20067
_coding style issues_
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#106: FILE: examples/l3fwd/l3fwd.h:104:
+#define GET_CB_FIELD(in, fd, base, lim, dlm) do { \
+ unsigned long val; \
+ char *end; \
+ errno = 0; \
+ val = strtoul((in), &end, (base)); \
+ if (errno != 0 || end[0] != (dlm) || val > (lim)) \
+ return -EINVAL; \
+ (fd) = (typeof(fd))val; \
+ (in) = end + 1; \
+} while (0)
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#491: FILE: examples/l3fwd/l3fwd_lpm.c:233:
+ if (0 == route_num)
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#499: FILE: examples/l3fwd/l3fwd_lpm.c:241:
+ if (NULL == route_rules)
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#614: FILE: examples/l3fwd/l3fwd_lpm.c:430:
+ (unsigned)route_base_v4[i].ip,
total: 0 errors, 4 warnings, 593 lines checked
^ permalink raw reply [flat|nested] only message in thread