From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id BCC2169C6; Fri, 27 Jan 2017 22:01:00 +0100 (CET) In-Reply-To: <1485550795-10771-2-git-send-email-rkerur@gmail.com> References: <1485550795-10771-2-git-send-email-rkerur@gmail.com> To: test-report@dpdk.org Cc: Ravi Kerur Message-Id: <20170127210100.BCC2169C6@dpdk.org> Date: Fri, 27 Jan 2017 22:01:00 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw20069 [RFC 17.05 v1 1/3] Merge l3fwd-acl and l3fwd X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jan 2017 21:01:00 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/20069 _coding style issues_ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 24) #2887: FILE: examples/l3fwd/l3fwd_acl.c:513: + if (rc != 0) { + acl_log("failed to read source address/mask: %s ", WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test #2969: FILE: examples/l3fwd/l3fwd_acl.c:595: + if (0 == route_num) WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test #2977: FILE: examples/l3fwd/l3fwd_acl.c:603: + if (NULL == acl_rules) WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test #2983: FILE: examples/l3fwd/l3fwd_acl.c:609: + if (NULL == route_rules) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #3091: FILE: examples/l3fwd/l3fwd_acl.c:717: + if ((context = rte_acl_create(&acl_param)) == NULL) WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 24) #3099: FILE: examples/l3fwd/l3fwd_acl.c:725: + if (rte_acl_add_rules(context, route_base, route_num) < 0) + rte_exit(EXIT_FAILURE, "add rules failed "); WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 24) #3102: FILE: examples/l3fwd/l3fwd_acl.c:728: + if (rte_acl_add_rules(context, acl_base, acl_num) < 0) + rte_exit(EXIT_FAILURE, "add rules failed "); WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #3124: FILE: examples/l3fwd/l3fwd_acl.c:750: + unsigned lcore_id; WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #3219: FILE: examples/l3fwd/l3fwd_acl.c:845: + unsigned lcore_id; WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #3360: FILE: examples/l3fwd/l3fwd_acl.c:986: + unsigned i; WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #3498: FILE: examples/l3fwd/l3fwd_acl.h:58: +#define GET_CB_FIELD(in, fd, base, lim, dlm) do { \ + unsigned long val; \ + char *end; \ + errno = 0; \ + val = strtoul((in), &end, (base)); \ + if (errno != 0 || end[0] != (dlm) || val > (lim)) \ + return -EINVAL; \ + (fd) = (typeof(fd))val; \ + (in) = end + 1; \ +} while (0) WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #3510: FILE: examples/l3fwd/l3fwd_acl.h:70: +/* + * ACL rules should have higher priorities than route ones to ensure ACL rule WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #3520: FILE: examples/l3fwd/l3fwd_acl.h:80: +/* + * Forward port info save in ACL lib starts from 1 WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #3652: FILE: examples/l3fwd/l3fwd_acl.h:212: + unsigned i; WARNING:LONG_LINE: line over 90 characters #3961: FILE: examples/l3fwd/l3fwd_lpm.c:230: + "Unable to add entry %u to v4 LPM table on socket %d ", i, socketid); WARNING:LONG_LINE: line over 90 characters #3986: FILE: examples/l3fwd/l3fwd_lpm.c:267: + "Unable to add entry %u to the l3fwd LPM table on socket %d ", i, socketid); WARNING:LONG_LINE_STRING: line over 90 characters #4107: FILE: examples/l3fwd/main.c:351: + " --"OPTION_ETH_DEST"=X,MM:MM:MM:MM:MM:MM: Ethernet destination for port X " WARNING:LONG_LINE_STRING: line over 90 characters #4117: FILE: examples/l3fwd/main.c:356: + " --"OPTION_HASH_ENTRY_NUM": Specify the hash entry number in hexadecimal to be setup " WARNING:LONG_LINE: line over 90 characters #4399: FILE: examples/l3fwd/main.c:1010: + rte_exit(EXIT_FAILURE, "Can't allocate tx buffer for port %u ", (unsigned) portid); WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #4399: FILE: examples/l3fwd/main.c:1010: + rte_exit(EXIT_FAILURE, "Can't allocate tx buffer for port %u ", (unsigned) portid); total: 1 errors, 19 warnings, 2084 lines checked