automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Subject: [dpdk-test-report] |WARNING| pw20230 [PATCH RFCv3 12/19] examples/quota_watermark: use ring space for watermarks
Date: Tue,  7 Feb 2017 15:14:13 +0100 (CET)	[thread overview]
Message-ID: <20170207141413.00FF4FA31@dpdk.org> (raw)
In-Reply-To: <1486476777-24768-13-git-send-email-bruce.richardson@intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/20230

_coding style issues_


WARNING:LEADING_SPACE: please, no spaces at the start of a line
#83: FILE: examples/quota_watermark/qw/init.c:140:
+    *high_watermark = 80 * RING_SIZE / 100;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#92: FILE: examples/quota_watermark/qw/init.c:167:
+    qw_memzone = rte_memzone_reserve(QUOTA_WATERMARK_MEMZONE_NAME, 3 * sizeof(int),$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#99: FILE: examples/quota_watermark/qw/init.c:174:
+    high_watermark = (unsigned int *) qw_memzone->addr + 2;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#117: FILE: examples/quota_watermark/qw/main.c:161:
+    unsigned int free;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#127: FILE: examples/quota_watermark/qw/main.c:191:
+            ret = rte_ring_enqueue_bulk(ring, (void *) pkts, nb_rx_pkts, &free);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#127: FILE: examples/quota_watermark/qw/main.c:191:
+            ret = rte_ring_enqueue_bulk(ring, (void *) pkts, nb_rx_pkts, &free);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#128: FILE: examples/quota_watermark/qw/main.c:192:
+            if (RING_SIZE - free > *high_watermark) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#128: FILE: examples/quota_watermark/qw/main.c:192:
+            if (RING_SIZE - free > *high_watermark) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#134: FILE: examples/quota_watermark/qw/main.c:197:
+            else if (ret == 0) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#134: FILE: examples/quota_watermark/qw/main.c:197:
+            else if (ret == 0) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#143: FILE: examples/quota_watermark/qw/main.c:251:
+            ret = rte_ring_enqueue_bulk(tx, pkts, nb_dq_pkts, NULL);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#143: FILE: examples/quota_watermark/qw/main.c:251:
+            ret = rte_ring_enqueue_bulk(tx, pkts, nb_dq_pkts, NULL);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#168: FILE: examples/quota_watermark/qwctl/commands.c:140:
+                *high_watermark = tokens->value * RING_SIZE / 100;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#168: FILE: examples/quota_watermark/qwctl/commands.c:140:
+                *high_watermark = tokens->value * RING_SIZE / 100;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#188: FILE: examples/quota_watermark/qwctl/qwctl.c:72:
+    high_watermark = (unsigned int *) qw_memzone->addr + 2;$

total: 5 errors, 10 warnings, 102 lines checked

           reply	other threads:[~2017-02-07 14:14 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1486476777-24768-13-git-send-email-bruce.richardson@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170207141413.00FF4FA31@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=bruce.richardson@intel.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).