From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 00FF4FA31; Tue,  7 Feb 2017 15:14:12 +0100 (CET)
In-Reply-To: <1486476777-24768-13-git-send-email-bruce.richardson@intel.com>
References: <1486476777-24768-13-git-send-email-bruce.richardson@intel.com>
To: test-report@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Message-Id: <20170207141413.00FF4FA31@dpdk.org>
Date: Tue,  7 Feb 2017 15:14:13 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw20230 [PATCH RFCv3 12/19]
	examples/quota_watermark: use ring space for watermarks
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Feb 2017 14:14:13 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/20230

_coding style issues_


WARNING:LEADING_SPACE: please, no spaces at the start of a line
#83: FILE: examples/quota_watermark/qw/init.c:140:
+    *high_watermark = 80 * RING_SIZE / 100;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#92: FILE: examples/quota_watermark/qw/init.c:167:
+    qw_memzone = rte_memzone_reserve(QUOTA_WATERMARK_MEMZONE_NAME, 3 * sizeof(int),$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#99: FILE: examples/quota_watermark/qw/init.c:174:
+    high_watermark = (unsigned int *) qw_memzone->addr + 2;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#117: FILE: examples/quota_watermark/qw/main.c:161:
+    unsigned int free;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#127: FILE: examples/quota_watermark/qw/main.c:191:
+            ret = rte_ring_enqueue_bulk(ring, (void *) pkts, nb_rx_pkts, &free);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#127: FILE: examples/quota_watermark/qw/main.c:191:
+            ret = rte_ring_enqueue_bulk(ring, (void *) pkts, nb_rx_pkts, &free);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#128: FILE: examples/quota_watermark/qw/main.c:192:
+            if (RING_SIZE - free > *high_watermark) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#128: FILE: examples/quota_watermark/qw/main.c:192:
+            if (RING_SIZE - free > *high_watermark) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#134: FILE: examples/quota_watermark/qw/main.c:197:
+            else if (ret == 0) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#134: FILE: examples/quota_watermark/qw/main.c:197:
+            else if (ret == 0) {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#143: FILE: examples/quota_watermark/qw/main.c:251:
+            ret = rte_ring_enqueue_bulk(tx, pkts, nb_dq_pkts, NULL);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#143: FILE: examples/quota_watermark/qw/main.c:251:
+            ret = rte_ring_enqueue_bulk(tx, pkts, nb_dq_pkts, NULL);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#168: FILE: examples/quota_watermark/qwctl/commands.c:140:
+                *high_watermark = tokens->value * RING_SIZE / 100;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#168: FILE: examples/quota_watermark/qwctl/commands.c:140:
+                *high_watermark = tokens->value * RING_SIZE / 100;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#188: FILE: examples/quota_watermark/qwctl/qwctl.c:72:
+    high_watermark = (unsigned int *) qw_memzone->addr + 2;$

total: 5 errors, 10 warnings, 102 lines checked