automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Subject: [dpdk-test-report] |WARNING| pw20237 [PATCH RFCv3 19/19] ring: add event ring implementation
Date: Tue,  7 Feb 2017 15:14:46 +0100 (CET)	[thread overview]
Message-ID: <20170207141446.E81C5FA5D@dpdk.org> (raw)
In-Reply-To: <1486476777-24768-20-git-send-email-bruce.richardson@intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/20237

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#118: FILE: app/test/test_event_ring.c:42:
+#define ERR_OUT() do { \
+	printf("Error %s:%d
", __FILE__, __LINE__); \
+	return -1; \
+} while (0)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#142: FILE: app/test/test_event_ring.c:66:
+			unsigned j;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#246: FILE: lib/librte_ring/rte_event_ring.c:63:
+rte_event_ring_create(const char *name, unsigned count, int socket_id,

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#285: FILE: lib/librte_ring/rte_event_ring.c:102:
+	 * rte_errno for us appropriately - hence no check in this this function */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#290: FILE: lib/librte_ring/rte_event_ring.c:107:
+		 * arguments above */

WARNING:TYPO_SPELLING: 'preemptable' may be misspelled - perhaps 'preemptible'?
#462: FILE: lib/librte_ring/rte_event_ring.h:53:
+ * Note: the ring implementation is not preemptable. A lcore must not

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#558: FILE: lib/librte_ring/rte_event_ring.h:149:
+struct rte_event_ring *rte_event_ring_create(const char *name, unsigned count,

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#559: FILE: lib/librte_ring/rte_event_ring.h:150:
+				 int socket_id, unsigned flags);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#723: FILE: lib/librte_ring/rte_event_ring.h:314:
+static inline unsigned __attribute__((always_inline))

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#746: FILE: lib/librte_ring/rte_event_ring.h:337:
+static inline unsigned __attribute__((always_inline))

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#771: FILE: lib/librte_ring/rte_event_ring.h:362:
+static inline unsigned __attribute__((always_inline))

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#798: FILE: lib/librte_ring/rte_event_ring.h:389:
+static inline unsigned __attribute__((always_inline))

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#825: FILE: lib/librte_ring/rte_event_ring.h:416:
+static inline unsigned __attribute__((always_inline))

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#848: FILE: lib/librte_ring/rte_event_ring.h:439:
+static inline unsigned __attribute__((always_inline))

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#873: FILE: lib/librte_ring/rte_event_ring.h:464:
+static inline unsigned __attribute__((always_inline))

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#900: FILE: lib/librte_ring/rte_event_ring.h:491:
+static inline unsigned __attribute__((always_inline))

total: 0 errors, 16 warnings, 830 lines checked

           reply	other threads:[~2017-02-07 14:14 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1486476777-24768-20-git-send-email-bruce.richardson@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170207141446.E81C5FA5D@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=bruce.richardson@intel.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).