From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id E81C5FA5D; Tue, 7 Feb 2017 15:14:46 +0100 (CET) In-Reply-To: <1486476777-24768-20-git-send-email-bruce.richardson@intel.com> References: <1486476777-24768-20-git-send-email-bruce.richardson@intel.com> To: test-report@dpdk.org Cc: Bruce Richardson Message-Id: <20170207141446.E81C5FA5D@dpdk.org> Date: Tue, 7 Feb 2017 15:14:46 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw20237 [PATCH RFCv3 19/19] ring: add event ring implementation X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Feb 2017 14:14:47 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/20237 _coding style issues_ WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided #118: FILE: app/test/test_event_ring.c:42: +#define ERR_OUT() do { \ + printf("Error %s:%d ", __FILE__, __LINE__); \ + return -1; \ +} while (0) WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #142: FILE: app/test/test_event_ring.c:66: + unsigned j; WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #246: FILE: lib/librte_ring/rte_event_ring.c:63: +rte_event_ring_create(const char *name, unsigned count, int socket_id, WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #285: FILE: lib/librte_ring/rte_event_ring.c:102: + * rte_errno for us appropriately - hence no check in this this function */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #290: FILE: lib/librte_ring/rte_event_ring.c:107: + * arguments above */ WARNING:TYPO_SPELLING: 'preemptable' may be misspelled - perhaps 'preemptible'? #462: FILE: lib/librte_ring/rte_event_ring.h:53: + * Note: the ring implementation is not preemptable. A lcore must not WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #558: FILE: lib/librte_ring/rte_event_ring.h:149: +struct rte_event_ring *rte_event_ring_create(const char *name, unsigned count, WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #559: FILE: lib/librte_ring/rte_event_ring.h:150: + int socket_id, unsigned flags); WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #723: FILE: lib/librte_ring/rte_event_ring.h:314: +static inline unsigned __attribute__((always_inline)) WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #746: FILE: lib/librte_ring/rte_event_ring.h:337: +static inline unsigned __attribute__((always_inline)) WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #771: FILE: lib/librte_ring/rte_event_ring.h:362: +static inline unsigned __attribute__((always_inline)) WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #798: FILE: lib/librte_ring/rte_event_ring.h:389: +static inline unsigned __attribute__((always_inline)) WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #825: FILE: lib/librte_ring/rte_event_ring.h:416: +static inline unsigned __attribute__((always_inline)) WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #848: FILE: lib/librte_ring/rte_event_ring.h:439: +static inline unsigned __attribute__((always_inline)) WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #873: FILE: lib/librte_ring/rte_event_ring.h:464: +static inline unsigned __attribute__((always_inline)) WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #900: FILE: lib/librte_ring/rte_event_ring.h:491: +static inline unsigned __attribute__((always_inline)) total: 0 errors, 16 warnings, 830 lines checked