From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Gowrishankar <gowrishankar.m@linux.vnet.ibm.com>
Subject: [dpdk-test-report] |WARNING| pw20540 [PATCH] i40e: implement vector PMD for altivec
Date: Sat, 18 Feb 2017 16:34:29 +0100 (CET) [thread overview]
Message-ID: <20170218153429.D0A942C60@dpdk.org> (raw)
In-Reply-To: <e9947d692913e91d1dc78b35ec1d9adb3df188ca.1487430782.git.gowrishankar.m@linux.vnet.ibm.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/20540
_coding style issues_
WARNING:LONG_LINE: line over 90 characters
#224: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:72:
+ vec_st(dma_addr0, 0, (vector unsigned long *)&rxdp[i].read);
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#241: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:89:
+ /* Flush mbuf with pkt template.
+ * Data to be rearmed is 6 bytes long.
WARNING:LONG_LINE: line over 90 characters
#332: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:180:
+ vlan0 = (vector unsigned int)vec_perm(vlan_flags, (vector unsigned char){}, *(vector unsigned char *)&vlan1);
WARNING:LONG_LINE: line over 90 characters
#335: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:183:
+ rss = (vector unsigned int)vec_perm(rss_flags, (vector unsigned char){}, *(vector unsigned char *)&rss);
WARNING:LONG_LINE: line over 90 characters
#338: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:186:
+ l3_l4e = (vector unsigned int)vec_perm(l3_l4e_flags, (vector unsigned char){}, *(vector unsigned char *)&l3_l4e);
WARNING:LONG_LINE: line over 90 characters
#363: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:211:
+ rx_pkts[0]->packet_type = i40e_rxd_pkt_type_mapping((*(vector unsigned char *)&ptype0)[0]);
WARNING:LONG_LINE: line over 90 characters
#364: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:212:
+ rx_pkts[1]->packet_type = i40e_rxd_pkt_type_mapping((*(vector unsigned char *)&ptype0)[8]);
WARNING:LONG_LINE: line over 90 characters
#365: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:213:
+ rx_pkts[2]->packet_type = i40e_rxd_pkt_type_mapping((*(vector unsigned char *)&ptype1)[0]);
WARNING:LONG_LINE: line over 90 characters
#366: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:214:
+ rx_pkts[3]->packet_type = i40e_rxd_pkt_type_mapping((*(vector unsigned char *)&ptype1)[8]);
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#370: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:218:
+ /*
+ * Notice:
CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#470: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:318:
+ mbp2 = *(vector unsigned long *)&sw_ring[pos+2];
^
CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#480: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:328:
+ *(vector unsigned long *)&rx_pkts[pos+2] = mbp2;
^
WARNING:LONG_LINE: line over 90 characters
#513: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:361:
+ pkt_mb4 = vec_perm((vector unsigned char)descs[3], (vector unsigned char){}, shuf_msk);
WARNING:LONG_LINE: line over 90 characters
#514: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:362:
+ pkt_mb3 = vec_perm((vector unsigned char)descs[2], (vector unsigned char){}, shuf_msk);
WARNING:LONG_LINE: line over 90 characters
#517: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:365:
+ sterr_tmp2 = vec_mergel((vector unsigned short)descs[3], (vector unsigned short)descs[2]);
WARNING:LONG_LINE: line over 90 characters
#519: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:367:
+ sterr_tmp1 = vec_mergel((vector unsigned short)descs[1], (vector unsigned short)descs[0]);
WARNING:LONG_LINE: line over 90 characters
#521: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:369:
+ pkt_mb4 = (vector unsigned char)vec_sub((vector unsigned short)pkt_mb4, crc_adjust);
WARNING:LONG_LINE: line over 90 characters
#522: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:370:
+ pkt_mb3 = (vector unsigned char)vec_sub((vector unsigned short)pkt_mb3, crc_adjust);
WARNING:LONG_LINE: line over 90 characters
#545: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:393:
+ pkt_mb2 = vec_perm((vector unsigned char)descs[1], (vector unsigned char){}, shuf_msk);
WARNING:LONG_LINE: line over 90 characters
#546: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:394:
+ pkt_mb1 = vec_perm((vector unsigned char)descs[0], (vector unsigned char){}, shuf_msk);
WARNING:LONG_LINE: line over 90 characters
#552: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:400:
+ vec_st(pkt_mb4, 0, (vector unsigned char*)&rx_pkts[pos+3]->rx_descriptor_fields1);
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#552: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:400:
+ vec_st(pkt_mb4, 0, (vector unsigned char*)&rx_pkts[pos+3]->rx_descriptor_fields1);
CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#552: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:400:
+ vec_st(pkt_mb4, 0, (vector unsigned char*)&rx_pkts[pos+3]->rx_descriptor_fields1);
^
WARNING:LONG_LINE: line over 90 characters
#553: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:401:
+ vec_st(pkt_mb3, 0, (vector unsigned char*)&rx_pkts[pos+2]->rx_descriptor_fields1);
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#553: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:401:
+ vec_st(pkt_mb3, 0, (vector unsigned char*)&rx_pkts[pos+2]->rx_descriptor_fields1);
CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#553: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:401:
+ vec_st(pkt_mb3, 0, (vector unsigned char*)&rx_pkts[pos+2]->rx_descriptor_fields1);
^
WARNING:LONG_LINE: line over 90 characters
#556: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:404:
+ pkt_mb2 = (vector unsigned char)vec_sub((vector unsigned short)pkt_mb2, crc_adjust);
WARNING:LONG_LINE: line over 90 characters
#557: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:405:
+ pkt_mb1 = (vector unsigned char)vec_sub((vector unsigned short)pkt_mb1, crc_adjust);
WARNING:LONG_LINE: line over 90 characters
#577: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:425:
+ eop_bits = vec_perm(eop_bits, (vector unsigned char){}, eop_shuf_mask);
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#579: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:427:
+ *split_packet = (*(vector unsigned int*)&eop_bits)[0];
WARNING:LONG_LINE: line over 90 characters
#593: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:441:
+ vec_st(pkt_mb2, 0, (vector unsigned char*)&rx_pkts[pos+1]->rx_descriptor_fields1);
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#593: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:441:
+ vec_st(pkt_mb2, 0, (vector unsigned char*)&rx_pkts[pos+1]->rx_descriptor_fields1);
CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#593: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:441:
+ vec_st(pkt_mb2, 0, (vector unsigned char*)&rx_pkts[pos+1]->rx_descriptor_fields1);
^
WARNING:LONG_LINE: line over 90 characters
#594: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:442:
+ vec_st(pkt_mb1, 0, (vector unsigned char*)&rx_pkts[pos]->rx_descriptor_fields1);
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#594: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:442:
+ vec_st(pkt_mb1, 0, (vector unsigned char*)&rx_pkts[pos]->rx_descriptor_fields1);
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#599: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:447:
+ var = __builtin_popcountll((*(vector unsigned long*)&staterr)[0]);
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#614: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:462:
+ /*
+ * Notice:
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#627: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:475:
+ /* vPMD receive routine that reassembles scattered packets
+ * Notice:
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#636: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:484:
+{
+
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#655: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:503:
+ unsigned i = 0;
CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#709: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:557:
+ nb_commit = nb_pkts = (uint16_t)RTE_MIN(txq->nb_tx_free, nb_pkts);
CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#771: FILE: drivers/net/i40e/i40e_rxtx_vec_altivec.c:619:
+i40e_txq_vec_setup(struct i40e_tx_queue __rte_unused *txq)
^
total: 6 errors, 28 warnings, 8 checks, 659 lines checked
parent reply other threads:[~2017-02-18 15:34 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <e9947d692913e91d1dc78b35ec1d9adb3df188ca.1487430782.git.gowrishankar.m@linux.vnet.ibm.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170218153429.D0A942C60@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=gowrishankar.m@linux.vnet.ibm.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).