automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Vladyslav Buslov <vladyslav.buslov@harmonicinc.com>
Subject: [dpdk-test-report] |WARNING| pw20541 [PATCH] lpm: extend IPv6 next hop field
Date: Sun, 19 Feb 2017 18:15:47 +0100 (CET)	[thread overview]
Message-ID: <20170219171547.D98C8559A@dpdk.org> (raw)
In-Reply-To: <1487524499-9570-1-git-send-email-vladyslav.buslov@harmonicinc.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/20541

_coding style issues_


ERROR:SPACING: space required after that ',' (ctx:VxV)
#408: FILE: app/test/test_lpm6.c:1777:
+	uint8_t ip[] = {0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0};
 	                 ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#408: FILE: app/test/test_lpm6.c:1777:
+	uint8_t ip[] = {0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0};
 	                   ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#408: FILE: app/test/test_lpm6.c:1777:
+	uint8_t ip[] = {0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0};
 	                     ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#408: FILE: app/test/test_lpm6.c:1777:
+	uint8_t ip[] = {0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0};
 	                       ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#408: FILE: app/test/test_lpm6.c:1777:
+	uint8_t ip[] = {0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0};
 	                         ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#408: FILE: app/test/test_lpm6.c:1777:
+	uint8_t ip[] = {0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0};
 	                           ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#408: FILE: app/test/test_lpm6.c:1777:
+	uint8_t ip[] = {0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0};
 	                             ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#408: FILE: app/test/test_lpm6.c:1777:
+	uint8_t ip[] = {0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0};
 	                               ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#408: FILE: app/test/test_lpm6.c:1777:
+	uint8_t ip[] = {0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0};
 	                                 ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#408: FILE: app/test/test_lpm6.c:1777:
+	uint8_t ip[] = {0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0};
 	                                   ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#408: FILE: app/test/test_lpm6.c:1777:
+	uint8_t ip[] = {0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0};
 	                                     ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#408: FILE: app/test/test_lpm6.c:1777:
+	uint8_t ip[] = {0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0};
 	                                       ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#408: FILE: app/test/test_lpm6.c:1777:
+	uint8_t ip[] = {0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0};
 	                                         ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#408: FILE: app/test/test_lpm6.c:1777:
+	uint8_t ip[] = {0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0};
 	                                           ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#408: FILE: app/test/test_lpm6.c:1777:
+	uint8_t ip[] = {0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0};
 	                                             ^

WARNING:BRACES: braces {} are not necessary for single statement blocks
#792: FILE: lib/librte_lpm/rte_lpm6.c:618:
+	if (next_hop == NULL) {
+		return -EINVAL;
+	}

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#851: FILE: lib/librte_lpm/rte_lpm6.c:710:
+		int32_t * next_hops, unsigned n)

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#851: FILE: lib/librte_lpm/rte_lpm6.c:710:
+		int32_t * next_hops, unsigned n)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#853: FILE: lib/librte_lpm/rte_lpm6.c:712:
+	unsigned i;

WARNING:BRACES: braces {} are not necessary for single statement blocks
#861: FILE: lib/librte_lpm/rte_lpm6.c:720:
+	if ((lpm == NULL) || (ips == NULL) || (next_hops == NULL)) {
+		return -EINVAL;
+	}

WARNING:LONG_LINE_COMMENT: line over 90 characters
#874: FILE: lib/librte_lpm/rte_lpm6.c:733:
+			/* Continue inspecting following levels until success or failure */

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#891: FILE: lib/librte_lpm/rte_lpm6.c:750:
+				int32_t * next_hops, unsigned n),

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#891: FILE: lib/librte_lpm/rte_lpm6.c:750:
+				int32_t * next_hops, unsigned n),

WARNING:BRACES: braces {} are not necessary for single statement blocks
#909: FILE: lib/librte_lpm/rte_lpm6.c:788:
+	if (next_hop == NULL) {
+		return -EINVAL;
+	}

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#997: FILE: lib/librte_lpm/rte_lpm6.h:240:
+		int32_t * next_hops, unsigned n);

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#997: FILE: lib/librte_lpm/rte_lpm6.h:240:
+		int32_t * next_hops, unsigned n);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1005: FILE: lib/librte_lpm/rte_lpm6.h:248:
+		int32_t * next_hops, unsigned n);

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1005: FILE: lib/librte_lpm/rte_lpm6.h:248:
+		int32_t * next_hops, unsigned n);

total: 19 errors, 9 warnings, 817 lines checked

           reply	other threads:[~2017-02-19 17:15 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1487524499-9570-1-git-send-email-vladyslav.buslov@harmonicinc.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170219171547.D98C8559A@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=test-report@dpdk.org \
    --cc=vladyslav.buslov@harmonicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).