From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Allain Legacy <allain.legacy@windriver.com>
Subject: [dpdk-test-report] |WARNING| pw20736 [PATCH 02/16] net/avp: public header files
Date: Sat, 25 Feb 2017 02:24:30 +0100 (CET) [thread overview]
Message-ID: <20170225012430.5F8708DA2@dpdk.org> (raw)
In-Reply-To: <1487985795-136044-3-git-send-email-allain.legacy@windriver.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/20736
_coding style issues_
ERROR:FSF_MAILING_ADDRESS: Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
#88: FILE: drivers/net/avp/rte_avp_common.h:20:
+ * along with this program; if not, write to the Free Software$
ERROR:FSF_MAILING_ADDRESS: Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
#89: FILE: drivers/net/avp/rte_avp_common.h:21:
+ * Foundation, Inc., 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.$
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#213: FILE: drivers/net/avp/rte_avp_common.h:145:
+ unsigned len; /**< Circular buffer length */
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#214: FILE: drivers/net/avp/rte_avp_common.h:146:
+ unsigned elem_size; /**< Pointer size - for 32/64 bit OS */
CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#240: FILE: drivers/net/avp/rte_avp_common.h:172:
+#define RTE_AVP_FEATURE_VLAN_OFFLOAD (1<<0) /**< Emulated HW VLAN offload */
^
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#471: FILE: drivers/net/avp/rte_avp_common.h:403:
+ unsigned mbuf_size;
ERROR:FSF_MAILING_ADDRESS: Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
#521: FILE: drivers/net/avp/rte_avp_fifo.h:20:
+ * along with this program; if not, write to the Free Software$
ERROR:FSF_MAILING_ADDRESS: Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL.
#522: FILE: drivers/net/avp/rte_avp_fifo.h:21:
+ * Foundation, Inc., 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.$
WARNING:MEMORY_BARRIER: memory barrier without comment
#566: FILE: drivers/net/avp/rte_avp_fifo.h:65:
+#define AVP_WMB() smp_wmb()
WARNING:MEMORY_BARRIER: memory barrier without comment
#567: FILE: drivers/net/avp/rte_avp_fifo.h:66:
+#define AVP_RMB() smp_rmb()
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#578: FILE: drivers/net/avp/rte_avp_fifo.h:77:
+avp_fifo_init(struct rte_avp_fifo *fifo, unsigned size)
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#595: FILE: drivers/net/avp/rte_avp_fifo.h:94:
+avp_fifo_put(struct rte_avp_fifo *fifo, void **data, unsigned num)
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#597: FILE: drivers/net/avp/rte_avp_fifo.h:96:
+ unsigned i = 0;
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#598: FILE: drivers/net/avp/rte_avp_fifo.h:97:
+ unsigned fifo_write = fifo->write;
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#599: FILE: drivers/net/avp/rte_avp_fifo.h:98:
+ unsigned fifo_read = fifo->read;
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#600: FILE: drivers/net/avp/rte_avp_fifo.h:99:
+ unsigned new_write = fifo_write;
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#619: FILE: drivers/net/avp/rte_avp_fifo.h:118:
+avp_fifo_get(struct rte_avp_fifo *fifo, void **data, unsigned num)
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#621: FILE: drivers/net/avp/rte_avp_fifo.h:120:
+ unsigned i = 0;
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#622: FILE: drivers/net/avp/rte_avp_fifo.h:121:
+ unsigned new_read = fifo->read;
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#623: FILE: drivers/net/avp/rte_avp_fifo.h:122:
+ unsigned fifo_write = fifo->write;
total: 4 errors, 15 warnings, 1 checks, 584 lines checked
parent reply other threads:[~2017-02-25 1:24 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1487985795-136044-3-git-send-email-allain.legacy@windriver.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170225012430.5F8708DA2@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=allain.legacy@windriver.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).