automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Allain Legacy <allain.legacy@windriver.com>
Subject: [dpdk-test-report] |WARNING| pw20745 [PATCH 11/16] net/avp: packet receive functions
Date: Sat, 25 Feb 2017 02:24:58 +0100 (CET)	[thread overview]
Message-ID: <20170225012458.21E09F95E@dpdk.org> (raw)
In-Reply-To: <1487985795-136044-12-git-send-email-allain.legacy@windriver.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/20745

_coding style issues_


CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'name' may be better as '(name)' to avoid precedence issues
#96: FILE: drivers/net/avp/avp_ethdev.c:208:
+#define RTE_AVP_STATS_INC(queue, name) \
+	((queue)->name++)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'name' may be better as '(name)' to avoid precedence issues
#98: FILE: drivers/net/avp/avp_ethdev.c:210:
+#define RTE_AVP_STATS_ADD(queue, name, value) \
+	((queue)->name += (value))

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#137: FILE: drivers/net/avp/avp_ethdev.c:1065:
+	unsigned max_rx_pkt_len = eth_dev->data->dev_conf.rxmode.max_rx_pkt_len;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#230: FILE: drivers/net/avp/avp_ethdev.c:1243:
+	unsigned pkt_len;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#231: FILE: drivers/net/avp/avp_ethdev.c:1244:
+	unsigned nb_segs;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#233: FILE: drivers/net/avp/avp_ethdev.c:1246:
+	unsigned i;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#287: FILE: drivers/net/avp/avp_ethdev.c:1300:
+			  unsigned count)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#291: FILE: drivers/net/avp/avp_ethdev.c:1304:
+	unsigned total_length = 0;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#292: FILE: drivers/net/avp/avp_ethdev.c:1305:
+	unsigned copy_length;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#293: FILE: drivers/net/avp/avp_ethdev.c:1306:
+	unsigned src_offset;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#298: FILE: drivers/net/avp/avp_ethdev.c:1311:
+	unsigned i;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#386: FILE: drivers/net/avp/avp_ethdev.c:1399:
+	unsigned count, avail, n;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#387: FILE: drivers/net/avp/avp_ethdev.c:1400:
+	unsigned guest_mbuf_size;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#389: FILE: drivers/net/avp/avp_ethdev.c:1402:
+	unsigned required;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#390: FILE: drivers/net/avp/avp_ethdev.c:1403:
+	unsigned buf_len;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#391: FILE: drivers/net/avp/avp_ethdev.c:1404:
+	unsigned port_id;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#392: FILE: drivers/net/avp/avp_ethdev.c:1405:
+	unsigned i;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#417: FILE: drivers/net/avp/avp_ethdev.c:1430:
+	count = RTE_MIN(count, (unsigned)RTE_AVP_MAX_RX_BURST);

WARNING:TYPO_SPELLING: 'Receving' may be misspelled - perhaps 'Receiving'?
#426: FILE: drivers/net/avp/avp_ethdev.c:1439:
+	PMD_RX_LOG(DEBUG, "Receving %u packets from Rx queue at %p
",

CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#431: FILE: drivers/net/avp/avp_ethdev.c:1444:
+	for (i = 0; i < n; i++) {
+

CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#433: FILE: drivers/net/avp/avp_ethdev.c:1446:
+		if (i+1 < n) {
 		     ^

CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#434: FILE: drivers/net/avp/avp_ethdev.c:1447:
+			pkt_buf = avp_dev_translate_buffer(avp, avp_bufs[i+1]);
 			                                                  ^

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#487: FILE: drivers/net/avp/avp_ethdev.c:1500:
+	unsigned count, avail, n;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#489: FILE: drivers/net/avp/avp_ethdev.c:1502:
+	unsigned pkt_len;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#491: FILE: drivers/net/avp/avp_ethdev.c:1504:
+	unsigned i;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#514: FILE: drivers/net/avp/avp_ethdev.c:1527:
+	count = RTE_MIN(count, (unsigned)RTE_AVP_MAX_RX_BURST);

WARNING:TYPO_SPELLING: 'Receving' may be misspelled - perhaps 'Receiving'?
#523: FILE: drivers/net/avp/avp_ethdev.c:1536:
+	PMD_RX_LOG(DEBUG, "Receving %u packets from Rx queue at %p
",

CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#528: FILE: drivers/net/avp/avp_ethdev.c:1541:
+	for (i = 0; i < n; i++) {
+

CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#530: FILE: drivers/net/avp/avp_ethdev.c:1543:
+		if (i < n-1) {
 		         ^

CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#531: FILE: drivers/net/avp/avp_ethdev.c:1544:
+			pkt_buf = avp_dev_translate_buffer(avp, avp_bufs[i+1]);
 			                                                  ^

total: 0 errors, 22 warnings, 8 checks, 522 lines checked

           reply	other threads:[~2017-02-25  1:24 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1487985795-136044-12-git-send-email-allain.legacy@windriver.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170225012458.21E09F95E@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=allain.legacy@windriver.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).