From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id 555E26CB4; Sat, 25 Feb 2017 23:00:05 +0100 (CET) In-Reply-To: <1488059989-6930-5-git-send-email-skhare@vmware.com> References: <1488059989-6930-5-git-send-email-skhare@vmware.com> To: test-report@dpdk.org Cc: Shrikrishna Khare Message-Id: <20170225220005.555E26CB4@dpdk.org> Date: Sat, 25 Feb 2017 23:00:05 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw20787 [PATCH 4/7] vmxnet3: add receive data ring support X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Feb 2017 22:00:05 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/20787 _coding style issues_ WARNING:LEADING_SPACE: please, no spaces at the start of a line #97: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:538: + __le64 rxDataRingBasePA;$ CHECK:CAMELCASE: Avoid CamelCase: #97: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:538: + __le64 rxDataRingBasePA; WARNING:LEADING_SPACE: please, no spaces at the start of a line #103: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:543: + uint8 _pad1[1];$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #104: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:544: + __le16 rxDataRingDescSize; /* size of rx data ring buffer */$ CHECK:CAMELCASE: Avoid CamelCase: #104: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:544: + __le16 rxDataRingDescSize; /* size of rx data ring buffer */ WARNING:LEADING_SPACE: please, no spaces at the start of a line #105: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:545: + uint8 _pad2[4];$ CHECK:CAMELCASE: Avoid CamelCase: #130: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:560: + rqd->conf.rxDataRingBasePA = rxq->data_ring.basePA; CHECK:CAMELCASE: Avoid CamelCase: #166: FILE: drivers/net/vmxnet3/vmxnet3_ring.h:72: +#define VMXNET3_GET_RING_IDX(hw, rqID) \ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hw' - possible side-effects? #166: FILE: drivers/net/vmxnet3/vmxnet3_ring.h:72: +#define VMXNET3_GET_RING_IDX(hw, rqID) \ + ((rqID >= hw->num_rx_queues && \ + rqID < 2 * hw->num_rx_queues) ? 1 : 0) \ + CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'hw' may be better as '(hw)' to avoid precedence issues #166: FILE: drivers/net/vmxnet3/vmxnet3_ring.h:72: +#define VMXNET3_GET_RING_IDX(hw, rqID) \ + ((rqID >= hw->num_rx_queues && \ + rqID < 2 * hw->num_rx_queues) ? 1 : 0) \ + CHECK:MACRO_ARG_REUSE: Macro argument reuse 'rqID' - possible side-effects? #166: FILE: drivers/net/vmxnet3/vmxnet3_ring.h:72: +#define VMXNET3_GET_RING_IDX(hw, rqID) \ + ((rqID >= hw->num_rx_queues && \ + rqID < 2 * hw->num_rx_queues) ? 1 : 0) \ + CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'rqID' may be better as '(rqID)' to avoid precedence issues #166: FILE: drivers/net/vmxnet3/vmxnet3_ring.h:72: +#define VMXNET3_GET_RING_IDX(hw, rqID) \ + ((rqID >= hw->num_rx_queues && \ + rqID < 2 * hw->num_rx_queues) ? 1 : 0) \ + CHECK:MACRO_ARG_REUSE: Macro argument reuse 'hw' - possible side-effects? #170: FILE: drivers/net/vmxnet3/vmxnet3_ring.h:76: +#define VMXNET3_RX_DATA_RING(hw, rqID) \ + (rqID >= 2 * hw->num_rx_queues && \ + rqID < 3 * hw->num_rx_queues) \ + CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'hw' may be better as '(hw)' to avoid precedence issues #170: FILE: drivers/net/vmxnet3/vmxnet3_ring.h:76: +#define VMXNET3_RX_DATA_RING(hw, rqID) \ + (rqID >= 2 * hw->num_rx_queues && \ + rqID < 3 * hw->num_rx_queues) \ + CHECK:MACRO_ARG_REUSE: Macro argument reuse 'rqID' - possible side-effects? #170: FILE: drivers/net/vmxnet3/vmxnet3_ring.h:76: +#define VMXNET3_RX_DATA_RING(hw, rqID) \ + (rqID >= 2 * hw->num_rx_queues && \ + rqID < 3 * hw->num_rx_queues) \ + CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'rqID' may be better as '(rqID)' to avoid precedence issues #170: FILE: drivers/net/vmxnet3/vmxnet3_ring.h:76: +#define VMXNET3_RX_DATA_RING(hw, rqID) \ + (rqID >= 2 * hw->num_rx_queues && \ + rqID < 3 * hw->num_rx_queues) \ + WARNING:LONG_LINE_COMMENT: line over 90 characters #196: FILE: drivers/net/vmxnet3/vmxnet3_ring.h:180: + uint32_t data_ring_qid; /* rqID in RCD for buffer from data ring */ WARNING:BRACES: braces {} are not necessary for single statement blocks #219: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:285: + if (VMXNET3_VERSION_GE_3(hw) && rq->data_desc_size) { + size += rq->data_desc_size * data_ring->size; + } WARNING:BRACES: braces {} are not necessary for single statement blocks #285: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1090: + if (VMXNET3_VERSION_GE_3(hw) && rxq->data_desc_size) { + size += rxq->data_desc_size * data_ring->size; + } CHECK:CAMELCASE: Avoid CamelCase: #299: FILE: drivers/net/vmxnet3/vmxnet3_rxtx.c:1118: + sizeof(struct Vmxnet3_RxCompDesc) * comp_ring->size; total: 0 errors, 7 warnings, 13 checks, 199 lines checked