From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Shrikrishna Khare <skhare@vmware.com>
Subject: [dpdk-test-report] |WARNING| pw20788 [PATCH 6/7] vmxnet3: introduce command to register memory region
Date: Sat, 25 Feb 2017 23:00:39 +0100 (CET) [thread overview]
Message-ID: <20170225220039.B2857BD2A@dpdk.org> (raw)
In-Reply-To: <1488059989-6930-7-git-send-email-skhare@vmware.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/20788
_coding style issues_
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#72: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:114:
+ VMXNET3_CMD_REGISTER_MEMREGS,$
CHECK:CAMELCASE: Avoid CamelCase: <Vmxnet3_MemoryRegion>
#82: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:728:
+struct Vmxnet3_MemoryRegion {
CHECK:CAMELCASE: Avoid CamelCase: <startPA>
#83: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:729:
+ __le64 startPA;
CHECK:CAMELCASE: Avoid CamelCase: <txQueueBits>
#85: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:731:
+ __le16 txQueueBits; /* bit n corresponding to tx queue n */
CHECK:CAMELCASE: Avoid CamelCase: <rxQueueBits>
#86: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:732:
+ __le16 rxQueueBits; /* bit n corresponding to rx queue n */
CHECK:CAMELCASE: Avoid CamelCase: <Vmxnet3_MemRegs>
#96: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:742:
+struct Vmxnet3_MemRegs {
CHECK:CAMELCASE: Avoid CamelCase: <numRegs>
#97: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:743:
+ __le16 numRegs;
CHECK:CAMELCASE: Avoid CamelCase: <memRegs>
#99: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:745:
+ Vmxnet3_MemoryRegion memRegs[1];
CHECK:CAMELCASE: Avoid CamelCase: <Vmxnet3_DriverShared>
#118: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:495:
+ Vmxnet3_DriverShared *shared = hw->shared;
CHECK:CAMELCASE: Avoid CamelCase: <Vmxnet3_CmdInfo>
#119: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:496:
+ Vmxnet3_CmdInfo *cmdInfo;
CHECK:CAMELCASE: Avoid CamelCase: <cmdInfo>
#119: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:496:
+ Vmxnet3_CmdInfo *cmdInfo;
CHECK:CAMELCASE: Avoid CamelCase: <memRegsPA>
#124: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:501:
+ if (hw->memRegsPA == 0) {
WARNING:BRACES: braces {} are not necessary for single statement blocks
#168: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:545:
+ if (mp[i] == NULL) {
+ continue;
+ }
CHECK:CAMELCASE: Avoid CamelCase: <varConf>
#193: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:570:
+ cmdInfo->varConf.confVer = 1;
CHECK:CAMELCASE: Avoid CamelCase: <confVer>
#193: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:570:
+ cmdInfo->varConf.confVer = 1;
CHECK:CAMELCASE: Avoid CamelCase: <confLen>
#194: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:571:
+ cmdInfo->varConf.confLen = size;
CHECK:CAMELCASE: Avoid CamelCase: <confPA>
#195: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:572:
+ cmdInfo->varConf.confPA = hw->memRegsPA;
WARNING:BRACES: braces {} are not necessary for single statement blocks
#214: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:723:
+ if (ret != 0) {
+ PMD_INIT_LOG(DEBUG, "Failed in setup memory region cmd
");
+ }
total: 0 errors, 3 warnings, 15 checks, 165 lines checked
parent reply other threads:[~2017-02-25 22:00 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1488059989-6930-7-git-send-email-skhare@vmware.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170225220039.B2857BD2A@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=skhare@vmware.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).