From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id B2857BD2A; Sat, 25 Feb 2017 23:00:39 +0100 (CET)
In-Reply-To: <1488059989-6930-7-git-send-email-skhare@vmware.com>
References: <1488059989-6930-7-git-send-email-skhare@vmware.com>
To: test-report@dpdk.org
Cc: Shrikrishna Khare <skhare@vmware.com>
Message-Id: <20170225220039.B2857BD2A@dpdk.org>
Date: Sat, 25 Feb 2017 23:00:39 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw20788 [PATCH 6/7] vmxnet3: introduce
	command to register memory region
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 25 Feb 2017 22:00:39 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/20788

_coding style issues_


WARNING:LEADING_SPACE: please, no spaces at the start of a line
#72: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:114:
+   VMXNET3_CMD_REGISTER_MEMREGS,$

CHECK:CAMELCASE: Avoid CamelCase: <Vmxnet3_MemoryRegion>
#82: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:728:
+struct Vmxnet3_MemoryRegion {

CHECK:CAMELCASE: Avoid CamelCase: <startPA>
#83: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:729:
+	__le64            startPA;

CHECK:CAMELCASE: Avoid CamelCase: <txQueueBits>
#85: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:731:
+	__le16            txQueueBits; /* bit n corresponding to tx queue n */

CHECK:CAMELCASE: Avoid CamelCase: <rxQueueBits>
#86: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:732:
+	__le16            rxQueueBits; /* bit n corresponding to rx queue n */

CHECK:CAMELCASE: Avoid CamelCase: <Vmxnet3_MemRegs>
#96: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:742:
+struct Vmxnet3_MemRegs {

CHECK:CAMELCASE: Avoid CamelCase: <numRegs>
#97: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:743:
+	__le16           numRegs;

CHECK:CAMELCASE: Avoid CamelCase: <memRegs>
#99: FILE: drivers/net/vmxnet3/base/vmxnet3_defs.h:745:
+	Vmxnet3_MemoryRegion memRegs[1];

CHECK:CAMELCASE: Avoid CamelCase: <Vmxnet3_DriverShared>
#118: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:495:
+	Vmxnet3_DriverShared *shared = hw->shared;

CHECK:CAMELCASE: Avoid CamelCase: <Vmxnet3_CmdInfo>
#119: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:496:
+	Vmxnet3_CmdInfo *cmdInfo;

CHECK:CAMELCASE: Avoid CamelCase: <cmdInfo>
#119: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:496:
+	Vmxnet3_CmdInfo *cmdInfo;

CHECK:CAMELCASE: Avoid CamelCase: <memRegsPA>
#124: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:501:
+	if (hw->memRegsPA == 0) {

WARNING:BRACES: braces {} are not necessary for single statement blocks
#168: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:545:
+		if (mp[i] == NULL) {
+			continue;
+		}

CHECK:CAMELCASE: Avoid CamelCase: <varConf>
#193: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:570:
+	cmdInfo->varConf.confVer = 1;

CHECK:CAMELCASE: Avoid CamelCase: <confVer>
#193: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:570:
+	cmdInfo->varConf.confVer = 1;

CHECK:CAMELCASE: Avoid CamelCase: <confLen>
#194: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:571:
+	cmdInfo->varConf.confLen = size;

CHECK:CAMELCASE: Avoid CamelCase: <confPA>
#195: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:572:
+	cmdInfo->varConf.confPA = hw->memRegsPA;

WARNING:BRACES: braces {} are not necessary for single statement blocks
#214: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:723:
+		if (ret != 0) {
+			PMD_INIT_LOG(DEBUG, "Failed in setup memory region cmd
");
+		}

total: 0 errors, 3 warnings, 15 checks, 165 lines checked