From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 84D8FF966; Thu,  2 Mar 2017 08:10:21 +0100 (CET)
In-Reply-To: <1488438439-14776-5-git-send-email-arybchenko@solarflare.com>
References: <1488438439-14776-5-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20170302071021.84D8FF966@dpdk.org>
Date: Thu,  2 Mar 2017 08:10:21 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw21055 [PATCH 04/13] net/sfc: factor
	out libefx-based Rx datapath
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Mar 2017 07:10:21 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/21055

_coding style issues_


WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EEXIST)
#226: FILE: drivers/net/sfc/sfc_dp.c:81:
+		return EEXIST;

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#278: FILE: drivers/net/sfc/sfc_dp.h:40:
+#define SFC_DIV_ROUND_UP(a, b) \
+	__extension__ ({		\
+		typeof(a) _a = (a);	\
+		typeof(b) _b = (b);	\
+					\
+		(_a + (_b - 1)) / _b;	\
+	})

WARNING:TYPO_SPELLING: 'initalize' may be misspelled - perhaps 'initialize'?
#432: FILE: drivers/net/sfc/sfc_dp_rx.h:102:
+ * Allocate and initalize datapath receive queue.

CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#1182: FILE: drivers/net/sfc/sfc_rx.c:428:
+	rxq->pending = rxq->completed = rxq->added = rxq->pushed = 0;

total: 1 errors, 2 warnings, 1 checks, 1371 lines checked