automatic DPDK test reports
 help / color / mirror / Atom feed
* [dpdk-test-report] |WARNING| pw21295 [PATCH 1/2] net/sfc/base: add MCDI agnostic wrapper for MAC stats clear
       [not found] <1488545365-12827-1-git-send-email-arybchenko@solarflare.com>
@ 2017-03-03 12:49 ` checkpatch
  0 siblings, 0 replies; only message in thread
From: checkpatch @ 2017-03-03 12:49 UTC (permalink / raw)
  To: test-report; +Cc: Andrew Rybchenko

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/21295

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#88: FILE: drivers/net/sfc/base/efx.h:562:
+extern	__checkReturn			efx_rc_t

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#134: FILE: drivers/net/sfc/base/efx_mac.c:722:
+	efx_port_t *epp = &(enp->en_port);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#142: FILE: drivers/net/sfc/base/efx_mac.c:730:
+	if ((rc = emop->emo_stats_clear(enp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#145: FILE: drivers/net/sfc/base/efx_mac.c:733:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#150: FILE: drivers/net/sfc/base/efx_mac.c:738:
+	return (rc);

total: 3 errors, 0 warnings, 2 checks, 60 lines checked

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-03-03 12:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1488545365-12827-1-git-send-email-arybchenko@solarflare.com>
2017-03-03 12:49 ` [dpdk-test-report] |WARNING| pw21295 [PATCH 1/2] net/sfc/base: add MCDI agnostic wrapper for MAC stats clear checkpatch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).