From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 131E7FA62; Fri,  3 Mar 2017 16:41:18 +0100 (CET)
In-Reply-To: <e2a3bdc58f89ecea4cc0de569588c3dfba45aeae.1488550982.git.gaetan.rivet@6wind.com>
References: <e2a3bdc58f89ecea4cc0de569588c3dfba45aeae.1488550982.git.gaetan.rivet@6wind.com>
To: test-report@dpdk.org
Cc: Gaetan Rivet <gaetan.rivet@6wind.com>
Message-Id: <20170303154118.131E7FA62@dpdk.org>
Date: Fri,  3 Mar 2017 16:41:18 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw21349 [PATCH 06/12] net/failsafe:
	add fail-safe PMD
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Mar 2017 15:41:18 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/21349

_coding style issues_


WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#307: FILE: drivers/net/failsafe/failsafe.c:84:
+		const unsigned socket_id,

CHECK:CAMELCASE: Avoid CamelCase: <eal_parse_pci_DomBDF>
#560: FILE: drivers/net/failsafe/failsafe_args.c:102:
+	    eal_parse_pci_DomBDF(args, &d->pci.addr) == 0)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#719: FILE: drivers/net/failsafe/failsafe_args.c:261:
+	unsigned arg_count;

WARNING:LONG_LINE_STRING: line over 90 characters
#1306: FILE: drivers/net/failsafe/failsafe_ops.c:171:
+			ERROR("Operation rte_eth_dev_set_link_down failed for sub_device %d"

WARNING:LONG_LINE_STRING: line over 90 characters
#1733: FILE: drivers/net/failsafe/failsafe_ops.c:598:
+			ERROR("Operation rte_eth_dev_flow_ctrl_set failed for sub_device %d"

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'i' - possible side-effects?
#1980: FILE: drivers/net/failsafe/failsafe_private.h:162:
+#define FOREACH_SUBDEV_ST(s, i, dev, state)				\
+	for (i = fs_find_next((dev), 0, state);				\
+	     i < PRIV(dev)->subs_tail && (s = &PRIV(dev)->subs[i]);	\
+	     i = fs_find_next((dev), i + 1, state))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev' - possible side-effects?
#1980: FILE: drivers/net/failsafe/failsafe_private.h:162:
+#define FOREACH_SUBDEV_ST(s, i, dev, state)				\
+	for (i = fs_find_next((dev), 0, state);				\
+	     i < PRIV(dev)->subs_tail && (s = &PRIV(dev)->subs[i]);	\
+	     i = fs_find_next((dev), i + 1, state))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'state' - possible side-effects?
#1980: FILE: drivers/net/failsafe/failsafe_private.h:162:
+#define FOREACH_SUBDEV_ST(s, i, dev, state)				\
+	for (i = fs_find_next((dev), 0, state);				\
+	     i < PRIV(dev)->subs_tail && (s = &PRIV(dev)->subs[i]);	\
+	     i = fs_find_next((dev), i + 1, state))

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev' - possible side-effects?
#1999: FILE: drivers/net/failsafe/failsafe_private.h:181:
+#define TX_SUBDEV(dev)							  \
+	(PRIV(dev)->subs_tx >= PRIV(dev)->subs_tail		   ? NULL \
+	 : (PRIV(dev)->subs[PRIV(dev)->subs_tx].state < DEV_PROBED ? NULL \
+	 : &PRIV(dev)->subs[PRIV(dev)->subs_tx]))

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'ops' may be better as '(ops)' to avoid precedence issues
#2008: FILE: drivers/net/failsafe/failsafe_private.h:190:
+#define SUBOPS(s, ops) \
+	(ETH(s)->dev_ops->ops)

total: 0 errors, 4 warnings, 2013 lines checked