From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id F11FDD59A; Sat,  4 Mar 2017 02:11:05 +0100 (CET)
In-Reply-To: <1488589820-206947-3-git-send-email-cristian.dumitrescu@intel.com>
References: <1488589820-206947-3-git-send-email-cristian.dumitrescu@intel.com>
To: test-report@dpdk.org
Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Message-Id: <20170304011105.F11FDD59A@dpdk.org>
Date: Sat,  4 Mar 2017 02:11:05 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw21404 [PATCH v3 2/2] ethdev: add
	hierarchical scheduler API
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 04 Mar 2017 01:11:06 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/21404

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#54: 
- Traffic shaping: single/dual rate, private (per node) and shared (by multiple

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#308: FILE: lib/librte_ether/rte_tm.c:61:
+			ENOSYS,

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#311: FILE: lib/librte_ether/rte_tm.c:64:
+			rte_strerror(ENOSYS));

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#318: FILE: lib/librte_ether/rte_tm.c:71:
+#define RTE_TM_FUNC(port_id, func)				\
+({								\
+	const struct rte_tm_ops *ops =			\
+		rte_tm_ops_get(port_id, error);		\
+	if (ops == NULL)						\
+		return -rte_errno;				\
+								\
+	if (ops->func == NULL)					\
+		return -rte_tm_error_set(error,		\
+			ENOSYS,					\
+			RTE_TM_ERROR_TYPE_UNSPECIFIED,	\
+			NULL,					\
+			rte_strerror(ENOSYS));			\
+								\
+	ops->func;						\
+})

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#327: FILE: lib/librte_ether/rte_tm.c:80:
+			ENOSYS,					\

WARNING:ENOSYS: ENOSYS means 'invalid syscall nr' and nothing else
#330: FILE: lib/librte_ether/rte_tm.c:83:
+			rte_strerror(ENOSYS));			\

total: 0 errors, 6 warnings, 2334 lines checked