From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Ravi Kerur <rkerur@gmail.com>
Subject: [dpdk-test-report] |WARNING| pw21407 [v2 2/3] LPM config file read option
Date: Sat, 4 Mar 2017 20:51:30 +0100 (CET) [thread overview]
Message-ID: <20170304195130.306D66CB4@dpdk.org> (raw)
In-Reply-To: <1488657036-12934-3-git-send-email-rkerur@gmail.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/21407
_coding style issues_
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#110: FILE: examples/l3fwd/l3fwd.h:104:
+#define GET_CB_FIELD(in, fd, base, lim, dlm) do { \
+ unsigned long val; \
+ char *end; \
+ errno = 0; \
+ val = strtoul((in), &end, (base)); \
+ if (errno != 0 || end[0] != (dlm) || val > (lim)) \
+ return -EINVAL; \
+ (fd) = (typeof(fd))val; \
+ (in) = end + 1; \
+} while (0)
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#496: FILE: examples/l3fwd/l3fwd_lpm.c:234:
+ if (0 == route_num)
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#504: FILE: examples/l3fwd/l3fwd_lpm.c:242:
+ if (NULL == route_rules)
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#619: FILE: examples/l3fwd/l3fwd_lpm.c:431:
+ (unsigned)route_base_v4[i].ip,
total: 0 errors, 4 warnings, 594 lines checked
parent reply other threads:[~2017-03-04 19:51 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1488657036-12934-3-git-send-email-rkerur@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170304195130.306D66CB4@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=rkerur@gmail.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).