[dpdk-test-report] |WARNING| pw21409 [v2 1/3] Merge l3fwd-acl and l3fwd

[checkpatch@dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/21409

_coding style issues_


WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 24)
#2893: FILE: examples/l3fwd/l3fwd_acl.c:513:
+	if (rc != 0) {
+			acl_log("failed to read source address/mask: %s
",

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#2975: FILE: examples/l3fwd/l3fwd_acl.c:595:
+	if (0 == route_num)

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#2983: FILE: examples/l3fwd/l3fwd_acl.c:603:
+	if (NULL == acl_rules)

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#2989: FILE: examples/l3fwd/l3fwd_acl.c:609:
+	if (NULL == route_rules)

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 24)
#3107: FILE: examples/l3fwd/l3fwd_acl.c:727:
+	if (rte_acl_add_rules(context, route_base, route_num) < 0)
+			rte_exit(EXIT_FAILURE, "add rules failed
");

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 24)
#3110: FILE: examples/l3fwd/l3fwd_acl.c:730:
+	if (rte_acl_add_rules(context, acl_base, acl_num) < 0)
+			rte_exit(EXIT_FAILURE, "add rules failed
");

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#3132: FILE: examples/l3fwd/l3fwd_acl.c:752:
+	unsigned lcore_id;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#3227: FILE: examples/l3fwd/l3fwd_acl.c:847:
+	unsigned lcore_id;

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#3370: FILE: examples/l3fwd/l3fwd_acl.c:990:
+	unsigned i;

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#3508: FILE: examples/l3fwd/l3fwd_acl.h:58:
+#define GET_CB_FIELD(in, fd, base, lim, dlm)	do {            \
+	unsigned long val;                                      \
+	char *end;                                              \
+	errno = 0;                                              \
+	val = strtoul((in), &end, (base));                      \
+	if (errno != 0 || end[0] != (dlm) || val > (lim))       \
+		return -EINVAL;                               \
+	(fd) = (typeof(fd))val;                                 \
+	(in) = end + 1;                                         \
+} while (0)

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#3520: FILE: examples/l3fwd/l3fwd_acl.h:70:
+/*
+  * ACL rules should have higher priorities than route ones to ensure ACL rule

WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#3530: FILE: examples/l3fwd/l3fwd_acl.h:80:
+/*
+  * Forward port info save in ACL lib starts from 1

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#3662: FILE: examples/l3fwd/l3fwd_acl.h:212:
+	unsigned i;

WARNING:LONG_LINE: line over 90 characters
#3972: FILE: examples/l3fwd/l3fwd_lpm.c:230:
+				"Unable to add entry %u to v4 LPM table on socket %d
", i, socketid);

WARNING:LONG_LINE: line over 90 characters
#3997: FILE: examples/l3fwd/l3fwd_lpm.c:267:
+				"Unable to add entry %u to the l3fwd LPM table on socket %d
", i, socketid);

WARNING:LONG_LINE_STRING: line over 90 characters
#4118: FILE: examples/l3fwd/main.c:351:
+		"  --"OPTION_ETH_DEST"=X,MM:MM:MM:MM:MM:MM: Ethernet destination for port X
"

WARNING:LONG_LINE_STRING: line over 90 characters
#4128: FILE: examples/l3fwd/main.c:356:
+		"  --"OPTION_HASH_ENTRY_NUM": Specify the hash entry number in hexadecimal to be setup
"

WARNING:LONG_LINE: line over 90 characters
#4410: FILE: examples/l3fwd/main.c:1010:
+					rte_exit(EXIT_FAILURE, "Can't allocate tx buffer for port %u
", (unsigned) portid);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#4410: FILE: examples/l3fwd/main.c:1010:
+					rte_exit(EXIT_FAILURE, "Can't allocate tx buffer for port %u
", (unsigned) portid);

total: 0 errors, 19 warnings, 2089 lines checked