From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 82E0CF614; Sun,  5 Mar 2017 20:48:14 +0100 (CET)
In-Reply-To: <1488743225-25750-2-git-send-email-rkerur@gmail.com>
References: <1488743225-25750-2-git-send-email-rkerur@gmail.com>
To: test-report@dpdk.org
Cc: Ravi Kerur <rkerur@gmail.com>
Message-Id: <20170305194814.82E0CF614@dpdk.org>
Date: Sun,  5 Mar 2017 20:48:14 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw21419 [v4 1/3] Merge l3fwd-acl and
	l3fwd code.
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 05 Mar 2017 19:48:14 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/21419

_coding style issues_


WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#3516: FILE: examples/l3fwd/l3fwd_acl.h:58:
+#define GET_CB_FIELD(in, fd, base, lim, dlm)	do {            \
+	unsigned long val;                                      \
+	char *end;                                              \
+	errno = 0;                                              \
+	val = strtoul((in), &end, (base));                      \
+	if (errno != 0 || end[0] != (dlm) || val > (lim))       \
+		return -EINVAL;                               \
+	(fd) = (typeof(fd))val;                                 \
+	(in) = end + 1;                                         \
+} while (0)

WARNING:LONG_LINE: line over 90 characters
#3980: FILE: examples/l3fwd/l3fwd_lpm.c:230:
+				"Unable to add entry %u to v4 LPM table on socket %d
", i, socketid);

WARNING:LONG_LINE: line over 90 characters
#4005: FILE: examples/l3fwd/l3fwd_lpm.c:267:
+				"Unable to add entry %u to the l3fwd LPM table on socket %d
", i, socketid);

WARNING:LONG_LINE_STRING: line over 90 characters
#4115: FILE: examples/l3fwd/main.c:349:
+		"  --"OPTION_ETH_DEST"=X,MM:MM:MM:MM:MM:MM: Ethernet destination for port X
"

WARNING:LONG_LINE_STRING: line over 90 characters
#4125: FILE: examples/l3fwd/main.c:354:
+		"  --"OPTION_HASH_ENTRY_NUM": Specify the hash entry number in hexadecimal to be setup
"

WARNING:LONG_LINE: line over 90 characters
#4419: FILE: examples/l3fwd/main.c:1013:
+					rte_exit(EXIT_FAILURE, "Can't allocate tx buffer for port %u
", (unsigned int) portid);

total: 0 errors, 6 warnings, 2090 lines checked