From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id D9C78D07E; Tue, 14 Mar 2017 10:17:23 +0100 (CET)
In-Reply-To: <1489080183-21467-2-git-send-email-arybchenko@solarflare.com>
References: <1489080183-21467-2-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20170314091723.D9C78D07E@dpdk.org>
Date: Tue, 14 Mar 2017 10:17:23 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw21657 [PATCH v2 1/6] net/sfc/base:
	don't ignore requested MAC stats update period
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Mar 2017 09:17:24 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/21657

_coding style issues_


ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#50: FILE: drivers/net/sfc/base/efx_mcdi.c:1801:
+	if ((rc = efx_mcdi_mac_stats(enp, NULL, EFX_STATS_CLEAR, 0)) != 0)

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#59: FILE: drivers/net/sfc/base/efx_mcdi.c:1824:
+	if ((rc = efx_mcdi_mac_stats(enp, esmp, EFX_STATS_UPLOAD, 0)) != 0)

total: 2 errors, 0 warnings, 0 checks, 71 lines checked