automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Kevin Traynor <ktraynor@redhat.com>
Subject: [dpdk-test-report] |WARNING| pw21818 [PATCH] vhost: fix virtio_net cache sharing of broadcast_rarp
Date: Sun, 19 Mar 2017 11:02:25 +0100 (CET)	[thread overview]
Message-ID: <20170319100225.D586869C6@dpdk.org> (raw)
In-Reply-To: <fb0af1bf-9518-f8f2-d288-f8f2e77a53c8@redhat.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/21818

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#25: 
>> In OVS the issue can cause a uni-directional performance drop of up to 15%.

WARNING:TYPO_SPELLING: 'recieved' may be misspelled - perhaps 'received'?
#42: 
> packet once SEND_RARP request is recieved. Otherwise, we may send more

ERROR:DIFF_IN_COMMIT_MSG: Avoid using diff content in the commit message - patch(1) might not work
#76: 
--- a/lib/librte_vhost/virtio_net.c

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#83: FILE: lib/librte_vhost/virtio_net.c:1060:
+       if (unlikely(rte_atomic16_read(&dev->broadcast_rarp) &&$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#83: FILE: lib/librte_vhost/virtio_net.c:1060:
+       if (unlikely(rte_atomic16_read(&dev->broadcast_rarp) &&
[...]
                rarp_mbuf = rte_pktmbuf_alloc(mbuf_pool);

ERROR:CODE_INDENT: code indent should use tabs where possible
#84: FILE: lib/librte_vhost/virtio_net.c:1061:
+                       rte_atomic16_cmpset((volatile uint16_t *)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#84: FILE: lib/librte_vhost/virtio_net.c:1061:
+                       rte_atomic16_cmpset((volatile uint16_t *)$

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 3 errors, 5 warnings, 9 lines checked

           reply	other threads:[~2017-03-19 10:02 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <fb0af1bf-9518-f8f2-d288-f8f2e77a53c8@redhat.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170319100225.D586869C6@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=ktraynor@redhat.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).