From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| pw21826 [PATCH 1/2] net/sfc/base: add advanced function to extract FW version
Date: Sun, 19 Mar 2017 11:02:32 +0100 (CET) [thread overview]
Message-ID: <20170319100232.424B0CF80@dpdk.org> (raw)
In-Reply-To: <1489662095-23157-1-git-send-email-arybchenko@solarflare.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/21826
_coding style issues_
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#104: FILE: drivers/net/sfc/base/ef10_nic.c:962:
+ if ((rc = efx_mcdi_get_capabilities(enp, &flags, NULL, NULL,
CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#130: FILE: drivers/net/sfc/base/efx.h:1227:
+extern __checkReturn efx_rc_t
CHECK:SPACING: No space is necessary after a cast
#161: FILE: drivers/net/sfc/base/efx_mcdi.c:1042:
+ (void) memset(payload, 0, sizeof (payload));
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#161: FILE: drivers/net/sfc/base/efx_mcdi.c:1042:
+ (void) memset(payload, 0, sizeof (payload));
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#209: FILE: drivers/net/sfc/base/efx_mcdi.c:1090:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#216: FILE: drivers/net/sfc/base/efx_mcdi.c:1097:
+ return (rc);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#286: FILE: drivers/net/sfc/base/efx_nic.c:655:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#295: FILE: drivers/net/sfc/base/efx_nic.c:664:
+ return (rc);
total: 5 errors, 1 warnings, 2 checks, 241 lines checked
parent reply other threads:[~2017-03-19 10:02 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1489662095-23157-1-git-send-email-arybchenko@solarflare.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170319100232.424B0CF80@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=arybchenko@solarflare.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).