From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 424B0CF80; Sun, 19 Mar 2017 11:02:32 +0100 (CET)
In-Reply-To: <1489662095-23157-1-git-send-email-arybchenko@solarflare.com>
References: <1489662095-23157-1-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20170319100232.424B0CF80@dpdk.org>
Date: Sun, 19 Mar 2017 11:02:32 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw21826 [PATCH 1/2] net/sfc/base: add
	advanced function to extract FW version
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 19 Mar 2017 10:02:32 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/21826

_coding style issues_


ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#104: FILE: drivers/net/sfc/base/ef10_nic.c:962:
+	if ((rc = efx_mcdi_get_capabilities(enp, &flags, NULL, NULL,

CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#130: FILE: drivers/net/sfc/base/efx.h:1227:
+extern	__checkReturn		efx_rc_t

CHECK:SPACING: No space is necessary after a cast
#161: FILE: drivers/net/sfc/base/efx_mcdi.c:1042:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#161: FILE: drivers/net/sfc/base/efx_mcdi.c:1042:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#209: FILE: drivers/net/sfc/base/efx_mcdi.c:1090:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#216: FILE: drivers/net/sfc/base/efx_mcdi.c:1097:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#286: FILE: drivers/net/sfc/base/efx_nic.c:655:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#295: FILE: drivers/net/sfc/base/efx_nic.c:664:
+	return (rc);

total: 5 errors, 1 warnings, 2 checks, 241 lines checked