From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Ed Czeck <ed.czeck@atomicrules.com>
Subject: [dpdk-test-report] |WARNING| pw21895 [PATCH] net/ark: poll-mode driver for AtomicRules Arkville
Date: Sun, 19 Mar 2017 11:03:48 +0100 (CET) [thread overview]
Message-ID: <20170319100348.55AC75689@dpdk.org> (raw)
In-Reply-To: <1489785317-15185-1-git-send-email-ed.czeck@atomicrules.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/21895
_coding style issues_
CHECK:CAMELCASE: Avoid CamelCase: <stopFlushed>
#591: FILE: drivers/net/ark/ark_ddm.c:69:
+ while (wait && (ddm->cfg.stopFlushed & 0x01) == 0) {
CHECK:CAMELCASE: Avoid CamelCase: <consAddr>
#618: FILE: drivers/net/ark/ark_ddm.c:96:
+ark_ddm_setup(struct ark_ddm_t *ddm, phys_addr_t consAddr, uint32_t interval)
CHECK:CAMELCASE: Avoid CamelCase: <consWriteIndexAddr>
#620: FILE: drivers/net/ark/ark_ddm.c:98:
+ ddm->setup.consWriteIndexAddr = consAddr;
CHECK:CAMELCASE: Avoid CamelCase: <writeIndexInterval>
#621: FILE: drivers/net/ark/ark_ddm.c:99:
+ ddm->setup.writeIndexInterval = interval / 4; /* 4 ns period */
CHECK:CAMELCASE: Avoid CamelCase: <tlpStatsClear>
#627: FILE: drivers/net/ark/ark_ddm.c:105:
+ ddm->cfg.tlpStatsClear = 1;
CHECK:CAMELCASE: Avoid CamelCase: <txByteCount>
#646: FILE: drivers/net/ark/ark_ddm.c:124:
+ "Bytes:", stats->txByteCount,
CHECK:CAMELCASE: Avoid CamelCase: <txPktCount>
#647: FILE: drivers/net/ark/ark_ddm.c:125:
+ "Packets:", stats->txPktCount, "MBufs", stats->txMbufCount);
CHECK:CAMELCASE: Avoid CamelCase: <txMbufCount>
#647: FILE: drivers/net/ark/ark_ddm.c:125:
+ "Packets:", stats->txPktCount, "MBufs", stats->txMbufCount);
CHECK:CAMELCASE: Avoid CamelCase: <byteCount>
#659: FILE: drivers/net/ark/ark_ddm.c:137:
+ return ddm->queue_stats.byteCount;
CHECK:CAMELCASE: Avoid CamelCase: <pktCount>
#665: FILE: drivers/net/ark/ark_ddm.c:143:
+ return ddm->queue_stats.pktCount;
CHECK:CAMELCASE: Avoid CamelCase: <mbufCount>
#770: FILE: drivers/net/ark/ark_ddm.h:92:
+ volatile uint64_t mbufCount;
CHECK:CAMELCASE: Avoid CamelCase: <consIndex>
#787: FILE: drivers/net/ark/ark_ddm.h:109:
+ volatile uint32_t consIndex;
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#883: FILE: drivers/net/ark/ark_debug.h:45:
+ fprintf(stderr, fmt, ##__VA_ARGS__)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#886: FILE: drivers/net/ark/ark_debug.h:48:
+ do {if (0) fprintf(stderr, fmt, ##__VA_ARGS__); } while (0)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#904: FILE: drivers/net/ark/ark_debug.h:66:
+ fprintf(stderr, fmt, args)$
CHECK:CAMELCASE: Avoid CamelCase: <pktDirV>
#996: FILE: drivers/net/ark/ark_ethdev.c:80:
+static uint32_t pktDirV;
CHECK:CAMELCASE: Avoid CamelCase: <pktGenArgs>
#997: FILE: drivers/net/ark/ark_ethdev.c:81:
+static char pktGenArgs[ARK_MAX_ARG_LEN];
CHECK:CAMELCASE: Avoid CamelCase: <pktChkrArgs>
#998: FILE: drivers/net/ark/ark_ethdev.c:82:
+static char pktChkrArgs[ARK_MAX_ARG_LEN];
WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#1004: FILE: drivers/net/ark/ark_ethdev.c:88:
+static const char *valid_arguments[] = {
WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#1089: FILE: drivers/net/ark/ark_ethdev.c:173:
+ ARK_DEBUG_TRACE("ARK EXT NO dll path specified
");
CHECK:CAMELCASE: Avoid CamelCase: <dHandle>
#1095: FILE: drivers/net/ark/ark_ethdev.c:179:
+ ark->dHandle = dlopen(dllpath, RTLD_LOCAL | RTLD_LAZY);
WARNING:BRACES: braces {} are not necessary for any arm of this statement
#1096: FILE: drivers/net/ark/ark_ethdev.c:180:
+ if (ark->dHandle == NULL) {
[...]
+ } else {
[...]
WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#1097: FILE: drivers/net/ark/ark_ethdev.c:181:
+ PMD_DRV_LOG(ERR, "Could not load user extension %s
", dllpath);
CHECK:SPACING: No space is necessary after a cast
#1156: FILE: drivers/net/ark/ark_ethdev.c:240:
+ struct ark_adapter *ark = (struct ark_adapter *) dev->data->dev_private;
CHECK:SPACING: No space is necessary after a cast
#1179: FILE: drivers/net/ark/ark_ethdev.c:263:
+ ark->bar0 = (uint8_t *) pci_dev->mem_resource[0].addr;
CHECK:SPACING: No space is necessary after a cast
#1180: FILE: drivers/net/ark/ark_ethdev.c:264:
+ ark->Abar = (uint8_t *) pci_dev->mem_resource[2].addr;
CHECK:CAMELCASE: Avoid CamelCase: <Abar>
#1180: FILE: drivers/net/ark/ark_ethdev.c:264:
+ ark->Abar = (uint8_t *) pci_dev->mem_resource[2].addr;
CHECK:CAMELCASE: Avoid CamelCase: <SetPtr>
#1182: FILE: drivers/net/ark/ark_ethdev.c:266:
+ SetPtr(bar0, ark, sysctrl, ARK_SYSCTRL_BASE);
CHECK:CAMELCASE: Avoid CamelCase: <ARK_MPURx_BASE>
#1183: FILE: drivers/net/ark/ark_ethdev.c:267:
+ SetPtr(bar0, ark, mpurx, ARK_MPURx_BASE);
CHECK:CAMELCASE: Avoid CamelCase: <ARK_MPUTx_BASE>
#1185: FILE: drivers/net/ark/ark_ethdev.c:269:
+ SetPtr(bar0, ark, mputx, ARK_MPUTx_BASE);
CHECK:SPACING: No space is necessary after a cast
#1193: FILE: drivers/net/ark/ark_ethdev.c:277:
+ ark->rqpacing = (struct ark_rqpace_t *) (ark->bar0 + ARK_RCPACING_BASE);
WARNING:BRACES: braces {} are not necessary for single statement blocks
#1221: FILE: drivers/net/ark/ark_ethdev.c:305:
+ if (!dev->data->mac_addrs) {
+ PMD_DRV_LOG(ERR, "Failed to allocated memory for storing mac address");
+ }
CHECK:SPACING: No space is necessary after a cast
#1224: FILE: drivers/net/ark/ark_ethdev.c:308:
+ ether_addr_copy((struct ether_addr *) &adr, &dev->data->mac_addrs[0]);
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#1237: FILE: drivers/net/ark/ark_ethdev.c:321:
+ * ports */
CHECK:SPACING: No space is necessary after a cast
#1293: FILE: drivers/net/ark/ark_ethdev.c:377:
+ ether_addr_copy((struct ether_addr *) &adr,
WARNING:BRACES: braces {} are not necessary for single statement blocks
#1296: FILE: drivers/net/ark/ark_ethdev.c:380:
+ if (ark->user_ext.dev_init) {
+ ark->user_data = ark->user_ext.dev_init(dev, ark->Abar, p);
+ }
CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#1316: FILE: drivers/net/ark/ark_ethdev.c:400:
+
+}
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#1319: FILE: drivers/net/ark/ark_ethdev.c:403:
+/* Initial device configuration when device is opened
+ setup the DDM, and UDM
CHECK:SPACING: No space is necessary after a cast
#1325: FILE: drivers/net/ark/ark_ethdev.c:409:
+ struct ark_adapter *ark = (struct ark_adapter *) dev->data->dev_private;
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#1330: FILE: drivers/net/ark/ark_ethdev.c:414:
+ * known state */
WARNING:BRACES: braces {} are not necessary for single statement blocks
#1339: FILE: drivers/net/ark/ark_ethdev.c:423:
+ if (ark_udm_verify(ark->udm.v)) {
+ return -1;
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#1342: FILE: drivers/net/ark/ark_ethdev.c:426:
+ if (ark_ddm_verify(ark->ddm.v)) {
+ return -1;
+ }
WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#1348: FILE: drivers/net/ark/ark_ethdev.c:432:
+ PMD_DRV_LOG(ERR, "Unable to stop and reset UDM
");
CHECK:CAMELCASE: Avoid CamelCase: <rxQueues>
#1356: FILE: drivers/net/ark/ark_ethdev.c:440:
+ ark->rxQueues = numQ;
WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#1370: FILE: drivers/net/ark/ark_ethdev.c:454:
+ PMD_DRV_LOG(ERR, "Unable to stop DDM
");
CHECK:CAMELCASE: Avoid CamelCase: <txQueues>
#1375: FILE: drivers/net/ark/ark_ethdev.c:459:
+ ark->txQueues = numQ;
CHECK:SPACING: No space is necessary after a cast
#1396: FILE: drivers/net/ark/ark_ethdev.c:480:
+ struct ark_adapter *ark = (struct ark_adapter *) dev->data->dev_private;
WARNING:BRACES: braces {} are not necessary for single statement blocks
#1401: FILE: drivers/net/ark/ark_ethdev.c:485:
+ if (ark->user_ext.dev_uninit) {
+ ark->user_ext.dev_uninit(dev, ark->user_data);
+ }
CHECK:SPACING: No space is necessary after a cast
#1424: FILE: drivers/net/ark/ark_ethdev.c:508:
+ struct ark_adapter *ark = (struct ark_adapter *) dev->data->dev_private;
WARNING:BRACES: braces {} are not necessary for single statement blocks
#1427: FILE: drivers/net/ark/ark_ethdev.c:511:
+ if (ark->user_ext.dev_configure) {
+ return ark->user_ext.dev_configure(dev, ark->user_data);
+ }
CHECK:SPACING: No space is necessary after a cast
#1436: FILE: drivers/net/ark/ark_ethdev.c:520:
+ struct ark_adapter *ark = (struct ark_adapter *) arg;
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#1440: FILE: drivers/net/ark/ark_ethdev.c:524:
+ * to setup the test before we generate packets */
CHECK:SPACING: No space is necessary after a cast
#1449: FILE: drivers/net/ark/ark_ethdev.c:533:
+ struct ark_adapter *ark = (struct ark_adapter *) dev->data->dev_private;
WARNING:BRACES: braces {} are not necessary for single statement blocks
#1458: FILE: drivers/net/ark/ark_ethdev.c:542:
+ for (i = 0; i < dev->data->nb_rx_queues; i++) {
+ eth_ark_rx_start_queue(dev, i);
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#1463: FILE: drivers/net/ark/ark_ethdev.c:547:
+ for (i = 0; i < dev->data->nb_tx_queues; i++) {
+ eth_ark_tx_queue_start(dev, i);
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#1475: FILE: drivers/net/ark/ark_ethdev.c:559:
+ if (ark->start_pg) {
+ ark_pmd_pktchkr_run(ark->pc);
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#1486: FILE: drivers/net/ark/ark_ethdev.c:570:
+ if (ark->user_ext.dev_start) {
+ ark->user_ext.dev_start(dev, ark->user_data);
+ }
CHECK:SPACING: No space is necessary after a cast
#1498: FILE: drivers/net/ark/ark_ethdev.c:582:
+ struct ark_adapter *ark = (struct ark_adapter *) dev->data->dev_private;
WARNING:BRACES: braces {} are not necessary for single statement blocks
#1508: FILE: drivers/net/ark/ark_ethdev.c:592:
+ if (ark->user_ext.dev_stop) {
+ ark->user_ext.dev_stop(dev, ark->user_data);
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#1513: FILE: drivers/net/ark/ark_ethdev.c:597:
+ if (ark->start_pg) {
+ ark_pmd_pktgen_pause(ark->pg);
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#1572: FILE: drivers/net/ark/ark_ethdev.c:656:
+ for (i = 0; i < dev->data->nb_tx_queues; i++) {
+ eth_ark_rx_dump_queue(dev, i, __func__);
+ }
CHECK:SPACING: No space is necessary after a cast
#1586: FILE: drivers/net/ark/ark_ethdev.c:670:
+ struct ark_adapter *ark = (struct ark_adapter *) dev->data->dev_private;
WARNING:BRACES: braces {} are not necessary for single statement blocks
#1589: FILE: drivers/net/ark/ark_ethdev.c:673:
+ if (ark->user_ext.dev_close) {
+ ark->user_ext.dev_close(dev, ark->user_data);
+ }
CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#1609: FILE: drivers/net/ark/ark_ethdev.c:693:
+
+}
CHECK:SPACING: No space is necessary after a cast
#1615: FILE: drivers/net/ark/ark_ethdev.c:699:
+ struct ark_adapter *ark = (struct ark_adapter *) dev->data->dev_private;
CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#1653: FILE: drivers/net/ark/ark_ethdev.c:737:
+
+}
CHECK:SPACING: No space is necessary after a cast
#1660: FILE: drivers/net/ark/ark_ethdev.c:744:
+ struct ark_adapter *ark = (struct ark_adapter *) dev->data->dev_private;
CHECK:SPACING: No space is necessary after a cast
#1673: FILE: drivers/net/ark/ark_ethdev.c:757:
+ struct ark_adapter *ark = (struct ark_adapter *) dev->data->dev_private;
WARNING:BRACES: braces {} are not necessary for single statement blocks
#1675: FILE: drivers/net/ark/ark_ethdev.c:759:
+ if (ark->user_ext.dev_set_link_up) {
+ return ark->user_ext.dev_set_link_up(dev, ark->user_data);
+ }
CHECK:SPACING: No space is necessary after a cast
#1685: FILE: drivers/net/ark/ark_ethdev.c:769:
+ struct ark_adapter *ark = (struct ark_adapter *) dev->data->dev_private;
WARNING:BRACES: braces {} are not necessary for single statement blocks
#1687: FILE: drivers/net/ark/ark_ethdev.c:771:
+ if (ark->user_ext.dev_set_link_down) {
+ return ark->user_ext.dev_set_link_down(dev, ark->user_data);
+ }
CHECK:SPACING: No space is necessary after a cast
#1697: FILE: drivers/net/ark/ark_ethdev.c:781:
+ struct ark_adapter *ark = (struct ark_adapter *) dev->data->dev_private;
WARNING:BRACES: braces {} are not necessary for single statement blocks
#1706: FILE: drivers/net/ark/ark_ethdev.c:790:
+ for (i = 0; i < dev->data->nb_tx_queues; i++) {
+ eth_tx_queue_stats_get(dev->data->tx_queues[i], stats);
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#1710: FILE: drivers/net/ark/ark_ethdev.c:794:
+ for (i = 0; i < dev->data->nb_rx_queues; i++) {
+ eth_rx_queue_stats_get(dev->data->rx_queues[i], stats);
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#1714: FILE: drivers/net/ark/ark_ethdev.c:798:
+ if (ark->user_ext.stats_get) {
+ ark->user_ext.stats_get(dev, stats, ark->user_data);
+ }
CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#1718: FILE: drivers/net/ark/ark_ethdev.c:802:
+
+}
CHECK:SPACING: No space is necessary after a cast
#1724: FILE: drivers/net/ark/ark_ethdev.c:808:
+ struct ark_adapter *ark = (struct ark_adapter *) dev->data->dev_private;
WARNING:BRACES: braces {} are not necessary for single statement blocks
#1726: FILE: drivers/net/ark/ark_ethdev.c:810:
+ for (i = 0; i < dev->data->nb_tx_queues; i++) {
+ eth_tx_queue_stats_reset(dev->data->rx_queues[i]);
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#1730: FILE: drivers/net/ark/ark_ethdev.c:814:
+ for (i = 0; i < dev->data->nb_rx_queues; i++) {
+ eth_rx_queue_stats_reset(dev->data->rx_queues[i]);
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#1734: FILE: drivers/net/ark/ark_ethdev.c:818:
+ if (ark->user_ext.stats_reset) {
+ ark->user_ext.stats_reset(dev, ark->user_data);
+ }
CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#1738: FILE: drivers/net/ark/ark_ethdev.c:822:
+
+}
CHECK:SPACING: No space is necessary after a cast
#1744: FILE: drivers/net/ark/ark_ethdev.c:828:
+ struct ark_adapter *ark = (struct ark_adapter *) dev->data->dev_private;
WARNING:BRACES: braces {} are not necessary for single statement blocks
#1746: FILE: drivers/net/ark/ark_ethdev.c:830:
+ if (ark->user_ext.mac_addr_add) {
+ ark->user_ext.mac_addr_add(dev, mac_addr, index, pool, ark->user_data);
+ }
CHECK:SPACING: No space is necessary after a cast
#1754: FILE: drivers/net/ark/ark_ethdev.c:838:
+ struct ark_adapter *ark = (struct ark_adapter *) dev->data->dev_private;
WARNING:BRACES: braces {} are not necessary for single statement blocks
#1756: FILE: drivers/net/ark/ark_ethdev.c:840:
+ if (ark->user_ext.mac_addr_remove) {
+ ark->user_ext.mac_addr_remove(dev, index, ark->user_data);
+ }
CHECK:SPACING: No space is necessary after a cast
#1765: FILE: drivers/net/ark/ark_ethdev.c:849:
+ struct ark_adapter *ark = (struct ark_adapter *) dev->data->dev_private;
WARNING:BRACES: braces {} are not necessary for single statement blocks
#1767: FILE: drivers/net/ark/ark_ethdev.c:851:
+ if (ark->user_ext.mac_addr_set) {
+ ark->user_ext.mac_addr_set(dev, mac_addr, ark->user_data);
+ }
CHECK:SPACING: No space is necessary after a cast
#1788: FILE: drivers/net/ark/ark_ethdev.c:872:
+ char *args = (char *) extra_args;
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#1813: FILE: drivers/net/ark/ark_ethdev.c:897:
+ unsigned k_idx;
WARNING:LONG_LINE: line over 90 characters
#1986: FILE: drivers/net/ark/ark_ethdev.o.pmd.c:1:
+const char net_ark_pmd_info[] __attribute__((used)) = "PMD_INFO_STRING= {\"name\" : \"net_ark\", \"kmod\" : \"* igb_uio | uio_pci_generic \", \"pci_ids\" : []}";
WARNING:LONG_LINE: line over 90 characters
#1987: FILE: drivers/net/ark/ark_ethdev.o.pmd.c:2:
+const char eth_ark_pmd_info[] __attribute__((used)) = "PMD_INFO_STRING= {\"name\" : \"eth_ark\", \"pci_ids\" : [[7532, 4109, 65535, 65535],[7532, 4110, 65535, 65535] ]}";
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#2059: FILE: drivers/net/ark/ark_ethdev_rx.c:66:
+struct ark_rx_queue {
+
CHECK:CAMELCASE: Avoid CamelCase: <queueSize>
#2070: FILE: drivers/net/ark/ark_ethdev_rx.c:77:
+ uint32_t queueSize;
CHECK:CAMELCASE: Avoid CamelCase: <queueMask>
#2071: FILE: drivers/net/ark/ark_ethdev_rx.c:78:
+ uint32_t queueMask;
CHECK:CAMELCASE: Avoid CamelCase: <seedIndex>
#2073: FILE: drivers/net/ark/ark_ethdev_rx.c:80:
+ uint32_t seedIndex; /* 1 set with an empty mbuf */
CHECK:CAMELCASE: Avoid CamelCase: <queueIndex>
#2080: FILE: drivers/net/ark/ark_ethdev_rx.c:87:
+ uint16_t queueIndex;
CHECK:CAMELCASE: Avoid CamelCase: <prodIndex>
#2088: FILE: drivers/net/ark/ark_ethdev_rx.c:95:
+ volatile uint32_t prodIndex; /* 2 filled by the HW */
CHECK:CAMELCASE: Avoid CamelCase: <userData>
#2099: FILE: drivers/net/ark/ark_ethdev_rx.c:106:
+ uint64_t userData;
CHECK:CAMELCASE: Avoid CamelCase: <dstQueue>
#2101: FILE: drivers/net/ark/ark_ethdev_rx.c:108:
+ uint8_t dstQueue;
CHECK:CAMELCASE: Avoid CamelCase: <pktLen>
#2102: FILE: drivers/net/ark/ark_ethdev_rx.c:109:
+ uint16_t pktLen;
CHECK:CAMELCASE: Avoid CamelCase: <queueBase>
#2113: FILE: drivers/net/ark/ark_ethdev_rx.c:120:
+ phys_addr_t queueBase;
CHECK:CAMELCASE: Avoid CamelCase: <physAddrQBase>
#2114: FILE: drivers/net/ark/ark_ethdev_rx.c:121:
+ phys_addr_t physAddrQBase;
CHECK:CAMELCASE: Avoid CamelCase: <physAddrProdIndex>
#2115: FILE: drivers/net/ark/ark_ethdev_rx.c:122:
+ phys_addr_t physAddrProdIndex;
CHECK:CAMELCASE: Avoid CamelCase: <paddressQ>
#2121: FILE: drivers/net/ark/ark_ethdev_rx.c:128:
+ physAddrQBase = rte_malloc_virt2phy(queue->paddressQ);
CHECK:CAMELCASE: Avoid CamelCase: <eth_ark_rx_update_consIndex>
#2145: FILE: drivers/net/ark/ark_ethdev_rx.c:152:
+eth_ark_rx_update_consIndex(struct ark_rx_queue *queue, uint32_t consIndex)
CHECK:SPACING: No space is necessary after a cast
#2160: FILE: drivers/net/ark/ark_ethdev_rx.c:167:
+ struct ark_adapter *ark = (struct ark_adapter *) dev->data->dev_private;
CHECK:CAMELCASE: Avoid CamelCase: <reserveQ>
#2213: FILE: drivers/net/ark/ark_ethdev_rx.c:220:
+ queue->reserveQ =
CHECK:SPACING: No space is necessary after a cast
#2276: FILE: drivers/net/ark/ark_ethdev_rx.c:283:
+ queue = (struct ark_rx_queue *) rx_queue;
CHECK:CAMELCASE: Avoid CamelCase: <prodIdx>
#2314: FILE: drivers/net/ark/ark_ethdev_rx.c:321:
+ queue->udm->rt_cfg.prodIdx,
CHECK:CAMELCASE: Avoid CamelCase: <seedM>
#2476: FILE: drivers/net/ark/ark_ethdev_rx.c:483:
+ struct rte_mbuf **mbufs = &queue->reserveQ[seedM];
CHECK:SPACING: No space is necessary after a cast
#2488: FILE: drivers/net/ark/ark_ethdev_rx.c:495:
+ *((uint32_t *) mbuf_init->buf_addr) = seedIndex + count;
CHECK:SPACING: No space is necessary after a cast
#2489: FILE: drivers/net/ark/ark_ethdev_rx.c:496:
+ *(uint16_t *) RTE_PTR_ADD(mbuf_init->buf_addr, 4) =
CHECK:SPACING: No space is necessary after a cast
#2544: FILE: drivers/net/ark/ark_ethdev_rx.c:551:
+ queue = (struct ark_rx_queue *) vqueue;
CHECK:SPACING: No space is necessary after a cast
#2602: FILE: drivers/net/ark/ark_ethdev_rx.c:609:
+ struct ark_adapter *ark = (struct ark_adapter *) dev->data->dev_private;
CHECK:SPACING: No space is necessary after a cast
#2611: FILE: drivers/net/ark/ark_ethdev_rx.c:618:
+ queue = (struct ark_rx_queue *) dev->data->rx_queues[i];
CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#2628: FILE: drivers/net/ark/ark_ethdev_rx.c:635:
+
+}
CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#2646: FILE: drivers/net/ark/ark_ethdev_rx.c:653:
+
+}
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#2742: FILE: drivers/net/ark/ark_ethdev_tx.c:72:
+struct ark_tx_queue {
+
CHECK:CAMELCASE: Avoid CamelCase: <freeIndex>
#2758: FILE: drivers/net/ark/ark_ethdev_tx.c:88:
+ uint32_t freeIndex; /* mbuf has been freed */
CHECK:CAMELCASE: Avoid CamelCase: <prodIndexLimit>
#2812: FILE: drivers/net/ark/ark_ethdev_tx.c:142:
+ uint32_t prodIndexLimit;
CHECK:SPACING: No space is necessary after a cast
#2816: FILE: drivers/net/ark/ark_ethdev_tx.c:146:
+ queue = (struct ark_tx_queue *) vtxq;
CHECK:CAMELCASE: Avoid CamelCase: <toAdd>
#2833: FILE: drivers/net/ark/ark_ethdev_tx.c:163:
+ uint16_t toAdd = 60 - rte_pktmbuf_pkt_len(mbuf);
WARNING:LONG_LINE_COMMENT: line over 90 characters
#2837: FILE: drivers/net/ark/ark_ethdev_tx.c:167:
+ /* This packet is in error, we cannot send it so just
CHECK:CAMELCASE: Avoid CamelCase: <metaQ>
#2855: FILE: drivers/net/ark/ark_ethdev_tx.c:185:
+ meta = &queue->metaQ[idx];
WARNING:LONG_LINE: line over 90 characters
#2857: FILE: drivers/net/ark/ark_ethdev_tx.c:187:
+ ARK_DDM_SOP | ARK_DDM_EOP);
WARNING:LONG_LINE: line over 90 characters
#2866: FILE: drivers/net/ark/ark_ethdev_tx.c:196:
+ nb_pkts, nb, queue->prodIndex, queue->consIndex,
CHECK:CAMELCASE: Avoid CamelCase: <freeQueueSpace>
#2885: FILE: drivers/net/ark/ark_ethdev_tx.c:215:
+ uint32_t freeQueueSpace;
WARNING:BRACES: braces {} are not necessary for single statement blocks
#2890: FILE: drivers/net/ark/ark_ethdev_tx.c:220:
+ if (unlikely(freeQueueSpace < mbuf->nb_segs)) {
+ return -1;
+ }
CHECK:SPACING: No space is necessary after a cast
#2926: FILE: drivers/net/ark/ark_ethdev_tx.c:256:
+ struct ark_adapter *ark = (struct ark_adapter *) dev->data->dev_private;
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#2944: FILE: drivers/net/ark/ark_ethdev_tx.c:274:
+^I/* ^Idev->data->tx_queues[queue_idx] = NULL; */$
CHECK:CAMELCASE: Avoid CamelCase: <ringBase>
#2998: FILE: drivers/net/ark/ark_ethdev_tx.c:328:
+ phys_addr_t queueBase, ringBase, prodIndexAddr;
CHECK:CAMELCASE: Avoid CamelCase: <prodIndexAddr>
#2998: FILE: drivers/net/ark/ark_ethdev_tx.c:328:
+ phys_addr_t queueBase, ringBase, prodIndexAddr;
CHECK:CAMELCASE: Avoid CamelCase: <writeInterval_ns>
#2999: FILE: drivers/net/ark/ark_ethdev_tx.c:329:
+ uint32_t writeInterval_ns;
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#3016: FILE: drivers/net/ark/ark_ethdev_tx.c:346:
+ * when low mbuf count */
CHECK:SPACING: No space is necessary after a cast
#3044: FILE: drivers/net/ark/ark_ethdev_tx.c:374:
+ queue = (struct ark_tx_queue *) vtx_queue;
CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#3055: FILE: drivers/net/ark/ark_ethdev_tx.c:385:
+
+}
CHECK:CAMELCASE: Avoid CamelCase: <topIndex>
#3102: FILE: drivers/net/ark/ark_ethdev_tx.c:432:
+ uint32_t topIndex;
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#3193: FILE: drivers/net/ark/ark_ext.h:38:
+/*
+ Called post PMD init. The implementation returns its private data that gets passed into
WARNING:LONG_LINE_COMMENT: line over 90 characters
#3202: FILE: drivers/net/ark/ark_ext.h:47:
+/* This call is optional and allows the extension to specify the number of supported ports. */
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#3206: FILE: drivers/net/ark/ark_ext.h:51:
+/*
+ The following functions are optional and are directly mapped from the DPDK PMD ops
WARNING:LONG_LINE_COMMENT: line over 90 characters
#3207: FILE: drivers/net/ark/ark_ext.h:52:
+ structure. Each function if implemented is called after the ARK PMD implementation executes.
CHECK:CAMELCASE: Avoid CamelCase: <Offset8>
#3301: FILE: drivers/net/ark/ark_global.h:69:
+#define Offset8(n) n
CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#3302: FILE: drivers/net/ark/ark_global.h:70:
+#define Offset16(n) (n/2)
^
CHECK:CAMELCASE: Avoid CamelCase: <Offset16>
#3302: FILE: drivers/net/ark/ark_global.h:70:
+#define Offset16(n) (n/2)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'n' may be better as '(n)' to avoid precedence issues
#3302: FILE: drivers/net/ark/ark_global.h:70:
+#define Offset16(n) (n/2)
CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#3303: FILE: drivers/net/ark/ark_global.h:71:
+#define Offset32(n) (n/4)
^
CHECK:CAMELCASE: Avoid CamelCase: <Offset32>
#3303: FILE: drivers/net/ark/ark_global.h:71:
+#define Offset32(n) (n/4)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'n' may be better as '(n)' to avoid precedence issues
#3303: FILE: drivers/net/ark/ark_global.h:71:
+#define Offset32(n) (n/4)
CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
#3304: FILE: drivers/net/ark/ark_global.h:72:
+#define Offset64(n) (n/8)
^
CHECK:CAMELCASE: Avoid CamelCase: <Offset64>
#3304: FILE: drivers/net/ark/ark_global.h:72:
+#define Offset64(n) (n/8)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'n' may be better as '(n)' to avoid precedence issues
#3304: FILE: drivers/net/ark/ark_global.h:72:
+#define Offset64(n) (n/8)
CHECK:CAMELCASE: Avoid CamelCase: <DefPtr>
#3309: FILE: drivers/net/ark/ark_global.h:77:
+#define DefPtr(type, name) \
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3310: FILE: drivers/net/ark/ark_global.h:78:
+ union type { \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3316: FILE: drivers/net/ark/ark_global.h:84:
+ } name$
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'bar' - possible side-effects?
#3318: FILE: drivers/net/ark/ark_global.h:86:
+#define SetPtr(bar, ark, mem, off) { \
+ ark->mem.t64 = (uint64_t *)&ark->bar[off]; \
+ ark->mem.t32 = (uint32_t *)&ark->bar[off]; \
+ ark->mem.t16 = (uint16_t *)&ark->bar[off]; \
+ ark->mem.t8 = (uint8_t *)&ark->bar[off]; \
+ }
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'bar' may be better as '(bar)' to avoid precedence issues
#3318: FILE: drivers/net/ark/ark_global.h:86:
+#define SetPtr(bar, ark, mem, off) { \
+ ark->mem.t64 = (uint64_t *)&ark->bar[off]; \
+ ark->mem.t32 = (uint32_t *)&ark->bar[off]; \
+ ark->mem.t16 = (uint16_t *)&ark->bar[off]; \
+ ark->mem.t8 = (uint8_t *)&ark->bar[off]; \
+ }
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ark' - possible side-effects?
#3318: FILE: drivers/net/ark/ark_global.h:86:
+#define SetPtr(bar, ark, mem, off) { \
+ ark->mem.t64 = (uint64_t *)&ark->bar[off]; \
+ ark->mem.t32 = (uint32_t *)&ark->bar[off]; \
+ ark->mem.t16 = (uint16_t *)&ark->bar[off]; \
+ ark->mem.t8 = (uint8_t *)&ark->bar[off]; \
+ }
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'ark' may be better as '(ark)' to avoid precedence issues
#3318: FILE: drivers/net/ark/ark_global.h:86:
+#define SetPtr(bar, ark, mem, off) { \
+ ark->mem.t64 = (uint64_t *)&ark->bar[off]; \
+ ark->mem.t32 = (uint32_t *)&ark->bar[off]; \
+ ark->mem.t16 = (uint16_t *)&ark->bar[off]; \
+ ark->mem.t8 = (uint8_t *)&ark->bar[off]; \
+ }
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'mem' - possible side-effects?
#3318: FILE: drivers/net/ark/ark_global.h:86:
+#define SetPtr(bar, ark, mem, off) { \
+ ark->mem.t64 = (uint64_t *)&ark->bar[off]; \
+ ark->mem.t32 = (uint32_t *)&ark->bar[off]; \
+ ark->mem.t16 = (uint16_t *)&ark->bar[off]; \
+ ark->mem.t8 = (uint8_t *)&ark->bar[off]; \
+ }
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'mem' may be better as '(mem)' to avoid precedence issues
#3318: FILE: drivers/net/ark/ark_global.h:86:
+#define SetPtr(bar, ark, mem, off) { \
+ ark->mem.t64 = (uint64_t *)&ark->bar[off]; \
+ ark->mem.t32 = (uint32_t *)&ark->bar[off]; \
+ ark->mem.t16 = (uint16_t *)&ark->bar[off]; \
+ ark->mem.t8 = (uint8_t *)&ark->bar[off]; \
+ }
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'off' - possible side-effects?
#3318: FILE: drivers/net/ark/ark_global.h:86:
+#define SetPtr(bar, ark, mem, off) { \
+ ark->mem.t64 = (uint64_t *)&ark->bar[off]; \
+ ark->mem.t32 = (uint32_t *)&ark->bar[off]; \
+ ark->mem.t16 = (uint16_t *)&ark->bar[off]; \
+ ark->mem.t8 = (uint8_t *)&ark->bar[off]; \
+ }
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3319: FILE: drivers/net/ark/ark_global.h:87:
+ ark->mem.t64 = (uint64_t *)&ark->bar[off]; \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3320: FILE: drivers/net/ark/ark_global.h:88:
+ ark->mem.t32 = (uint32_t *)&ark->bar[off]; \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3321: FILE: drivers/net/ark/ark_global.h:89:
+ ark->mem.t16 = (uint16_t *)&ark->bar[off]; \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3322: FILE: drivers/net/ark/ark_global.h:90:
+ ark->mem.t8 = (uint8_t *)&ark->bar[off]; \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3323: FILE: drivers/net/ark/ark_global.h:91:
+ }$
WARNING:SPACING: Unnecessary space before function pointer arguments
#3331: FILE: drivers/net/ark/ark_global.h:99:
+ void *(*dev_init) (struct rte_eth_dev *, void *abar, int port_id);
WARNING:SPACING: Unnecessary space before function pointer arguments
#3332: FILE: drivers/net/ark/ark_global.h:100:
+ void (*dev_uninit) (struct rte_eth_dev *, void *);
WARNING:SPACING: Unnecessary space before function pointer arguments
#3333: FILE: drivers/net/ark/ark_global.h:101:
+ int (*dev_get_port_count) (struct rte_eth_dev *, void *);
WARNING:SPACING: Unnecessary space before function pointer arguments
#3334: FILE: drivers/net/ark/ark_global.h:102:
+ int (*dev_configure) (struct rte_eth_dev *, void *);
WARNING:SPACING: Unnecessary space before function pointer arguments
#3335: FILE: drivers/net/ark/ark_global.h:103:
+ int (*dev_start) (struct rte_eth_dev *, void *);
WARNING:SPACING: Unnecessary space before function pointer arguments
#3336: FILE: drivers/net/ark/ark_global.h:104:
+ void (*dev_stop) (struct rte_eth_dev *, void *);
WARNING:SPACING: Unnecessary space before function pointer arguments
#3337: FILE: drivers/net/ark/ark_global.h:105:
+ void (*dev_close) (struct rte_eth_dev *, void *);
WARNING:SPACING: Unnecessary space before function pointer arguments
#3338: FILE: drivers/net/ark/ark_global.h:106:
+ int (*link_update) (struct rte_eth_dev *, int wait_to_complete, void *);
WARNING:SPACING: Unnecessary space before function pointer arguments
#3339: FILE: drivers/net/ark/ark_global.h:107:
+ int (*dev_set_link_up) (struct rte_eth_dev *, void *);
WARNING:SPACING: Unnecessary space before function pointer arguments
#3340: FILE: drivers/net/ark/ark_global.h:108:
+ int (*dev_set_link_down) (struct rte_eth_dev *, void *);
WARNING:SPACING: Unnecessary space before function pointer arguments
#3341: FILE: drivers/net/ark/ark_global.h:109:
+ void (*stats_get) (struct rte_eth_dev *, struct rte_eth_stats *, void *);
WARNING:SPACING: Unnecessary space before function pointer arguments
#3342: FILE: drivers/net/ark/ark_global.h:110:
+ void (*stats_reset) (struct rte_eth_dev *, void *);
WARNING:SPACING: Unnecessary space before function pointer arguments
#3343: FILE: drivers/net/ark/ark_global.h:111:
+ void (*mac_addr_add) (struct rte_eth_dev *,
WARNING:SPACING: Unnecessary space before function pointer arguments
#3345: FILE: drivers/net/ark/ark_global.h:113:
+ void (*mac_addr_remove) (struct rte_eth_dev *, uint32_t, void *);
WARNING:SPACING: Unnecessary space before function pointer arguments
#3346: FILE: drivers/net/ark/ark_global.h:114:
+ void (*mac_addr_set) (struct rte_eth_dev *, struct ether_addr *, void *);
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#3350: FILE: drivers/net/ark/ark_global.h:118:
+struct ark_adapter {
+
CHECK:CAMELCASE: Avoid CamelCase: <ArkPktGen_t>
#3356: FILE: drivers/net/ark/ark_global.h:124:
+ ArkPktGen_t pg;
CHECK:CAMELCASE: Avoid CamelCase: <ArkPktChkr_t>
#3357: FILE: drivers/net/ark/ark_global.h:125:
+ ArkPktChkr_t pc;
CHECK:CAMELCASE: Avoid CamelCase: <ArkPktDir_t>
#3358: FILE: drivers/net/ark/ark_global.h:126:
+ ArkPktDir_t pd;
CHECK:CAMELCASE: Avoid CamelCase: <SysCtrl>
#3376: FILE: drivers/net/ark/ark_global.h:144:
+ DefPtr(SysCtrl, sysctrl);
CHECK:CAMELCASE: Avoid CamelCase: <PktGen>
#3377: FILE: drivers/net/ark/ark_global.h:145:
+ DefPtr(PktGen, pktgen);
CHECK:CAMELCASE: Avoid CamelCase: <MpuRx>
#3378: FILE: drivers/net/ark/ark_global.h:146:
+ DefPtr(MpuRx, mpurx);
CHECK:CAMELCASE: Avoid CamelCase: <MpuTx>
#3380: FILE: drivers/net/ark/ark_global.h:148:
+ DefPtr(MpuTx, mputx);
CHECK:CAMELCASE: Avoid CamelCase: <External>
#3383: FILE: drivers/net/ark/ark_global.h:151:
+ DefPtr(External, external);
CHECK:CAMELCASE: Avoid CamelCase: <PktDir>
#3384: FILE: drivers/net/ark/ark_global.h:152:
+ DefPtr(PktDir, pktdir);
CHECK:CAMELCASE: Avoid CamelCase: <PktChkr>
#3385: FILE: drivers/net/ark/ark_global.h:153:
+ DefPtr(PktChkr, pktchkr);
CHECK:CAMELCASE: Avoid CamelCase: <numQueues>
#3444: FILE: drivers/net/ark/ark_mpu.c:42:
+ return mpu->hw.numQueues;
CHECK:CAMELCASE: Avoid CamelCase: <objSize>
#3454: FILE: drivers/net/ark/ark_mpu.c:52:
+ark_mpu_verify(struct ark_mpu_t *mpu, uint32_t objSize)
CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#3460: FILE: drivers/net/ark/ark_mpu.c:58:
+ if ((mpu->id.idnum != 0x2055504d) || (mpu->hw.objSize != objSize)
+ || version != 0x00003100) {
CHECK:CAMELCASE: Avoid CamelCase: <hwDepth>
#3468: FILE: drivers/net/ark/ark_mpu.c:66:
+ mpu->hw.numQueues, mpu->hw.hwDepth, mpu->hw.objSize,
CHECK:CAMELCASE: Avoid CamelCase: <objPerMRR>
#3469: FILE: drivers/net/ark/ark_mpu.c:67:
+ mpu->hw.objPerMRR, objSize);
CHECK:CAMELCASE: Avoid CamelCase: <MPU_CMD_Stop>
#3478: FILE: drivers/net/ark/ark_mpu.c:76:
+ mpu->cfg.command = MPU_CMD_Stop;
CHECK:CAMELCASE: Avoid CamelCase: <MPU_CMD_Run>
#3484: FILE: drivers/net/ark/ark_mpu.c:82:
+ mpu->cfg.command = MPU_CMD_Run; /* run state */
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#3490: FILE: drivers/net/ark/ark_mpu.c:88:
+{
+
CHECK:CAMELCASE: Avoid CamelCase: <MPU_CMD_Reset>
#3493: FILE: drivers/net/ark/ark_mpu.c:91:
+ mpu->cfg.command = MPU_CMD_Reset; /* reset */
CHECK:CAMELCASE: Avoid CamelCase: <MPU_CMD_Idle>
#3495: FILE: drivers/net/ark/ark_mpu.c:93:
+ while (mpu->cfg.command != MPU_CMD_Idle) {
CHECK:CAMELCASE: Avoid CamelCase: <MPU_CMD_ForceReset>
#3501: FILE: drivers/net/ark/ark_mpu.c:99:
+ mpu->cfg.command = MPU_CMD_ForceReset; /* forced reset */
CHECK:CAMELCASE: Avoid CamelCase: <pciRequest>
#3511: FILE: drivers/net/ark/ark_mpu.c:109:
+ mpu->stats.pciRequest = 1; /* reset stats */
CHECK:CAMELCASE: Avoid CamelCase: <ringSize>
#3515: FILE: drivers/net/ark/ark_mpu.c:113:
+ark_mpu_configure(struct ark_mpu_t *mpu, phys_addr_t ring, uint32_t ringSize,
CHECK:CAMELCASE: Avoid CamelCase: <isTx>
#3516: FILE: drivers/net/ark/ark_mpu.c:114:
+ int isTx)
CHECK:CAMELCASE: Avoid CamelCase: <ringMask>
#3527: FILE: drivers/net/ark/ark_mpu.c:125:
+ mpu->cfg.ringMask = ringSize - 1;
CHECK:CAMELCASE: Avoid CamelCase: <minHostMove>
#3528: FILE: drivers/net/ark/ark_mpu.c:126:
+ mpu->cfg.minHostMove = isTx ? 1 : mpu->hw.objPerMRR;
CHECK:CAMELCASE: Avoid CamelCase: <minHWMove>
#3529: FILE: drivers/net/ark/ark_mpu.c:127:
+ mpu->cfg.minHWMove = mpu->hw.objPerMRR;
CHECK:CAMELCASE: Avoid CamelCase: <swProdIndex>
#3530: FILE: drivers/net/ark/ark_mpu.c:128:
+ mpu->cfg.swProdIndex = 0;
CHECK:CAMELCASE: Avoid CamelCase: <hwConsIndex>
#3531: FILE: drivers/net/ark/ark_mpu.c:129:
+ mpu->cfg.hwConsIndex = 0;
CHECK:CAMELCASE: Avoid CamelCase: <qEmpty>
#3552: FILE: drivers/net/ark/ark_mpu.c:150:
+ "QueueEmpty", mpu->stats.qEmpty,
CHECK:CAMELCASE: Avoid CamelCase: <qQ1>
#3553: FILE: drivers/net/ark/ark_mpu.c:151:
+ "QueueQ1", mpu->stats.qQ1,
CHECK:CAMELCASE: Avoid CamelCase: <qQ2>
#3554: FILE: drivers/net/ark/ark_mpu.c:152:
+ "QueueQ2", mpu->stats.qQ2,
CHECK:CAMELCASE: Avoid CamelCase: <qQ3>
#3555: FILE: drivers/net/ark/ark_mpu.c:153:
+ "QueueQ3", mpu->stats.qQ3,
CHECK:CAMELCASE: Avoid CamelCase: <qQ4>
#3556: FILE: drivers/net/ark/ark_mpu.c:154:
+ "QueueQ4", mpu->stats.qQ4,
CHECK:CAMELCASE: Avoid CamelCase: <qFull>
#3557: FILE: drivers/net/ark/ark_mpu.c:155:
+ "QueueFull", mpu->stats.qFull
CHECK:CAMELCASE: Avoid CamelCase: <qId>
#3562: FILE: drivers/net/ark/ark_mpu.c:160:
+ark_mpu_dump_setup(struct ark_mpu_t *mpu, uint16_t qId)
CHECK:SPACING: No space is necessary after a cast
#3567: FILE: drivers/net/ark/ark_mpu.c:165:
+ "ringBase", (void *) mpu->cfg.ringBase
CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#3570: FILE: drivers/net/ark/ark_mpu.c:168:
+
+}
CHECK:CAMELCASE: Avoid CamelCase: <physId>
#3631: FILE: drivers/net/ark/ark_mpu.h:55:
+ uint32_t physId;
CHECK:CAMELCASE: Avoid CamelCase: <mrrCode>
#3632: FILE: drivers/net/ark/ark_mpu.h:56:
+ uint32_t mrrCode;
CHECK:CAMELCASE: Avoid CamelCase: <setArg>
#3767: FILE: drivers/net/ark/ark_pktchkr.c:42:
+static int setArg(char *arg, char *val);
CHECK:CAMELCASE: Avoid CamelCase: <ark_pmd_pktchkr_isGenForever>
#3768: FILE: drivers/net/ark/ark_pktchkr.c:43:
+static int ark_pmd_pktchkr_isGenForever(ArkPktChkr_t handle);
CHECK:CAMELCASE: Avoid CamelCase: <OptV>
#3771: FILE: drivers/net/ark/ark_pktchkr.c:46:
+union OptV {
CHECK:CAMELCASE: Avoid CamelCase: <Int>
#3772: FILE: drivers/net/ark/ark_pktchkr.c:47:
+ int Int;
CHECK:CAMELCASE: Avoid CamelCase: <Bool>
#3773: FILE: drivers/net/ark/ark_pktchkr.c:48:
+ int Bool;
CHECK:CAMELCASE: Avoid CamelCase: <Long>
#3774: FILE: drivers/net/ark/ark_pktchkr.c:49:
+ uint64_t Long;
CHECK:CAMELCASE: Avoid CamelCase: <Str>
#3775: FILE: drivers/net/ark/ark_pktchkr.c:50:
+ char Str[ARK_MAX_STR_LEN];
CHECK:CAMELCASE: Avoid CamelCase: <OPType>
#3778: FILE: drivers/net/ark/ark_pktchkr.c:53:
+enum OPType {
CHECK:CAMELCASE: Avoid CamelCase: <OTInt>
#3779: FILE: drivers/net/ark/ark_pktchkr.c:54:
+ OTInt,
CHECK:CAMELCASE: Avoid CamelCase: <OTLong>
#3780: FILE: drivers/net/ark/ark_pktchkr.c:55:
+ OTLong,
CHECK:CAMELCASE: Avoid CamelCase: <OTBool>
#3781: FILE: drivers/net/ark/ark_pktchkr.c:56:
+ OTBool,
CHECK:CAMELCASE: Avoid CamelCase: <OTString>
#3782: FILE: drivers/net/ark/ark_pktchkr.c:57:
+ OTString
CHECK:CAMELCASE: Avoid CamelCase: <Options>
#3785: FILE: drivers/net/ark/ark_pktchkr.c:60:
+struct Options {
CHECK:CAMELCASE: Avoid CamelCase: <ArkPktChkrInst>
#3834: FILE: drivers/net/ark/ark_pktchkr.c:109:
+ struct ArkPktChkrInst *inst =
CHECK:SPACING: No space is necessary after a cast
#3836: FILE: drivers/net/ark/ark_pktchkr.c:111:
+ inst->sregs = (struct ArkPktChkrStatRegs *) addr;
CHECK:CAMELCASE: Avoid CamelCase: <ArkPktChkrStatRegs>
#3836: FILE: drivers/net/ark/ark_pktchkr.c:111:
+ inst->sregs = (struct ArkPktChkrStatRegs *) addr;
CHECK:SPACING: No space is necessary after a cast
#3837: FILE: drivers/net/ark/ark_pktchkr.c:112:
+ inst->cregs = (struct ArkPktChkrCtlRegs *) (((uint8_t *) addr) + 0x100);
CHECK:CAMELCASE: Avoid CamelCase: <ArkPktChkrCtlRegs>
#3837: FILE: drivers/net/ark/ark_pktchkr.c:112:
+ inst->cregs = (struct ArkPktChkrCtlRegs *) (((uint8_t *) addr) + 0x100);
CHECK:SPACING: No space is necessary after a cast
#3852: FILE: drivers/net/ark/ark_pktchkr.c:127:
+ struct ArkPktChkrInst *inst = (struct ArkPktChkrInst *) handle;
CHECK:CAMELCASE: Avoid CamelCase: <pktStartStop>
#3854: FILE: drivers/net/ark/ark_pktchkr.c:129:
+ inst->sregs->pktStartStop = 0;
CHECK:SPACING: No space is necessary after a cast
#3861: FILE: drivers/net/ark/ark_pktchkr.c:136:
+ struct ArkPktChkrInst *inst = (struct ArkPktChkrInst *) handle;
CHECK:SPACING: No space is necessary after a cast
#3870: FILE: drivers/net/ark/ark_pktchkr.c:145:
+ struct ArkPktChkrInst *inst = (struct ArkPktChkrInst *) handle;
CHECK:CAMELCASE: Avoid CamelCase: <waitCycle>
#3871: FILE: drivers/net/ark/ark_pktchkr.c:146:
+ int waitCycle = 10;
CHECK:CAMELCASE: Avoid CamelCase: <ark_pmd_pktchkr_isRunning>
#3883: FILE: drivers/net/ark/ark_pktchkr.c:158:
+ark_pmd_pktchkr_isRunning(ArkPktChkr_t handle)
CHECK:SPACING: No space is necessary after a cast
#3885: FILE: drivers/net/ark/ark_pktchkr.c:160:
+ struct ArkPktChkrInst *inst = (struct ArkPktChkrInst *) handle;
CHECK:CAMELCASE: Avoid CamelCase: <ark_pmd_pktchkr_setPktCtrl>
#3892: FILE: drivers/net/ark/ark_pktchkr.c:167:
+ark_pmd_pktchkr_setPktCtrl(ArkPktChkr_t handle, uint32_t genForever,
CHECK:CAMELCASE: Avoid CamelCase: <genForever>
#3892: FILE: drivers/net/ark/ark_pktchkr.c:167:
+ark_pmd_pktchkr_setPktCtrl(ArkPktChkr_t handle, uint32_t genForever,
CHECK:CAMELCASE: Avoid CamelCase: <varyLength>
#3893: FILE: drivers/net/ark/ark_pktchkr.c:168:
+ uint32_t varyLength, uint32_t incrPayload, uint32_t incrFirstByte,
CHECK:CAMELCASE: Avoid CamelCase: <incrPayload>
#3893: FILE: drivers/net/ark/ark_pktchkr.c:168:
+ uint32_t varyLength, uint32_t incrPayload, uint32_t incrFirstByte,
CHECK:CAMELCASE: Avoid CamelCase: <incrFirstByte>
#3893: FILE: drivers/net/ark/ark_pktchkr.c:168:
+ uint32_t varyLength, uint32_t incrPayload, uint32_t incrFirstByte,
CHECK:CAMELCASE: Avoid CamelCase: <insSeqNum>
#3894: FILE: drivers/net/ark/ark_pktchkr.c:169:
+ uint32_t insSeqNum, uint32_t insUDPHdr, uint32_t enResync,
CHECK:CAMELCASE: Avoid CamelCase: <insUDPHdr>
#3894: FILE: drivers/net/ark/ark_pktchkr.c:169:
+ uint32_t insSeqNum, uint32_t insUDPHdr, uint32_t enResync,
CHECK:CAMELCASE: Avoid CamelCase: <enResync>
#3894: FILE: drivers/net/ark/ark_pktchkr.c:169:
+ uint32_t insSeqNum, uint32_t insUDPHdr, uint32_t enResync,
CHECK:CAMELCASE: Avoid CamelCase: <tuserErrVal>
#3895: FILE: drivers/net/ark/ark_pktchkr.c:170:
+ uint32_t tuserErrVal, uint32_t insTimeStamp)
CHECK:CAMELCASE: Avoid CamelCase: <insTimeStamp>
#3895: FILE: drivers/net/ark/ark_pktchkr.c:170:
+ uint32_t tuserErrVal, uint32_t insTimeStamp)
CHECK:SPACING: No space is necessary after a cast
#3897: FILE: drivers/net/ark/ark_pktchkr.c:172:
+ struct ArkPktChkrInst *inst = (struct ArkPktChkrInst *) handle;
CHECK:CAMELCASE: Avoid CamelCase: <pktCtrl>
#3900: FILE: drivers/net/ark/ark_pktchkr.c:175:
+ inst->sregs->pktCtrl = r;
WARNING:BRACES: braces {} are not necessary for single statement blocks
#3901: FILE: drivers/net/ark/ark_pktchkr.c:176:
+ if (!inst->l2_mode) {
+ insUDPHdr = 0;
+ }
CHECK:SPACING: No space is necessary after a cast
#3914: FILE: drivers/net/ark/ark_pktchkr.c:189:
+ struct ArkPktChkrInst *inst = (struct ArkPktChkrInst *) handle;
CHECK:CAMELCASE: Avoid CamelCase: <ark_pmd_pktchkr_waitDone>
#3921: FILE: drivers/net/ark/ark_pktchkr.c:196:
+ark_pmd_pktchkr_waitDone(ArkPktChkr_t handle)
CHECK:SPACING: No space is necessary after a cast
#3923: FILE: drivers/net/ark/ark_pktchkr.c:198:
+ struct ArkPktChkrInst *inst = (struct ArkPktChkrInst *) handle;
CHECK:CAMELCASE: Avoid CamelCase: <ark_pmd_pktchkr_getPktsSent>
#3944: FILE: drivers/net/ark/ark_pktchkr.c:219:
+ark_pmd_pktchkr_getPktsSent(ArkPktChkr_t handle)
CHECK:SPACING: No space is necessary after a cast
#3946: FILE: drivers/net/ark/ark_pktchkr.c:221:
+ struct ArkPktChkrInst *inst = (struct ArkPktChkrInst *) handle;
CHECK:CAMELCASE: Avoid CamelCase: <pktsSent>
#3948: FILE: drivers/net/ark/ark_pktchkr.c:223:
+ return inst->cregs->pktsSent;
CHECK:CAMELCASE: Avoid CamelCase: <ark_pmd_pktchkr_setPayloadByte>
#3952: FILE: drivers/net/ark/ark_pktchkr.c:227:
+ark_pmd_pktchkr_setPayloadByte(ArkPktChkr_t handle, uint32_t b)
CHECK:SPACING: No space is necessary after a cast
#3954: FILE: drivers/net/ark/ark_pktchkr.c:229:
+ struct ArkPktChkrInst *inst = (struct ArkPktChkrInst *) handle;
CHECK:CAMELCASE: Avoid CamelCase: <pktPayload>
#3956: FILE: drivers/net/ark/ark_pktchkr.c:231:
+ inst->cregs->pktPayload = b;
CHECK:CAMELCASE: Avoid CamelCase: <ark_pmd_pktchkr_setPktSizeMin>
#3960: FILE: drivers/net/ark/ark_pktchkr.c:235:
+ark_pmd_pktchkr_setPktSizeMin(ArkPktChkr_t handle, uint32_t x)
CHECK:SPACING: No space is necessary after a cast
#3962: FILE: drivers/net/ark/ark_pktchkr.c:237:
+ struct ArkPktChkrInst *inst = (struct ArkPktChkrInst *) handle;
CHECK:CAMELCASE: Avoid CamelCase: <pktSizeMin>
#3964: FILE: drivers/net/ark/ark_pktchkr.c:239:
+ inst->cregs->pktSizeMin = x;
CHECK:CAMELCASE: Avoid CamelCase: <ark_pmd_pktchkr_setPktSizeMax>
#3968: FILE: drivers/net/ark/ark_pktchkr.c:243:
+ark_pmd_pktchkr_setPktSizeMax(ArkPktChkr_t handle, uint32_t x)
CHECK:SPACING: No space is necessary after a cast
#3970: FILE: drivers/net/ark/ark_pktchkr.c:245:
+ struct ArkPktChkrInst *inst = (struct ArkPktChkrInst *) handle;
CHECK:CAMELCASE: Avoid CamelCase: <pktSizeMax>
#3972: FILE: drivers/net/ark/ark_pktchkr.c:247:
+ inst->cregs->pktSizeMax = x;
CHECK:CAMELCASE: Avoid CamelCase: <ark_pmd_pktchkr_setPktSizeIncr>
#3976: FILE: drivers/net/ark/ark_pktchkr.c:251:
+ark_pmd_pktchkr_setPktSizeIncr(ArkPktChkr_t handle, uint32_t x)
CHECK:SPACING: No space is necessary after a cast
#3978: FILE: drivers/net/ark/ark_pktchkr.c:253:
+ struct ArkPktChkrInst *inst = (struct ArkPktChkrInst *) handle;
CHECK:CAMELCASE: Avoid CamelCase: <pktSizeIncr>
#3980: FILE: drivers/net/ark/ark_pktchkr.c:255:
+ inst->cregs->pktSizeIncr = x;
CHECK:CAMELCASE: Avoid CamelCase: <ark_pmd_pktchkr_setNumPkts>
#3984: FILE: drivers/net/ark/ark_pktchkr.c:259:
+ark_pmd_pktchkr_setNumPkts(ArkPktChkr_t handle, uint32_t x)
CHECK:SPACING: No space is necessary after a cast
#3986: FILE: drivers/net/ark/ark_pktchkr.c:261:
+ struct ArkPktChkrInst *inst = (struct ArkPktChkrInst *) handle;
CHECK:CAMELCASE: Avoid CamelCase: <numPkts>
#3988: FILE: drivers/net/ark/ark_pktchkr.c:263:
+ inst->cregs->numPkts = x;
CHECK:CAMELCASE: Avoid CamelCase: <ark_pmd_pktchkr_setSrcMACAddr>
#3992: FILE: drivers/net/ark/ark_pktchkr.c:267:
+ark_pmd_pktchkr_setSrcMACAddr(ArkPktChkr_t handle, uint64_t macAddr)
CHECK:CAMELCASE: Avoid CamelCase: <macAddr>
#3992: FILE: drivers/net/ark/ark_pktchkr.c:267:
+ark_pmd_pktchkr_setSrcMACAddr(ArkPktChkr_t handle, uint64_t macAddr)
CHECK:SPACING: No space is necessary after a cast
#3994: FILE: drivers/net/ark/ark_pktchkr.c:269:
+ struct ArkPktChkrInst *inst = (struct ArkPktChkrInst *) handle;
CHECK:CAMELCASE: Avoid CamelCase: <srcMACAddrH>
#3996: FILE: drivers/net/ark/ark_pktchkr.c:271:
+ inst->cregs->srcMACAddrH = (macAddr >> 32) & 0xffff;
CHECK:CAMELCASE: Avoid CamelCase: <srcMACAddrL>
#3997: FILE: drivers/net/ark/ark_pktchkr.c:272:
+ inst->cregs->srcMACAddrL = macAddr & 0xffffffff;
CHECK:CAMELCASE: Avoid CamelCase: <ark_pmd_pktchkr_setDstMACAddr>
#4001: FILE: drivers/net/ark/ark_pktchkr.c:276:
+ark_pmd_pktchkr_setDstMACAddr(ArkPktChkr_t handle, uint64_t macAddr)
CHECK:SPACING: No space is necessary after a cast
#4003: FILE: drivers/net/ark/ark_pktchkr.c:278:
+ struct ArkPktChkrInst *inst = (struct ArkPktChkrInst *) handle;
CHECK:CAMELCASE: Avoid CamelCase: <dstMACAddrH>
#4005: FILE: drivers/net/ark/ark_pktchkr.c:280:
+ inst->cregs->dstMACAddrH = (macAddr >> 32) & 0xffff;
CHECK:CAMELCASE: Avoid CamelCase: <dstMACAddrL>
#4006: FILE: drivers/net/ark/ark_pktchkr.c:281:
+ inst->cregs->dstMACAddrL = macAddr & 0xffffffff;
CHECK:CAMELCASE: Avoid CamelCase: <ark_pmd_pktchkr_setEthType>
#4010: FILE: drivers/net/ark/ark_pktchkr.c:285:
+ark_pmd_pktchkr_setEthType(ArkPktChkr_t handle, uint32_t x)
CHECK:SPACING: No space is necessary after a cast
#4012: FILE: drivers/net/ark/ark_pktchkr.c:287:
+ struct ArkPktChkrInst *inst = (struct ArkPktChkrInst *) handle;
CHECK:CAMELCASE: Avoid CamelCase: <ethType>
#4014: FILE: drivers/net/ark/ark_pktchkr.c:289:
+ inst->cregs->ethType = x;
CHECK:CAMELCASE: Avoid CamelCase: <ark_pmd_pktchkr_setHdrDW>
#4018: FILE: drivers/net/ark/ark_pktchkr.c:293:
+ark_pmd_pktchkr_setHdrDW(ArkPktChkr_t handle, uint32_t *hdr)
CHECK:SPACING: No space is necessary after a cast
#4021: FILE: drivers/net/ark/ark_pktchkr.c:296:
+ struct ArkPktChkrInst *inst = (struct ArkPktChkrInst *) handle;
WARNING:BRACES: braces {} are not necessary for single statement blocks
#4023: FILE: drivers/net/ark/ark_pktchkr.c:298:
+ for (i = 0; i < 7; i++) {
+ inst->cregs->hdrDW[i] = hdr[i];
+ }
CHECK:CAMELCASE: Avoid CamelCase: <hdrDW>
#4024: FILE: drivers/net/ark/ark_pktchkr.c:299:
+ inst->cregs->hdrDW[i] = hdr[i];
CHECK:SPACING: No space is necessary after a cast
#4031: FILE: drivers/net/ark/ark_pktchkr.c:306:
+ struct ArkPktChkrInst *inst = (struct ArkPktChkrInst *) handle;
CHECK:CAMELCASE: Avoid CamelCase: <pktsRcvd>
#4033: FILE: drivers/net/ark/ark_pktchkr.c:308:
+ fprintf(stderr, "pktsRcvd = (%'u)
", inst->sregs->pktsRcvd);
CHECK:CAMELCASE: Avoid CamelCase: <PRIu64>
#4034: FILE: drivers/net/ark/ark_pktchkr.c:309:
+ fprintf(stderr, "bytesRcvd = (%'" PRIu64 ")
",
CHECK:CAMELCASE: Avoid CamelCase: <bytesRcvd>
#4035: FILE: drivers/net/ark/ark_pktchkr.c:310:
+ inst->sregs->bytesRcvd);
CHECK:CAMELCASE: Avoid CamelCase: <pktsOK>
#4036: FILE: drivers/net/ark/ark_pktchkr.c:311:
+ fprintf(stderr, "pktsOK = (%'u)
", inst->sregs->pktsOK);
CHECK:CAMELCASE: Avoid CamelCase: <pktsMismatch>
#4037: FILE: drivers/net/ark/ark_pktchkr.c:312:
+ fprintf(stderr, "pktsMismatch = (%'u)
", inst->sregs->pktsMismatch);
CHECK:CAMELCASE: Avoid CamelCase: <pktsErr>
#4038: FILE: drivers/net/ark/ark_pktchkr.c:313:
+ fprintf(stderr, "pktsErr = (%'u)
", inst->sregs->pktsErr);
CHECK:CAMELCASE: Avoid CamelCase: <firstMismatch>
#4039: FILE: drivers/net/ark/ark_pktchkr.c:314:
+ fprintf(stderr, "firstMismatch = (%'u)
", inst->sregs->firstMismatch);
CHECK:CAMELCASE: Avoid CamelCase: <resyncEvents>
#4040: FILE: drivers/net/ark/ark_pktchkr.c:315:
+ fprintf(stderr, "resyncEvents = (%'u)
", inst->sregs->resyncEvents);
CHECK:CAMELCASE: Avoid CamelCase: <pktsMissing>
#4041: FILE: drivers/net/ark/ark_pktchkr.c:316:
+ fprintf(stderr, "pktsMissing = (%'u)
", inst->sregs->pktsMissing);
CHECK:CAMELCASE: Avoid CamelCase: <minLatency>
#4042: FILE: drivers/net/ark/ark_pktchkr.c:317:
+ fprintf(stderr, "minLatency = (%'u)
", inst->sregs->minLatency);
CHECK:CAMELCASE: Avoid CamelCase: <maxLatency>
#4043: FILE: drivers/net/ark/ark_pktchkr.c:318:
+ fprintf(stderr, "maxLatency = (%'u)
", inst->sregs->maxLatency);
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#4049: FILE: drivers/net/ark/ark_pktchkr.c:324:
+ unsigned i;
WARNING:BRACES: braces {} are not necessary for single statement blocks
#4052: FILE: drivers/net/ark/ark_pktchkr.c:327:
+ if (strcmp(id, toptions[i].opt) == 0) {
+ return &toptions[i];
+ }
WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#4091: FILE: drivers/net/ark/ark_pktchkr.c:366:
+ const char toks[] = "=
\v\f\r";
CHECK:CAMELCASE: Avoid CamelCase: <parseIPV4string>
#4104: FILE: drivers/net/ark/ark_pktchkr.c:379:
+static int32_t parseIPV4string(char const *ipAddress);
CHECK:CAMELCASE: Avoid CamelCase: <ipAddress>
#4104: FILE: drivers/net/ark/ark_pktchkr.c:379:
+static int32_t parseIPV4string(char const *ipAddress);
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#4110: FILE: drivers/net/ark/ark_pktchkr.c:385:
+ if (4 != sscanf(ipAddress, "%u.%u.%u.%u", &ip[0], &ip[1], &ip[2], &ip[3]))
CHECK:CAMELCASE: Avoid CamelCase: <dstIp>
#4119: FILE: drivers/net/ark/ark_pktchkr.c:394:
+ int32_t dstIp = parseIPV4string(OPTIONS("dstIP")->v.Str);
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#4122: FILE: drivers/net/ark/ark_pktchkr.c:397:
+ if (!OPTIONS("stop")->v.Bool && OPTIONS("configure")->v.Bool) {
+
CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#4170: FILE: drivers/net/ark/ark_pktchkr.c:445:
+
+}
CHECK:CAMELCASE: Avoid CamelCase: <ArkPktDirInst>
#4338: FILE: drivers/net/ark/ark_pktdir.c:42:
+ struct ArkPktDirInst *inst =
CHECK:SPACING: No space is necessary after a cast
#4340: FILE: drivers/net/ark/ark_pktdir.c:44:
+ inst->regs = (struct ArkPktDirRegs *) base;
CHECK:CAMELCASE: Avoid CamelCase: <ArkPktDirRegs>
#4340: FILE: drivers/net/ark/ark_pktdir.c:44:
+ inst->regs = (struct ArkPktDirRegs *) base;
CHECK:SPACING: No space is necessary after a cast
#4348: FILE: drivers/net/ark/ark_pktdir.c:52:
+ struct ArkPktDirInst *inst = (struct ArkPktDirInst *) handle;
CHECK:SPACING: No space is necessary after a cast
#4356: FILE: drivers/net/ark/ark_pktdir.c:60:
+ struct ArkPktDirInst *inst = (struct ArkPktDirInst *) handle;
CHECK:SPACING: No space is necessary after a cast
#4364: FILE: drivers/net/ark/ark_pktdir.c:68:
+ struct ArkPktDirInst *inst = (struct ArkPktDirInst *) handle;
CHECK:CAMELCASE: Avoid CamelCase: <ark_pmd_pktdir_stallCnt>
#4370: FILE: drivers/net/ark/ark_pktdir.c:74:
+ark_pmd_pktdir_stallCnt(ArkPktDir_t handle)
CHECK:SPACING: No space is necessary after a cast
#4372: FILE: drivers/net/ark/ark_pktdir.c:76:
+ struct ArkPktDirInst *inst = (struct ArkPktDirInst *) handle;
CHECK:CAMELCASE: Avoid CamelCase: <stallCnt>
#4374: FILE: drivers/net/ark/ark_pktdir.c:78:
+ return inst->regs->stallCnt;
CHECK:CAMELCASE: Avoid CamelCase: <ArkPktGenInst>
#4560: FILE: drivers/net/ark/ark_pktgen.c:105:
+ struct ArkPktGenInst *inst =
CHECK:SPACING: No space is necessary after a cast
#4562: FILE: drivers/net/ark/ark_pktgen.c:107:
+ inst->regs = (struct ArkPktGenRegs *) adr;
CHECK:CAMELCASE: Avoid CamelCase: <ArkPktGenRegs>
#4562: FILE: drivers/net/ark/ark_pktgen.c:107:
+ inst->regs = (struct ArkPktGenRegs *) adr;
CHECK:SPACING: No space is necessary after a cast
#4577: FILE: drivers/net/ark/ark_pktgen.c:122:
+ struct ArkPktGenInst *inst = (struct ArkPktGenInst *) handle;
CHECK:SPACING: No space is necessary after a cast
#4585: FILE: drivers/net/ark/ark_pktgen.c:130:
+ struct ArkPktGenInst *inst = (struct ArkPktGenInst *) handle;
CHECK:SPACING: No space is necessary after a cast
#4594: FILE: drivers/net/ark/ark_pktgen.c:139:
+ struct ArkPktGenInst *inst = (struct ArkPktGenInst *) handle;
CHECK:SPACING: No space is necessary after a cast
#4612: FILE: drivers/net/ark/ark_pktgen.c:157:
+ struct ArkPktGenInst *inst = (struct ArkPktGenInst *) handle;
CHECK:CAMELCASE: Avoid CamelCase: <ark_pmd_pktgen_isRunning>
#4614: FILE: drivers/net/ark/ark_pktgen.c:159:
+ if (!ark_pmd_pktgen_isRunning(handle) && !ark_pmd_pktgen_paused(handle)) {
CHECK:CAMELCASE: Avoid CamelCase: <ark_pmd_pktgen_txDone>
#4632: FILE: drivers/net/ark/ark_pktgen.c:177:
+ark_pmd_pktgen_txDone(ArkPktGen_t handle)
CHECK:SPACING: No space is necessary after a cast
#4634: FILE: drivers/net/ark/ark_pktgen.c:179:
+ struct ArkPktGenInst *inst = (struct ArkPktGenInst *) handle;
CHECK:SPACING: No space is necessary after a cast
#4643: FILE: drivers/net/ark/ark_pktgen.c:188:
+ struct ArkPktGenInst *inst = (struct ArkPktGenInst *) handle;
CHECK:CAMELCASE: Avoid CamelCase: <ark_pmd_pktgen_isGenForever>
#4650: FILE: drivers/net/ark/ark_pktgen.c:195:
+ark_pmd_pktgen_isGenForever(ArkPktGen_t handle)
CHECK:SPACING: No space is necessary after a cast
#4652: FILE: drivers/net/ark/ark_pktgen.c:197:
+ struct ArkPktGenInst *inst = (struct ArkPktGenInst *) handle;
CHECK:CAMELCASE: Avoid CamelCase: <ark_pmd_pktgen_waitDone>
#4659: FILE: drivers/net/ark/ark_pktgen.c:204:
+ark_pmd_pktgen_waitDone(ArkPktGen_t handle)
CHECK:SPACING: No space is necessary after a cast
#4661: FILE: drivers/net/ark/ark_pktgen.c:206:
+ struct ArkPktGenInst *inst = (struct ArkPktGenInst *) handle;
WARNING:BRACES: braces {} are not necessary for single statement blocks
#4663: FILE: drivers/net/ark/ark_pktgen.c:208:
+ if (ark_pmd_pktgen_isGenForever(handle)) {
+ PMD_DRV_LOG(ERR, "waitDone will not terminate because genForever=1
");
+ }
CHECK:CAMELCASE: Avoid CamelCase: <ark_pmd_pktgen_getPktsSent>
#4678: FILE: drivers/net/ark/ark_pktgen.c:223:
+ark_pmd_pktgen_getPktsSent(ArkPktGen_t handle)
CHECK:SPACING: No space is necessary after a cast
#4680: FILE: drivers/net/ark/ark_pktgen.c:225:
+ struct ArkPktGenInst *inst = (struct ArkPktGenInst *) handle;
CHECK:CAMELCASE: Avoid CamelCase: <ark_pmd_pktgen_setPayloadByte>
#4686: FILE: drivers/net/ark/ark_pktgen.c:231:
+ark_pmd_pktgen_setPayloadByte(ArkPktGen_t handle, uint32_t b)
CHECK:SPACING: No space is necessary after a cast
#4688: FILE: drivers/net/ark/ark_pktgen.c:233:
+ struct ArkPktGenInst *inst = (struct ArkPktGenInst *) handle;
CHECK:CAMELCASE: Avoid CamelCase: <ark_pmd_pktgen_setPktSpacing>
#4694: FILE: drivers/net/ark/ark_pktgen.c:239:
+ark_pmd_pktgen_setPktSpacing(ArkPktGen_t handle, uint32_t x)
CHECK:SPACING: No space is necessary after a cast
#4696: FILE: drivers/net/ark/ark_pktgen.c:241:
+ struct ArkPktGenInst *inst = (struct ArkPktGenInst *) handle;
CHECK:CAMELCASE: Avoid CamelCase: <pktSpacing>
#4698: FILE: drivers/net/ark/ark_pktgen.c:243:
+ inst->regs->pktSpacing = x;
CHECK:CAMELCASE: Avoid CamelCase: <ark_pmd_pktgen_setPktSizeMin>
#4702: FILE: drivers/net/ark/ark_pktgen.c:247:
+ark_pmd_pktgen_setPktSizeMin(ArkPktGen_t handle, uint32_t x)
CHECK:SPACING: No space is necessary after a cast
#4704: FILE: drivers/net/ark/ark_pktgen.c:249:
+ struct ArkPktGenInst *inst = (struct ArkPktGenInst *) handle;
CHECK:CAMELCASE: Avoid CamelCase: <ark_pmd_pktgen_setPktSizeMax>
#4710: FILE: drivers/net/ark/ark_pktgen.c:255:
+ark_pmd_pktgen_setPktSizeMax(ArkPktGen_t handle, uint32_t x)
CHECK:SPACING: No space is necessary after a cast
#4712: FILE: drivers/net/ark/ark_pktgen.c:257:
+ struct ArkPktGenInst *inst = (struct ArkPktGenInst *) handle;
CHECK:CAMELCASE: Avoid CamelCase: <ark_pmd_pktgen_setPktSizeIncr>
#4718: FILE: drivers/net/ark/ark_pktgen.c:263:
+ark_pmd_pktgen_setPktSizeIncr(ArkPktGen_t handle, uint32_t x)
CHECK:SPACING: No space is necessary after a cast
#4720: FILE: drivers/net/ark/ark_pktgen.c:265:
+ struct ArkPktGenInst *inst = (struct ArkPktGenInst *) handle;
CHECK:CAMELCASE: Avoid CamelCase: <ark_pmd_pktgen_setNumPkts>
#4726: FILE: drivers/net/ark/ark_pktgen.c:271:
+ark_pmd_pktgen_setNumPkts(ArkPktGen_t handle, uint32_t x)
CHECK:SPACING: No space is necessary after a cast
#4728: FILE: drivers/net/ark/ark_pktgen.c:273:
+ struct ArkPktGenInst *inst = (struct ArkPktGenInst *) handle;
CHECK:CAMELCASE: Avoid CamelCase: <ark_pmd_pktgen_setSrcMACAddr>
#4734: FILE: drivers/net/ark/ark_pktgen.c:279:
+ark_pmd_pktgen_setSrcMACAddr(ArkPktGen_t handle, uint64_t macAddr)
CHECK:SPACING: No space is necessary after a cast
#4736: FILE: drivers/net/ark/ark_pktgen.c:281:
+ struct ArkPktGenInst *inst = (struct ArkPktGenInst *) handle;
CHECK:CAMELCASE: Avoid CamelCase: <ark_pmd_pktgen_setDstMACAddr>
#4743: FILE: drivers/net/ark/ark_pktgen.c:288:
+ark_pmd_pktgen_setDstMACAddr(ArkPktGen_t handle, uint64_t macAddr)
CHECK:SPACING: No space is necessary after a cast
#4745: FILE: drivers/net/ark/ark_pktgen.c:290:
+ struct ArkPktGenInst *inst = (struct ArkPktGenInst *) handle;
CHECK:CAMELCASE: Avoid CamelCase: <ark_pmd_pktgen_setEthType>
#4752: FILE: drivers/net/ark/ark_pktgen.c:297:
+ark_pmd_pktgen_setEthType(ArkPktGen_t handle, uint32_t x)
CHECK:SPACING: No space is necessary after a cast
#4754: FILE: drivers/net/ark/ark_pktgen.c:299:
+ struct ArkPktGenInst *inst = (struct ArkPktGenInst *) handle;
CHECK:CAMELCASE: Avoid CamelCase: <ark_pmd_pktgen_setHdrDW>
#4760: FILE: drivers/net/ark/ark_pktgen.c:305:
+ark_pmd_pktgen_setHdrDW(ArkPktGen_t handle, uint32_t *hdr)
CHECK:SPACING: No space is necessary after a cast
#4763: FILE: drivers/net/ark/ark_pktgen.c:308:
+ struct ArkPktGenInst *inst = (struct ArkPktGenInst *) handle;
CHECK:CAMELCASE: Avoid CamelCase: <ark_pmd_pktgen_setStartOffset>
#4770: FILE: drivers/net/ark/ark_pktgen.c:315:
+ark_pmd_pktgen_setStartOffset(ArkPktGen_t handle, uint32_t x)
CHECK:SPACING: No space is necessary after a cast
#4772: FILE: drivers/net/ark/ark_pktgen.c:317:
+ struct ArkPktGenInst *inst = (struct ArkPktGenInst *) handle;
CHECK:CAMELCASE: Avoid CamelCase: <startOffset>
#4774: FILE: drivers/net/ark/ark_pktgen.c:319:
+ inst->regs->startOffset = x;
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#4780: FILE: drivers/net/ark/ark_pktgen.c:325:
+ unsigned i;
CHECK:CAMELCASE: Avoid CamelCase: <pmd_setArg>
#4794: FILE: drivers/net/ark/ark_pktgen.c:339:
+static int pmd_setArg(char *arg, char *val);
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#4844: FILE: drivers/net/ark/ark_pktgen.c:389:
+ if (4 != sscanf(ipAddress, "%u.%u.%u.%u", &ip[0], &ip[1], &ip[2], &ip[3]))
CHECK:CAMELCASE: Avoid CamelCase: <ark_pmd_pktgen_setPktCtrl>
#4850: FILE: drivers/net/ark/ark_pktgen.c:395:
+ark_pmd_pktgen_setPktCtrl(ArkPktGen_t handle, uint32_t genForever,
CHECK:CAMELCASE: Avoid CamelCase: <enSlavedStart>
#4851: FILE: drivers/net/ark/ark_pktgen.c:396:
+ uint32_t enSlavedStart, uint32_t varyLength, uint32_t incrPayload,
CHECK:SPACING: No space is necessary after a cast
#4856: FILE: drivers/net/ark/ark_pktgen.c:401:
+ struct ArkPktGenInst *inst = (struct ArkPktGenInst *) handle;
CHECK:CAMELCASE: Avoid CamelCase: <bytesPerCycle>
#4865: FILE: drivers/net/ark/ark_pktgen.c:410:
+ inst->regs->bytesPerCycle = OPTIONS("bytesPerCycle")->v.Int;
CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#4880: FILE: drivers/net/ark/ark_pktgen.c:425:
+ if (!OPTIONS("pause")->v.Bool && (!OPTIONS("reset")->v.Bool
+ && (OPTIONS("configure")->v.Bool))) {
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#4881: FILE: drivers/net/ark/ark_pktgen.c:426:
+ && (OPTIONS("configure")->v.Bool))) {
+
WARNING:FUNCTION_ARGUMENTS: function definition argument 'void *' should also have an identifier name
#5019: FILE: drivers/net/ark/ark_pktgen.h:81:
+ArkPktGen_t ark_pmd_pktgen_init(void *, int ord, int l2_mode);
CHECK:CAMELCASE: Avoid CamelCase: <statsClear>
#5093: FILE: drivers/net/ark/ark_rqp.c:43:
+ rqp->statsClear = 1;
CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#5099: FILE: drivers/net/ark/ark_rqp.c:49:
+
+}
CHECK:CAMELCASE: Avoid CamelCase: <errCountOther>
#5105: FILE: drivers/net/ark/ark_rqp.c:55:
+ if (rqp->errCountOther != 0)
CHECK:CAMELCASE: Avoid CamelCase: <errCnt>
#5112: FILE: drivers/net/ark/ark_rqp.c:62:
+ "Error Count", rqp->errCnt,
CHECK:CAMELCASE: Avoid CamelCase: <stallPS>
#5124: FILE: drivers/net/ark/ark_rqp.c:74:
+ "stallPS", rqp->stallPS,
CHECK:CAMELCASE: Avoid CamelCase: <stallPSMin>
#5125: FILE: drivers/net/ark/ark_rqp.c:75:
+ "stallPS Min", rqp->stallPSMin,
CHECK:CAMELCASE: Avoid CamelCase: <stallPSMax>
#5126: FILE: drivers/net/ark/ark_rqp.c:76:
+ "stallPS Max", rqp->stallPSMax,
CHECK:CAMELCASE: Avoid CamelCase: <reqPS>
#5127: FILE: drivers/net/ark/ark_rqp.c:77:
+ "reqPS", rqp->reqPS,
CHECK:CAMELCASE: Avoid CamelCase: <reqPSMin>
#5128: FILE: drivers/net/ark/ark_rqp.c:78:
+ "reqPS Min", rqp->reqPSMin,
CHECK:CAMELCASE: Avoid CamelCase: <reqPSMax>
#5129: FILE: drivers/net/ark/ark_rqp.c:79:
+ "reqPS Max", rqp->reqPSMax,
CHECK:CAMELCASE: Avoid CamelCase: <reqDWPS>
#5130: FILE: drivers/net/ark/ark_rqp.c:80:
+ "reqDWPS", rqp->reqDWPS,
CHECK:CAMELCASE: Avoid CamelCase: <reqDWPSMin>
#5131: FILE: drivers/net/ark/ark_rqp.c:81:
+ "reqDWPS Min", rqp->reqDWPSMin,
CHECK:CAMELCASE: Avoid CamelCase: <reqDWPSMax>
#5132: FILE: drivers/net/ark/ark_rqp.c:82:
+ "reqDWPS Max", rqp->reqDWPSMax,
CHECK:CAMELCASE: Avoid CamelCase: <cplPS>
#5133: FILE: drivers/net/ark/ark_rqp.c:83:
+ "cplPS", rqp->cplPS,
CHECK:CAMELCASE: Avoid CamelCase: <cplPSMin>
#5134: FILE: drivers/net/ark/ark_rqp.c:84:
+ "cplPS Min", rqp->cplPSMin,
CHECK:CAMELCASE: Avoid CamelCase: <cplPSMax>
#5135: FILE: drivers/net/ark/ark_rqp.c:85:
+ "cplPS Max", rqp->cplPSMax,
CHECK:CAMELCASE: Avoid CamelCase: <cplDWPS>
#5136: FILE: drivers/net/ark/ark_rqp.c:86:
+ "cplDWPS", rqp->cplDWPS,
CHECK:CAMELCASE: Avoid CamelCase: <cplDWPSMin>
#5137: FILE: drivers/net/ark/ark_rqp.c:87:
+ "cplDWPS Min", rqp->cplDWPSMin,
CHECK:CAMELCASE: Avoid CamelCase: <cplDWPSMax>
#5138: FILE: drivers/net/ark/ark_rqp.c:88:
+ "cplDWPS Max", rqp->cplDWPSMax,
CHECK:CAMELCASE: Avoid CamelCase: <writeInterval>
#5347: FILE: drivers/net/ark/ark_udm.c:117:
+ udm->rt_cfg.writeInterval = write_interval_ns / 4;
CHECK:CAMELCASE: Avoid CamelCase: <hwProdAddr>
#5353: FILE: drivers/net/ark/ark_udm.c:123:
+ udm->rt_cfg.hwProdAddr = addr;
CHECK:CAMELCASE: Avoid CamelCase: <qPktDrop>
#5365: FILE: drivers/net/ark/ark_udm.c:135:
+ return udm->qstats.qPktDrop;
CHECK:CAMELCASE: Avoid CamelCase: <qByteCount>
#5371: FILE: drivers/net/ark/ark_udm.c:141:
+ return udm->qstats.qByteCount;
CHECK:CAMELCASE: Avoid CamelCase: <qFFPacketCount>
#5377: FILE: drivers/net/ark/ark_udm.c:147:
+ return udm->qstats.qFFPacketCount;
CHECK:CAMELCASE: Avoid CamelCase: <rxPacketCount>
#5384: FILE: drivers/net/ark/ark_udm.c:154:
+ FMT_SU64 "
", msg, "Pkts Received", udm->stats.rxPacketCount,
CHECK:CAMELCASE: Avoid CamelCase: <rxSentPackets>
#5385: FILE: drivers/net/ark/ark_udm.c:155:
+ "Pkts Finalized", udm->stats.rxSentPackets, "Pkts Dropped",
CHECK:CAMELCASE: Avoid CamelCase: <rxByteCount>
#5386: FILE: drivers/net/ark/ark_udm.c:156:
+ udm->tlp.pkt_drop, "Bytes Count", udm->stats.rxByteCount, "MBuf Count",
CHECK:CAMELCASE: Avoid CamelCase: <rxMBufCount>
#5387: FILE: drivers/net/ark/ark_udm.c:157:
+ udm->stats.rxMBufCount);
CHECK:CAMELCASE: Avoid CamelCase: <qPacketCount>
#5399: FILE: drivers/net/ark/ark_udm.c:169:
+ "Pkts Received", udm->qstats.qPacketCount,
CHECK:CAMELCASE: Avoid CamelCase: <qMbufCount>
#5403: FILE: drivers/net/ark/ark_udm.c:173:
+ "MBuf Count", udm->qstats.qMbufCount);
CHECK:SPACING: No space is necessary after a cast
#5420: FILE: drivers/net/ark/ark_udm.c:190:
+ "hwProdAddr", (void *) udm->rt_cfg.hwProdAddr,
CHECK:CAMELCASE: Avoid CamelCase: <qEnable>
#5450: FILE: drivers/net/ark/ark_udm.c:220:
+ udm->qstats.qEnable = enable ? 1 : 0;
CHECK:CAMELCASE: Avoid CamelCase: <cycleCount>
#5508: FILE: drivers/net/ark/ark_udm.h:51:
+ volatile uint32_t cycleCount;
CHECK:CAMELCASE: Avoid CamelCase: <ArkUdmCommands>
#5524: FILE: drivers/net/ark/ark_udm.h:67:
+} ArkUdmCommands;
total: 0 errors, 83 warnings, 5379 lines checked
parent reply other threads:[~2017-03-19 10:03 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1489785317-15185-1-git-send-email-ed.czeck@atomicrules.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170319100348.55AC75689@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=ed.czeck@atomicrules.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).