From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 5B3625320; Sun, 19 Mar 2017 11:10:34 +0100 (CET)
In-Reply-To: <1489820786-14226-17-git-send-email-rasesh.mody@cavium.com>
References: <1489820786-14226-17-git-send-email-rasesh.mody@cavium.com>
To: test-report@dpdk.org
Cc: "Mody, Rasesh" <Rasesh.Mody@cavium.com>
Message-Id: <20170319101034.5B3625320@dpdk.org>
Date: Sun, 19 Mar 2017 11:10:34 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw21965 [PATCH v2 16/61]
	net/qede/base: read card personality via MFW commands
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 19 Mar 2017 10:10:34 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/21965

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev' - possible side-effects?
#44: FILE: drivers/net/qede/base/ecore.h:332:
+#define ECORE_IS_RDMA_PERSONALITY(dev)			    \
+	((dev)->hw_info.personality == ECORE_PCI_ETH_ROCE ||  \
+	 (dev)->hw_info.personality == ECORE_PCI_ETH_IWARP || \
+	 (dev)->hw_info.personality == ECORE_PCI_ETH_RDMA)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev' - possible side-effects?
#48: FILE: drivers/net/qede/base/ecore.h:336:
+#define ECORE_IS_ROCE_PERSONALITY(dev)			   \
+	((dev)->hw_info.personality == ECORE_PCI_ETH_ROCE || \
+	 (dev)->hw_info.personality == ECORE_PCI_ETH_RDMA)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev' - possible side-effects?
#51: FILE: drivers/net/qede/base/ecore.h:339:
+#define ECORE_IS_IWARP_PERSONALITY(dev)			    \
+	((dev)->hw_info.personality == ECORE_PCI_ETH_IWARP || \
+	 (dev)->hw_info.personality == ECORE_PCI_ETH_RDMA)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev' - possible side-effects?
#54: FILE: drivers/net/qede/base/ecore.h:342:
+#define ECORE_IS_L2_PERSONALITY(dev)		      \
+	((dev)->hw_info.personality == ECORE_PCI_ETH || \
+	 ECORE_IS_RDMA_PERSONALITY(dev))

total: 0 errors, 0 warnings, 4 checks, 156 lines checked