From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 35B72CFA8; Sun, 19 Mar 2017 11:10:44 +0100 (CET)
In-Reply-To: <1489820786-14226-61-git-send-email-rasesh.mody@cavium.com>
References: <1489820786-14226-61-git-send-email-rasesh.mody@cavium.com>
To: test-report@dpdk.org
Cc: "Mody, Rasesh" <Rasesh.Mody@cavium.com>
Message-Id: <20170319101044.35B72CFA8@dpdk.org>
Date: Sun, 19 Mar 2017 11:10:44 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw21976 [PATCH v2 60/61] net/qede: add
	ntuple and flow director filter support
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 19 Mar 2017 10:10:44 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/21976

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'flow_type' - possible side-effects?
#270: FILE: drivers/net/qede/qede_fdir.c:33:
+#define QEDE_VALID_FLOW(flow_type) \
+	((flow_type) == RTE_ETH_FLOW_FRAG_IPV4		|| \
+	(flow_type) == RTE_ETH_FLOW_NONFRAG_IPV4_TCP	|| \
+	(flow_type) == RTE_ETH_FLOW_NONFRAG_IPV4_UDP	|| \
+	(flow_type) == RTE_ETH_FLOW_FRAG_IPV6		|| \
+	(flow_type) == RTE_ETH_FLOW_NONFRAG_IPV6_TCP	|| \
+	(flow_type) == RTE_ETH_FLOW_NONFRAG_IPV6_UDP)

CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv4>
#545: FILE: drivers/net/qede/qede_fdir.c:308:
+		*ether_type = rte_cpu_to_be_16(ETHER_TYPE_IPv4);

CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv6>
#564: FILE: drivers/net/qede/qede_fdir.c:327:
+		*ether_type = rte_cpu_to_be_16(ETHER_TYPE_IPv6);

total: 0 errors, 0 warnings, 3 checks, 696 lines checked