From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| pw22002 [PATCH v2 04/13] net/sfc: factor out libefx-based Rx datapath
Date: Mon, 20 Mar 2017 21:42:04 +0100 (CET) [thread overview]
Message-ID: <20170320204204.4259DCFBA@dpdk.org> (raw)
In-Reply-To: <1490004919-2177-5-git-send-email-arybchenko@solarflare.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/22002
_coding style issues_
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EEXIST)
#190: FILE: drivers/net/sfc/sfc_dp.c:92:
+ return EEXIST;
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#246: FILE: drivers/net/sfc/sfc_dp.h:44:
+#define SFC_DIV_ROUND_UP(a, b) \
+ __extension__ ({ \
+ typeof(a) _a = (a); \
+ typeof(b) _b = (b); \
+ \
+ (_a + (_b - 1)) / _b; \
+ })
CHECK:CAMELCASE: Avoid CamelCase: <PRIu16>
#286: FILE: drivers/net/sfc/sfc_dp.h:84:
+ " #%" PRIu16 ".%" PRIu16 ": " \
ERROR:SPACING: space required after that ',' (ctx:VxB)
#287: FILE: drivers/net/sfc/sfc_dp.h:85:
+ RTE_FMT_HEAD(__VA_ARGS__,) "
", \
^
ERROR:SPACING: space required after that ',' (ctx:VxB)
#292: FILE: drivers/net/sfc/sfc_dp.h:90:
+ RTE_FMT_TAIL(__VA_ARGS__,))); \
^
CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#1180: FILE: drivers/net/sfc/sfc_rx.c:437:
+ rxq->pending = rxq->completed = rxq->added = rxq->pushed = 0;
total: 3 errors, 1 warnings, 2 checks, 1385 lines checked
parent reply other threads:[~2017-03-20 20:42 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1490004919-2177-5-git-send-email-arybchenko@solarflare.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170320204204.4259DCFBA@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=arybchenko@solarflare.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).