* [dpdk-test-report] |WARNING| pw22002 [PATCH v2 04/13] net/sfc: factor out libefx-based Rx datapath
[not found] <1490004919-2177-5-git-send-email-arybchenko@solarflare.com>
@ 2017-03-20 20:42 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2017-03-20 20:42 UTC (permalink / raw)
To: test-report; +Cc: Andrew Rybchenko
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/22002
_coding style issues_
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EEXIST)
#190: FILE: drivers/net/sfc/sfc_dp.c:92:
+ return EEXIST;
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#246: FILE: drivers/net/sfc/sfc_dp.h:44:
+#define SFC_DIV_ROUND_UP(a, b) \
+ __extension__ ({ \
+ typeof(a) _a = (a); \
+ typeof(b) _b = (b); \
+ \
+ (_a + (_b - 1)) / _b; \
+ })
CHECK:CAMELCASE: Avoid CamelCase: <PRIu16>
#286: FILE: drivers/net/sfc/sfc_dp.h:84:
+ " #%" PRIu16 ".%" PRIu16 ": " \
ERROR:SPACING: space required after that ',' (ctx:VxB)
#287: FILE: drivers/net/sfc/sfc_dp.h:85:
+ RTE_FMT_HEAD(__VA_ARGS__,) "
", \
^
ERROR:SPACING: space required after that ',' (ctx:VxB)
#292: FILE: drivers/net/sfc/sfc_dp.h:90:
+ RTE_FMT_TAIL(__VA_ARGS__,))); \
^
CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#1180: FILE: drivers/net/sfc/sfc_rx.c:437:
+ rxq->pending = rxq->completed = rxq->added = rxq->pushed = 0;
total: 3 errors, 1 warnings, 2 checks, 1385 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-03-20 20:42 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1490004919-2177-5-git-send-email-arybchenko@solarflare.com>
2017-03-20 20:42 ` [dpdk-test-report] |WARNING| pw22002 [PATCH v2 04/13] net/sfc: factor out libefx-based Rx datapath checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).