From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 4259DCFBA; Mon, 20 Mar 2017 21:42:04 +0100 (CET)
In-Reply-To: <1490004919-2177-5-git-send-email-arybchenko@solarflare.com>
References: <1490004919-2177-5-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20170320204204.4259DCFBA@dpdk.org>
Date: Mon, 20 Mar 2017 21:42:04 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw22002 [PATCH v2 04/13] net/sfc:
	factor out libefx-based Rx datapath
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Mar 2017 20:42:04 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/22002

_coding style issues_


WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EEXIST)
#190: FILE: drivers/net/sfc/sfc_dp.c:92:
+		return EEXIST;

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#246: FILE: drivers/net/sfc/sfc_dp.h:44:
+#define SFC_DIV_ROUND_UP(a, b) \
+	__extension__ ({		\
+		typeof(a) _a = (a);	\
+		typeof(b) _b = (b);	\
+					\
+		(_a + (_b - 1)) / _b;	\
+	})

CHECK:CAMELCASE: Avoid CamelCase: <PRIu16>
#286: FILE: drivers/net/sfc/sfc_dp.h:84:
+				" #%" PRIu16 ".%" PRIu16 ": "		\

ERROR:SPACING: space required after that ',' (ctx:VxB)
#287: FILE: drivers/net/sfc/sfc_dp.h:85:
+				RTE_FMT_HEAD(__VA_ARGS__,) "
",	\
 				                        ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#292: FILE: drivers/net/sfc/sfc_dp.h:90:
+				RTE_FMT_TAIL(__VA_ARGS__,)));		\
 				                        ^

CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#1180: FILE: drivers/net/sfc/sfc_rx.c:437:
+	rxq->pending = rxq->completed = rxq->added = rxq->pushed = 0;

total: 3 errors, 1 warnings, 2 checks, 1385 lines checked