From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id B7874F8C0; Sun, 26 Mar 2017 23:58:52 +0200 (CEST) In-Reply-To: <453363AE6316CC428D594009B784F9050335F139@SZXEMI508-MBS.china.huawei.com> References: <453363AE6316CC428D594009B784F9050335F139@SZXEMI508-MBS.china.huawei.com> To: test-report@dpdk.org Cc: caihe Message-Id: <20170326215852.B7874F8C0@dpdk.org> Date: Sun, 26 Mar 2017 23:58:52 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw22419 [PATCH 1/1] net/i40e: check return value of rte_zmalloc X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Mar 2017 21:58:53 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/22419 _coding style issues_ WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #18: There is a bug without check the return value of alloc memory in function i40evf_add_del_all_mac_addr, ERROR:CODE_INDENT: code indent should use tabs where possible #32: FILE: drivers/net/i40e/i40e_ethdev_vf.c:2017: + if (!list) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #32: FILE: drivers/net/i40e/i40e_ethdev_vf.c:2017: + if (!list) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (15, 23) #32: FILE: drivers/net/i40e/i40e_ethdev_vf.c:2017: + if (!list) { + PMD_DRV_LOG(ERR, "fail to alloc memory, abort execute command %s", ERROR:CODE_INDENT: code indent should use tabs where possible #33: FILE: drivers/net/i40e/i40e_ethdev_vf.c:2018: + PMD_DRV_LOG(ERR, "fail to alloc memory, abort execute command %s",$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #33: FILE: drivers/net/i40e/i40e_ethdev_vf.c:2018: + PMD_DRV_LOG(ERR, "fail to alloc memory, abort execute command %s",$ ERROR:CODE_INDENT: code indent should use tabs where possible #34: FILE: drivers/net/i40e/i40e_ethdev_vf.c:2019: + add ? "OP_ADD_ETHER_ADDRESS" : "OP_DEL_ETHER_ADDRESS");$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #34: FILE: drivers/net/i40e/i40e_ethdev_vf.c:2019: + add ? "OP_ADD_ETHER_ADDRESS" : "OP_DEL_ETHER_ADDRESS");$ ERROR:CODE_INDENT: code indent should use tabs where possible #35: FILE: drivers/net/i40e/i40e_ethdev_vf.c:2020: + return;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #35: FILE: drivers/net/i40e/i40e_ethdev_vf.c:2020: + return;$ ERROR:CODE_INDENT: code indent should use tabs where possible #36: FILE: drivers/net/i40e/i40e_ethdev_vf.c:2021: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #36: FILE: drivers/net/i40e/i40e_ethdev_vf.c:2021: + }$ ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s) total: 6 errors, 7 warnings, 0 checks, 11 lines checked