From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: caihe <caihe@huawei.com>
Subject: [dpdk-test-report] |WARNING| pw22420 [PATCH 1/1] net/cxgbe: check return value of malloc
Date: Sun, 26 Mar 2017 23:58:53 +0200 (CEST) [thread overview]
Message-ID: <20170326215853.2F2E4F949@dpdk.org> (raw)
In-Reply-To: <453363AE6316CC428D594009B784F9050335F159@SZXEMI508-MBS.china.huawei.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/22420
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#18:
There is a bug without check the return value of alloc memory in function t4_wr_mbox_meat_timeout, if we should fix it as below:
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#31: FILE: drivers/net/cxgbe/base/t4_hw.c:362:
+ if (!temp) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#31: FILE: drivers/net/cxgbe/base/t4_hw.c:362:
+ if (!temp) {
+ return -ENOMEM;
ERROR:CODE_INDENT: code indent should use tabs where possible
#32: FILE: drivers/net/cxgbe/base/t4_hw.c:363:
+ return -ENOMEM;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#32: FILE: drivers/net/cxgbe/base/t4_hw.c:363:
+ return -ENOMEM;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#33: FILE: drivers/net/cxgbe/base/t4_hw.c:364:
+ }$
ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 2 errors, 5 warnings, 0 checks, 10 lines checked
parent reply other threads:[~2017-03-26 21:58 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <453363AE6316CC428D594009B784F9050335F159@SZXEMI508-MBS.china.huawei.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170326215853.2F2E4F949@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=caihe@huawei.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).