* [dpdk-test-report] |WARNING| pw22420 [PATCH 1/1] net/cxgbe: check return value of malloc
[not found] <453363AE6316CC428D594009B784F9050335F159@SZXEMI508-MBS.china.huawei.com>
@ 2017-03-26 21:58 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2017-03-26 21:58 UTC (permalink / raw)
To: test-report; +Cc: caihe
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/22420
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#18:
There is a bug without check the return value of alloc memory in function t4_wr_mbox_meat_timeout, if we should fix it as below:
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#31: FILE: drivers/net/cxgbe/base/t4_hw.c:362:
+ if (!temp) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#31: FILE: drivers/net/cxgbe/base/t4_hw.c:362:
+ if (!temp) {
+ return -ENOMEM;
ERROR:CODE_INDENT: code indent should use tabs where possible
#32: FILE: drivers/net/cxgbe/base/t4_hw.c:363:
+ return -ENOMEM;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#32: FILE: drivers/net/cxgbe/base/t4_hw.c:363:
+ return -ENOMEM;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#33: FILE: drivers/net/cxgbe/base/t4_hw.c:364:
+ }$
ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 2 errors, 5 warnings, 0 checks, 10 lines checked
^ permalink raw reply [flat|nested] only message in thread