automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: "Mody, Rasesh" <Rasesh.Mody@cavium.com>
Subject: [dpdk-test-report] |WARNING| pw22826 [PATCH v5 60/62] net/qede: add ntuple and flow director filter support
Date: Thu, 30 Mar 2017 02:11:29 +0200 (CEST)	[thread overview]
Message-ID: <20170330001129.E09416A70@dpdk.org> (raw)
In-Reply-To: <1490819822-27267-61-git-send-email-rasesh.mody@cavium.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/22826

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'flow_type' - possible side-effects?
#255: FILE: drivers/net/qede/qede_fdir.c:33:
+#define QEDE_VALID_FLOW(flow_type) \
+	((flow_type) == RTE_ETH_FLOW_FRAG_IPV4		|| \
+	(flow_type) == RTE_ETH_FLOW_NONFRAG_IPV4_TCP	|| \
+	(flow_type) == RTE_ETH_FLOW_NONFRAG_IPV4_UDP	|| \
+	(flow_type) == RTE_ETH_FLOW_FRAG_IPV6		|| \
+	(flow_type) == RTE_ETH_FLOW_NONFRAG_IPV6_TCP	|| \
+	(flow_type) == RTE_ETH_FLOW_NONFRAG_IPV6_UDP)

CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv4>
#531: FILE: drivers/net/qede/qede_fdir.c:309:
+		*ether_type = rte_cpu_to_be_16(ETHER_TYPE_IPv4);

CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv6>
#550: FILE: drivers/net/qede/qede_fdir.c:328:
+		*ether_type = rte_cpu_to_be_16(ETHER_TYPE_IPv6);

total: 0 errors, 0 warnings, 3 checks, 690 lines checked

           reply	other threads:[~2017-03-30  0:11 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1490819822-27267-61-git-send-email-rasesh.mody@cavium.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170330001129.E09416A70@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=Rasesh.Mody@cavium.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).