From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id CDC7E559A; Thu, 30 Mar 2017 23:52:53 +0200 (CEST) In-Reply-To: <1490910640-244285-2-git-send-email-michalx.k.jastrzebski@intel.com> References: <1490910640-244285-2-git-send-email-michalx.k.jastrzebski@intel.com> To: test-report@dpdk.org Cc: Michal Jastrzebski Message-Id: <20170330215253.CDC7E559A@dpdk.org> Date: Thu, 30 Mar 2017 23:52:53 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw22964 [PATCH v2 1/5] add new xstats API retrieving by id X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Mar 2017 21:52:54 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/22964 _coding style issues_ WARNING:MISSING_SPACE: break quoted strings at a space character #120: FILE: lib/librte_ether/rte_ethdev.c:1496: + RTE_PMD_DEBUG_TRACE("Cannot allocate memory" + "for xstats lookup "); WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline #275: FILE: lib/librte_ether/rte_ethdev.c:1626: + "for values_copy "); WARNING:MISSING_SPACE: break quoted strings at a space character #286: FILE: lib/librte_ether/rte_ethdev.c:1637: + RTE_PMD_DEBUG_TRACE("ERROR: id value" + "isn't valid "); WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline #286: FILE: lib/librte_ether/rte_ethdev.c:1637: + "isn't valid "); WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #299: FILE: lib/librte_ether/rte_ethdev.c:1650: + unsigned size), rte_eth_xstats_get_names_v1705); ERROR:SPACING: space required after that ',' (ctx:VxV) #325: FILE: lib/librte_ether/rte_ethdev.c:1667: + uint16_t size,i; ^ WARNING:MISSING_SPACE: break quoted strings at a space character #331: FILE: lib/librte_ether/rte_ethdev.c:1672: + RTE_PMD_DEBUG_TRACE("ERROR: Cannot allocate memory" + "for xstats "); WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline #331: FILE: lib/librte_ether/rte_ethdev.c:1672: + "for xstats "); WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #357: FILE: lib/librte_ether/rte_ethdev.c:1695: + unsigned count = 0, i, q; WARNING:UNSPECIFIED_INT: Prefer 'signed int' to bare use of 'signed' #358: FILE: lib/librte_ether/rte_ethdev.c:1696: + signed xcount = 0; WARNING:BRACES: braces {} are not necessary for single statement blocks #423: FILE: lib/librte_ether/rte_ethdev.c:1735: + if (n < count + xcount || values == NULL) { + return count + xcount; + } WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline #487: FILE: lib/librte_ether/rte_ethdev.c:1785: + "for values_copy "); WARNING:MISSING_SPACE: break quoted strings at a space character #496: FILE: lib/librte_ether/rte_ethdev.c:1794: + RTE_PMD_DEBUG_TRACE("ERROR: id value" + "isn't valid "); WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline #496: FILE: lib/librte_ether/rte_ethdev.c:1794: + "isn't valid "); WARNING:MISSING_SPACE: break quoted strings at a space character #519: FILE: lib/librte_ether/rte_ethdev.c:1817: + RTE_PMD_DEBUG_TRACE("ERROR: Cannot allocate memory" + "for xstats "); WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline #519: FILE: lib/librte_ether/rte_ethdev.c:1817: + "for xstats "); WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #562: FILE: lib/librte_ether/rte_ethdev.h:1123: + uint64_t *ids, uint64_t *values, unsigned n); WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #573: FILE: lib/librte_ether/rte_ethdev.h:1134: + struct rte_eth_xstat_name *xstats_names, uint64_t *ids, unsigned size); WARNING:LONG_LINE_COMMENT: line over 90 characters #589: FILE: lib/librte_ether/rte_ethdev.h:1477: + eth_xstats_get_by_ids_t xstats_get_by_ids; /**< Get extended device statistics by ID. */ WARNING:LONG_LINE_COMMENT: line over 90 characters #593: FILE: lib/librte_ether/rte_ethdev.h:1479: + eth_xstats_get_names_t xstats_get_names; /**< Get names of extended device statistics. */ WARNING:LONG_LINE_COMMENT: line over 90 characters #594: FILE: lib/librte_ether/rte_ethdev.h:1480: + eth_xstats_get_names_by_ids_t xstats_get_names_by_ids; /**< Get name of extended device statistics by ID. */ WARNING:LONG_LINE_COMMENT: line over 90 characters #595: FILE: lib/librte_ether/rte_ethdev.h:1481: + eth_xstats_get_by_name_t xstats_get_by_name; /**< Get extended device statistics by name. */ WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #648: FILE: lib/librte_ether/rte_ethdev.h:2351: + unsigned n); total: 1 errors, 22 warnings, 728 lines checked