From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Subject: [dpdk-test-report] |WARNING| pw22970 [PATCH 0/9] mbuf: structure reorganization
Date: Fri, 31 Mar 2017 03:01:39 +0200 (CEST) [thread overview]
Message-ID: <20170331010139.69BF428F3@dpdk.org> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB9772583FAE2DD8@IRSMSX109.ger.corp.intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/22970
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#28:
> > > Cc: dev@dpdk.org; Ananyev, Konstantin <konstantin.ananyev@intel.com>; mb@smartsharesystems.com; Chilikin, Andrey
WARNING:TYPO_SPELLING: 'noticable' may be misspelled - perhaps 'noticeable'?
#54:
> > > > > fairly noticable performance drop. I still need to dig in more, e.g. do
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#114: FILE: lib/librte_mbuf/rte_mbuf.h:1286:
+ if (likely(rte_mbuf_refcnt_read(m) == 1)) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#114: FILE: lib/librte_mbuf/rte_mbuf.h:1286:
+ if (likely(rte_mbuf_refcnt_read(m) == 1)) {
[...]
+ if (m->next != NULL) {
ERROR:CODE_INDENT: code indent should use tabs where possible
#116: FILE: lib/librte_mbuf/rte_mbuf.h:1288:
+ if (m->next != NULL) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#116: FILE: lib/librte_mbuf/rte_mbuf.h:1288:
+ if (m->next != NULL) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (15, 23)
#116: FILE: lib/librte_mbuf/rte_mbuf.h:1288:
+ if (m->next != NULL) {
+ m->next = NULL;
ERROR:CODE_INDENT: code indent should use tabs where possible
#117: FILE: lib/librte_mbuf/rte_mbuf.h:1289:
+ m->next = NULL;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#117: FILE: lib/librte_mbuf/rte_mbuf.h:1289:
+ m->next = NULL;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#118: FILE: lib/librte_mbuf/rte_mbuf.h:1290:
+ m->nb_segs = 1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#118: FILE: lib/librte_mbuf/rte_mbuf.h:1290:
+ m->nb_segs = 1;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#119: FILE: lib/librte_mbuf/rte_mbuf.h:1291:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#119: FILE: lib/librte_mbuf/rte_mbuf.h:1291:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#121: FILE: lib/librte_mbuf/rte_mbuf.h:1293:
+ if (RTE_MBUF_INDIRECT(m))$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#121: FILE: lib/librte_mbuf/rte_mbuf.h:1293:
+ if (RTE_MBUF_INDIRECT(m))$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (15, 23)
#121: FILE: lib/librte_mbuf/rte_mbuf.h:1293:
+ if (RTE_MBUF_INDIRECT(m))
+ rte_pktmbuf_detach(m);
ERROR:CODE_INDENT: code indent should use tabs where possible
#122: FILE: lib/librte_mbuf/rte_mbuf.h:1294:
+ rte_pktmbuf_detach(m);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#122: FILE: lib/librte_mbuf/rte_mbuf.h:1294:
+ rte_pktmbuf_detach(m);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#124: FILE: lib/librte_mbuf/rte_mbuf.h:1296:
+ return m;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#124: FILE: lib/librte_mbuf/rte_mbuf.h:1296:
+ return m;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#126: FILE: lib/librte_mbuf/rte_mbuf.h:1298:
+ } else if (rte_atomic16_add_return(&m->refcnt_atomic, -1) == 0) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#126: FILE: lib/librte_mbuf/rte_mbuf.h:1298:
+ } else if (rte_atomic16_add_return(&m->refcnt_atomic, -1) == 0) {
[...]
if (RTE_MBUF_INDIRECT(m))
ERROR:CODE_INDENT: code indent should use tabs where possible
#133: FILE: lib/librte_mbuf/rte_mbuf.h:1303:
+ if (m->next != NULL) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#133: FILE: lib/librte_mbuf/rte_mbuf.h:1303:
+ if (m->next != NULL) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (15, 23)
#133: FILE: lib/librte_mbuf/rte_mbuf.h:1303:
+ if (m->next != NULL) {
+ m->next = NULL;
ERROR:CODE_INDENT: code indent should use tabs where possible
#134: FILE: lib/librte_mbuf/rte_mbuf.h:1304:
+ m->next = NULL;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#134: FILE: lib/librte_mbuf/rte_mbuf.h:1304:
+ m->next = NULL;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#135: FILE: lib/librte_mbuf/rte_mbuf.h:1305:
+ m->nb_segs = 1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#135: FILE: lib/librte_mbuf/rte_mbuf.h:1305:
+ m->nb_segs = 1;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#136: FILE: lib/librte_mbuf/rte_mbuf.h:1306:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#136: FILE: lib/librte_mbuf/rte_mbuf.h:1306:
+ }$
ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 12 errors, 20 warnings, 31 lines checked
parent reply other threads:[~2017-03-31 1:01 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <2601191342CEEE43887BDE71AB9772583FAE2DD8@IRSMSX109.ger.corp.intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170331010139.69BF428F3@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).