From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id 69BF428F3; Fri, 31 Mar 2017 03:01:39 +0200 (CEST) In-Reply-To: <2601191342CEEE43887BDE71AB9772583FAE2DD8@IRSMSX109.ger.corp.intel.com> References: <2601191342CEEE43887BDE71AB9772583FAE2DD8@IRSMSX109.ger.corp.intel.com> To: test-report@dpdk.org Cc: "Ananyev, Konstantin" Message-Id: <20170331010139.69BF428F3@dpdk.org> Date: Fri, 31 Mar 2017 03:01:39 +0200 (CEST) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| pw22970 [PATCH 0/9] mbuf: structure reorganization X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Mar 2017 01:01:39 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/22970 _coding style issues_ WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #28: > > > Cc: dev@dpdk.org; Ananyev, Konstantin ; mb@smartsharesystems.com; Chilikin, Andrey WARNING:TYPO_SPELLING: 'noticable' may be misspelled - perhaps 'noticeable'? #54: > > > > > fairly noticable performance drop. I still need to dig in more, e.g. do WARNING:LEADING_SPACE: please, no spaces at the start of a line #114: FILE: lib/librte_mbuf/rte_mbuf.h:1286: + if (likely(rte_mbuf_refcnt_read(m) == 1)) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15) #114: FILE: lib/librte_mbuf/rte_mbuf.h:1286: + if (likely(rte_mbuf_refcnt_read(m) == 1)) { [...] + if (m->next != NULL) { ERROR:CODE_INDENT: code indent should use tabs where possible #116: FILE: lib/librte_mbuf/rte_mbuf.h:1288: + if (m->next != NULL) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #116: FILE: lib/librte_mbuf/rte_mbuf.h:1288: + if (m->next != NULL) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (15, 23) #116: FILE: lib/librte_mbuf/rte_mbuf.h:1288: + if (m->next != NULL) { + m->next = NULL; ERROR:CODE_INDENT: code indent should use tabs where possible #117: FILE: lib/librte_mbuf/rte_mbuf.h:1289: + m->next = NULL;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #117: FILE: lib/librte_mbuf/rte_mbuf.h:1289: + m->next = NULL;$ ERROR:CODE_INDENT: code indent should use tabs where possible #118: FILE: lib/librte_mbuf/rte_mbuf.h:1290: + m->nb_segs = 1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #118: FILE: lib/librte_mbuf/rte_mbuf.h:1290: + m->nb_segs = 1;$ ERROR:CODE_INDENT: code indent should use tabs where possible #119: FILE: lib/librte_mbuf/rte_mbuf.h:1291: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #119: FILE: lib/librte_mbuf/rte_mbuf.h:1291: + }$ ERROR:CODE_INDENT: code indent should use tabs where possible #121: FILE: lib/librte_mbuf/rte_mbuf.h:1293: + if (RTE_MBUF_INDIRECT(m))$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #121: FILE: lib/librte_mbuf/rte_mbuf.h:1293: + if (RTE_MBUF_INDIRECT(m))$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (15, 23) #121: FILE: lib/librte_mbuf/rte_mbuf.h:1293: + if (RTE_MBUF_INDIRECT(m)) + rte_pktmbuf_detach(m); ERROR:CODE_INDENT: code indent should use tabs where possible #122: FILE: lib/librte_mbuf/rte_mbuf.h:1294: + rte_pktmbuf_detach(m);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #122: FILE: lib/librte_mbuf/rte_mbuf.h:1294: + rte_pktmbuf_detach(m);$ ERROR:CODE_INDENT: code indent should use tabs where possible #124: FILE: lib/librte_mbuf/rte_mbuf.h:1296: + return m;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #124: FILE: lib/librte_mbuf/rte_mbuf.h:1296: + return m;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #126: FILE: lib/librte_mbuf/rte_mbuf.h:1298: + } else if (rte_atomic16_add_return(&m->refcnt_atomic, -1) == 0) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15) #126: FILE: lib/librte_mbuf/rte_mbuf.h:1298: + } else if (rte_atomic16_add_return(&m->refcnt_atomic, -1) == 0) { [...] if (RTE_MBUF_INDIRECT(m)) ERROR:CODE_INDENT: code indent should use tabs where possible #133: FILE: lib/librte_mbuf/rte_mbuf.h:1303: + if (m->next != NULL) {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #133: FILE: lib/librte_mbuf/rte_mbuf.h:1303: + if (m->next != NULL) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (15, 23) #133: FILE: lib/librte_mbuf/rte_mbuf.h:1303: + if (m->next != NULL) { + m->next = NULL; ERROR:CODE_INDENT: code indent should use tabs where possible #134: FILE: lib/librte_mbuf/rte_mbuf.h:1304: + m->next = NULL;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #134: FILE: lib/librte_mbuf/rte_mbuf.h:1304: + m->next = NULL;$ ERROR:CODE_INDENT: code indent should use tabs where possible #135: FILE: lib/librte_mbuf/rte_mbuf.h:1305: + m->nb_segs = 1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #135: FILE: lib/librte_mbuf/rte_mbuf.h:1305: + m->nb_segs = 1;$ ERROR:CODE_INDENT: code indent should use tabs where possible #136: FILE: lib/librte_mbuf/rte_mbuf.h:1306: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #136: FILE: lib/librte_mbuf/rte_mbuf.h:1306: + }$ ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s) total: 12 errors, 20 warnings, 31 lines checked