From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Nirmoy Das <ndas@suse.de>
Subject: [dpdk-test-report] |WARNING| pw23001 [PATCH] kni: define HAVE_VF_VLAN_PROTO for SLES12SP3
Date: Fri, 31 Mar 2017 13:33:40 +0200 (CEST) [thread overview]
Message-ID: <20170331113340.826B92BB0@dpdk.org> (raw)
In-Reply-To: <20170331113240.2399-1-ndas@suse.de>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/23001
_coding style issues_
ERROR:SPACING: space required after that ',' (ctx:VxV)
#31: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3932:
+#if (( LINUX_VERSION_CODE >= KERNEL_VERSION(4,9,0) ) \
^
ERROR:SPACING: space required after that ',' (ctx:VxV)
#31: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3932:
+#if (( LINUX_VERSION_CODE >= KERNEL_VERSION(4,9,0) ) \
^
ERROR:SPACING: space prohibited after that open parenthesis '('
#31: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3932:
+#if (( LINUX_VERSION_CODE >= KERNEL_VERSION(4,9,0) ) \
ERROR:SPACING: space prohibited before that close parenthesis ')'
#31: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3932:
+#if (( LINUX_VERSION_CODE >= KERNEL_VERSION(4,9,0) ) \
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#31: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3932:
+#if (( LINUX_VERSION_CODE >= KERNEL_VERSION(4,9,0) ) \
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#32: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3933:
+ || (defined(CONFIG_SUSE_KERNEL) && \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#33: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3934:
+ (LINUX_VERSION_CODE >= KERNEL_VERSION(4,4,57))))$
ERROR:SPACING: space required after that ',' (ctx:VxV)
#33: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3934:
+ (LINUX_VERSION_CODE >= KERNEL_VERSION(4,4,57))))
^
ERROR:SPACING: space required after that ',' (ctx:VxV)
#33: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3934:
+ (LINUX_VERSION_CODE >= KERNEL_VERSION(4,4,57))))
^
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#33: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3934:
+ (LINUX_VERSION_CODE >= KERNEL_VERSION(4,4,57))))
total: 6 errors, 4 warnings, 12 lines checked
parent reply other threads:[~2017-03-31 11:33 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20170331113240.2399-1-ndas@suse.de>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170331113340.826B92BB0@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=ndas@suse.de \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).