From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 826B92BB0; Fri, 31 Mar 2017 13:33:40 +0200 (CEST)
In-Reply-To: <20170331113240.2399-1-ndas@suse.de>
References: <20170331113240.2399-1-ndas@suse.de>
To: test-report@dpdk.org
Cc: Nirmoy Das <ndas@suse.de>
Message-Id: <20170331113340.826B92BB0@dpdk.org>
Date: Fri, 31 Mar 2017 13:33:40 +0200 (CEST)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw23001 [PATCH] kni: define
	HAVE_VF_VLAN_PROTO for SLES12SP3
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 31 Mar 2017 11:33:40 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/23001

_coding style issues_


ERROR:SPACING: space required after that ',' (ctx:VxV)
#31: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3932:
+#if (( LINUX_VERSION_CODE >= KERNEL_VERSION(4,9,0) ) \
                                              ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#31: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3932:
+#if (( LINUX_VERSION_CODE >= KERNEL_VERSION(4,9,0) ) \
                                                ^

ERROR:SPACING: space prohibited after that open parenthesis '('
#31: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3932:
+#if (( LINUX_VERSION_CODE >= KERNEL_VERSION(4,9,0) ) \

ERROR:SPACING: space prohibited before that close parenthesis ')'
#31: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3932:
+#if (( LINUX_VERSION_CODE >= KERNEL_VERSION(4,9,0) ) \

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#31: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3932:
+#if (( LINUX_VERSION_CODE >= KERNEL_VERSION(4,9,0) ) \

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#32: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3933:
+    || (defined(CONFIG_SUSE_KERNEL) && \$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#33: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3934:
+       (LINUX_VERSION_CODE >= KERNEL_VERSION(4,4,57))))$

ERROR:SPACING: space required after that ',' (ctx:VxV)
#33: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3934:
+       (LINUX_VERSION_CODE >= KERNEL_VERSION(4,4,57))))
                                               ^

ERROR:SPACING: space required after that ',' (ctx:VxV)
#33: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3934:
+       (LINUX_VERSION_CODE >= KERNEL_VERSION(4,4,57))))
                                                 ^

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#33: FILE: lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h:3934:
+       (LINUX_VERSION_CODE >= KERNEL_VERSION(4,4,57))))

total: 6 errors, 4 warnings, 12 lines checked