* [dpdk-test-report] |WARNING| pw23314 [PATCH] net: support PPPOE in software packet type parser
[not found] <CABEEbiA96pX9qP742_aZJmrHAjB94On_WuSLRCHisBAiXbbYsA@mail.gmail.com>
@ 2017-04-07 8:56 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2017-04-07 8:56 UTC (permalink / raw)
To: test-report; +Cc: Zhang Lei
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/23314
_coding style issues_
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#56: FILE: lib/librte_net/rte_ether.h:330:
+ uint8_t type_ver;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#57: FILE: lib/librte_net/rte_ether.h:331:
+ uint8_t code;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#58: FILE: lib/librte_net/rte_ether.h:332:
+ uint16_t sid;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#59: FILE: lib/librte_net/rte_ether.h:333:
+ uint16_t length;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#60: FILE: lib/librte_net/rte_ether.h:334:
+ uint16_t proto;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#81: FILE: lib/librte_net/rte_net.c:305:
+ } else if (proto == rte_cpu_to_be_16(ETHER_TYPE_PPPOE)) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#81: FILE: lib/librte_net/rte_net.c:305:
+ } else if (proto == rte_cpu_to_be_16(ETHER_TYPE_PPPOE)) {
+ const struct pppoe_hdr *ph;
ERROR:CODE_INDENT: code indent should use tabs where possible
#82: FILE: lib/librte_net/rte_net.c:306:
+ const struct pppoe_hdr *ph;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#82: FILE: lib/librte_net/rte_net.c:306:
+ const struct pppoe_hdr *ph;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#83: FILE: lib/librte_net/rte_net.c:307:
+ struct pppoe_hdr ph_copy;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#83: FILE: lib/librte_net/rte_net.c:307:
+ struct pppoe_hdr ph_copy;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#85: FILE: lib/librte_net/rte_net.c:309:
+ pkt_type = RTE_PTYPE_L2_ETHER_PPPOE;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#85: FILE: lib/librte_net/rte_net.c:309:
+ pkt_type = RTE_PTYPE_L2_ETHER_PPPOE;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#86: FILE: lib/librte_net/rte_net.c:310:
+ ph = rte_pktmbuf_read(m, off, sizeof(*ph), &ph_copy);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#86: FILE: lib/librte_net/rte_net.c:310:
+ ph = rte_pktmbuf_read(m, off, sizeof(*ph), &ph_copy);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#87: FILE: lib/librte_net/rte_net.c:311:
+ if (unlikely(ph == NULL))$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#87: FILE: lib/librte_net/rte_net.c:311:
+ if (unlikely(ph == NULL))$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (15, 23)
#87: FILE: lib/librte_net/rte_net.c:311:
+ if (unlikely(ph == NULL))
+ return pkt_type;
ERROR:CODE_INDENT: code indent should use tabs where possible
#88: FILE: lib/librte_net/rte_net.c:312:
+ return pkt_type;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#88: FILE: lib/librte_net/rte_net.c:312:
+ return pkt_type;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#90: FILE: lib/librte_net/rte_net.c:314:
+ off += sizeof(*ph);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#90: FILE: lib/librte_net/rte_net.c:314:
+ off += sizeof(*ph);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#91: FILE: lib/librte_net/rte_net.c:315:
+ hdr_lens->l2_len += sizeof(*ph);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#91: FILE: lib/librte_net/rte_net.c:315:
+ hdr_lens->l2_len += sizeof(*ph);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#92: FILE: lib/librte_net/rte_net.c:316:
+ if (ph->code != 0) /* Not Seesion Data */$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#92: FILE: lib/librte_net/rte_net.c:316:
+ if (ph->code != 0) /* Not Seesion Data */$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (15, 23)
#92: FILE: lib/librte_net/rte_net.c:316:
+ if (ph->code != 0) /* Not Seesion Data */
+ return pkt_type;
ERROR:CODE_INDENT: code indent should use tabs where possible
#93: FILE: lib/librte_net/rte_net.c:317:
+ return pkt_type;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#93: FILE: lib/librte_net/rte_net.c:317:
+ return pkt_type;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#94: FILE: lib/librte_net/rte_net.c:318:
+ if (ph->proto == rte_cpu_to_be_16(0x21))$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#94: FILE: lib/librte_net/rte_net.c:318:
+ if (ph->proto == rte_cpu_to_be_16(0x21))$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (15, 23)
#94: FILE: lib/librte_net/rte_net.c:318:
+ if (ph->proto == rte_cpu_to_be_16(0x21))
+ proto = rte_cpu_to_be_16(ETHER_TYPE_IPv4);
ERROR:CODE_INDENT: code indent should use tabs where possible
#95: FILE: lib/librte_net/rte_net.c:319:
+ proto = rte_cpu_to_be_16(ETHER_TYPE_IPv4);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#95: FILE: lib/librte_net/rte_net.c:319:
+ proto = rte_cpu_to_be_16(ETHER_TYPE_IPv4);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#96: FILE: lib/librte_net/rte_net.c:320:
+ else if (ph->proto == rte_cpu_to_be_16(0x57))$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#96: FILE: lib/librte_net/rte_net.c:320:
+ else if (ph->proto == rte_cpu_to_be_16(0x57))$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (15, 23)
#96: FILE: lib/librte_net/rte_net.c:320:
+ else if (ph->proto == rte_cpu_to_be_16(0x57))
+ proto = rte_cpu_to_be_16(ETHER_TYPE_IPv6);
ERROR:CODE_INDENT: code indent should use tabs where possible
#97: FILE: lib/librte_net/rte_net.c:321:
+ proto = rte_cpu_to_be_16(ETHER_TYPE_IPv6);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#97: FILE: lib/librte_net/rte_net.c:321:
+ proto = rte_cpu_to_be_16(ETHER_TYPE_IPv6);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#98: FILE: lib/librte_net/rte_net.c:322:
+ else$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#98: FILE: lib/librte_net/rte_net.c:322:
+ else$
ERROR:CODE_INDENT: code indent should use tabs where possible
#99: FILE: lib/librte_net/rte_net.c:323:
+ return pkt_type;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#99: FILE: lib/librte_net/rte_net.c:323:
+ return pkt_type;$
total: 16 errors, 27 warnings, 62 lines checked
^ permalink raw reply [flat|nested] only message in thread